Bug 62851 - UI: Shapes without name cannot be selected via Navigator
Summary: UI: Shapes without name cannot be selected via Navigator
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords:
: 94034 111839 (view as bug list)
Depends on:
Blocks: Object-Selection-Alignment
  Show dependency treegraph
 
Reported: 2013-03-28 08:34 UTC by Rainer Bielefeld Retired
Modified: 2023-03-29 22:26 UTC (History)
10 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Bielefeld Retired 2013-03-28 08:34:27 UTC
Steps how to reproduce with parallel Dev-installation of  "Version 4.1.0.0.alpha0+ (Build ID: 094bab7f9097fba62800d3dd578bd42640d8c6e2) TinderBox: Win-x86@6, Branch:master, Pull Time: 2013-03-18_01:35:56" ENGLISH UI / German Locale on German WIN7 Home Premium (64bit) with LODev/4 Masters User Profile 

1. Download Attachment 76812 [details] for Bug 62555, open from LibO Start Senter
2. Activate Navigator by click in Standard Toolbar if necessary
3. In Heading of Navigator Activate 'Show Shapes -> All Shapes'
4. Expand Slide 3 in Navigator
    > Shows 3 shapes
5. Try to select one of them by double click
   Bug: Impossible
6. Rightclick any shape in Slide 3 -> Name -> "MyNamedShape" <ok>
   > Name appears in navigator
7. Click into white area in slide
8. doubleclick on "MyNamedShape" in Navigator
   > Now it will be selected

That problem does not exist for OLE objects
Comment 1 Rainer Bielefeld Retired 2013-03-28 08:36:33 UTC
New due to AOOo#96488 - unnamed shapes cannot be marked via navigator

That's not a trivial bug as stated in OOo issue, worflow for editing transparent and hidden shapes could be improved very much if that function would work
Comment 2 QA Administrators 2015-02-19 15:44:18 UTC Comment hidden (obsolete)
Comment 3 Jean-Baptiste Faure 2015-03-01 14:34:18 UTC
Nothing changed. 

There is an easy workaround: name your shapes.
As this bug was always there, I think this behavior is by design. So it should be an enhancement instead of a defect. Setting importance accordingly.

Best regards. JBF
Comment 4 Buovjaga 2015-09-18 10:03:58 UTC
*** Bug 94034 has been marked as a duplicate of this bug. ***
Comment 5 MarjaE 2015-11-17 13:44:41 UTC
> There is an easy workaround: name your shapes.

WHAT?

I don't know what the "Navigator" is, or how to use it, so I don't know how well it would work if it did work.

But I don't think naming everything is an "easy workaround." I was just working on a drawing with about 1,400 objects. I group objects, which helps. Even if I wasn't clumsy, and didn't have rsi and trouble with too much typing, I don't think I would be able to nme every object.
Comment 6 MarjaE 2015-11-17 13:51:29 UTC
Anyway, I was redirected here from another selection bug, which is why I am commenting on a bug in a feature I know nothing else about.
Comment 7 Heiko Tietze 2016-06-21 12:24:17 UTC
(In reply to Jean-Baptiste Faure from comment #3)
> There is an easy workaround: name your shapes.
Which is not well supported (i.e. no item in the context menu). And when you create shapes automatically, e.g. per duplication, they do not receive a default name like Shape0815. Could be done easily. 

Another issue is that a tree indicates a selection capability. You single click items, with or without multiselection enabled. The double click usually starts a function, for instance execute the app or load the document in the associated program for file browsers. Single and multi selection is missing in Libreoffice. Also there is no indication vice versa when you select more than one object. The navigator highlights only a single item.

(In reply to MarjaE from comment #5)
> I don't know what the "Navigator" is, or how to use it, so I don't know how
> well it would work if it did work.

There is no particular help for Draw but it's the same as for Writer, Calc, or Impress (https://help.libreoffice.org/Common/Navigator). Either press F5 or use the lowest tab. It will show a tree for navigation and interaction (only a few functions are available in Draw today).
Comment 8 Cor Nouws 2016-06-21 15:58:50 UTC
Why is this "needsUXEval"?
It's new. and a useful enhancement request.
Comment 9 Heiko Tietze 2016-06-21 20:34:41 UTC
(In reply to Cor Nouws from comment #8)
> Why is this "needsUXEval"?
> It's new. and a useful enhancement request.

The use case is multiselection and the proposed way is to use the navigator. There could be alternative ways for the use case but also additional features to implement with this idea. That's why I set UX for all enhancements.
Comment 10 Cor Nouws 2016-06-21 20:42:10 UTC
(In reply to Heiko Tietze from comment #9)

> The use case is multiselection and the proposed way is to use the navigator.

The summary reads: "Shapes without name cannot be selected via Navigator"  ...
So I missed that use case. Sorry :)

Maybe it should be separate issue.
Comment 11 Mat M 2018-03-07 00:03:58 UTC
Confirmed in 6.0.2.1 and still very annoying :-/
Comment 12 Mat M 2018-03-07 00:22:19 UTC
Confirmed in 6.0.2.1, and still annoying.
Comment 13 Muhammet Kara 2019-10-30 22:06:51 UTC
After taking a quick look into this, I would see it as a real bug rather than an enhancement request.

Dev notes for anyone interested to take this on:

The unnamed shapes cannot be selected because the inner implementation uses the shape name as a reference, and constructs & uses a bookmark out of it. So if a shape is unnamed, it is displayed with a name like "Shape X", which is not actually its name, and this results in a broken link/bookmark.

One of the possible solutions might be sending the pointer of the object (after converting it into a string, and wrapping in an SfxStringItem) instead of its name. And getting the pointer to the object at the destination, by converting it back to a pointer.

This is where the bookmark is constructed: sd/source/ui/view/drviewsd.cxx:124 (else if (nSId == SID_NAVIGATOR_OBJECT))

You may check sfx2/source/doc/autoredactdialog.cxx for examples of the pointer mechanics described above. (grep/search for toInt64(), and OUString::number inside the source file)
Comment 14 Jean-Baptiste Faure 2019-11-06 21:57:57 UTC
From comment #13, changed from enhancement to normal.

Best regards. JBF
Comment 15 Heiko Tietze 2020-03-09 12:51:24 UTC
Please add keyword needsUXEval and CC libreoffice-ux-advise@lists.freedesktop.org if input from UX is needed.
Comment 16 Jim Raykowski 2022-10-15 22:31:48 UTC
I think this bug is fixed by https://gerrit.libreoffice.org/c/core/+/106958
Comment 17 Jean-Baptiste Faure 2022-10-16 15:27:36 UTC
(In reply to Jim Raykowski from comment #16)
> I think this bug is fixed by https://gerrit.libreoffice.org/c/core/+/106958

Indeed. -> Verified Fixed

Best regards. JBF
Comment 18 Stéphane Guillou (stragu) 2023-03-29 22:26:26 UTC
*** Bug 111839 has been marked as a duplicate of this bug. ***