Bug 70851 - SLIDESHOW wave underlining doesn't work in presentation mode
Summary: SLIDESHOW wave underlining doesn't work in presentation mode
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:6.2.0
Keywords:
: 97352 (view as bug list)
Depends on:
Blocks: Slide-Show
  Show dependency treegraph
 
Reported: 2013-10-24 21:21 UTC by Stephan Herrmann
Modified: 2019-01-05 17:11 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Test document (140.66 KB, application/vnd.oasis.opendocument.presentation)
2018-10-27 21:52 UTC, Stephan Herrmann
Details
Strange rendering still (41.06 KB, image/png)
2018-10-27 21:53 UTC, Stephan Herrmann
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann 2013-10-24 21:21:53 UTC
While editing a slide I can change the Font Effect Underline to Wave or one of its variants, and all is displayed correctly.

However, once I go into slide show mode, all wave underlines are shown as straight lines. The distinction bold/not bold is still correctly represented.

This problem seems to be known in OpenOffice since 2005, see https://issues.apache.org/ooo/show_bug.cgi?id=59001
And indeed opening the same document with OpenOffice (on windows in this case) shows the same problem.

I tried various fonts, and changed other things trying to find any situation, where wave underlines could be presented, but failed.
Comment 1 Dominique Boutry 2013-10-27 16:35:39 UTC
Reproduced with LibO 4.1.2.3 on Win7
Comment 2 ign_christian 2013-10-28 03:13:16 UTC
Looks like an old bug, I can also confirm with LO 4.0.6.2 (Win7 32bit), but I can't find any duplicates.
Comment 3 Jean-Baptiste Faure 2013-10-28 05:23:15 UTC
Reproducible with LibreOffice 4.0.6, 4.1.4.0.0+ and master under Ubuntu 13.04 x86-64
Set status to NEW.

Best regards. JBF
Comment 4 Stephan Herrmann 2014-03-09 13:28:47 UTC
ping, anything planned for this one?

Background: when giving presentations about the Eclipse compiler for Java, I like to show compile warnings and errors exactly as they appear in the Eclipse editor using formatted text on my slides (rather than screenshots), so I can easily add highlights and animations.

Due to this bug this is not possible.

Given that the LibreOffice editor *can* show wave underlines, would it still be hard to fix this for slideshow mode?
Comment 5 Joel Madero 2015-05-02 15:41:05 UTC Comment hidden (obsolete)
Comment 6 Stephan Herrmann 2015-05-02 17:47:55 UTC
(In reply to Joel Madero from comment #5)
> If you have time, please do the following:
> 
>    Test to see if the bug is still present on a currently supported version
> of LibreOffice (4.4.2 or later)
>    https://www.libreoffice.org/download/
> 
>    If the bug is present, please leave a comment that includes the version
> of LibreOffice and your operating system, and any changes you see in the bug
> behavior

The bug is still present in LibreOffice 4.4.2.2 Build ID: 40m0(Build:2) running on Kubuntu 15.04

None of the underline effects Wave (regular/bold/double) are rendered as wave lines during slide show, which makes the effect useless in Impress.

Adjusting version according to this similar bug: https://issues.apache.org/ooo/show_bug.cgi?id=59001 (see also comment 0).
Comment 7 Stephan Herrmann 2016-08-20 13:31:46 UTC
Still buggy using Version: 5.1.4.2 Build ID: 1:5.1.4-0ubuntu1

Using that version I today observed, that Impress *is* able to correctly render these underlines: in the "Next Slide" preview in presentation mode.

I hope that this observation helps in finding the difference that prevents correct rendering during slide shows.
Comment 8 QA Administrators 2017-09-01 11:15:20 UTC Comment hidden (obsolete)
Comment 9 Jean-Baptiste Faure 2017-09-02 07:51:13 UTC
Still there in Version: 5.4.2.0.0+
Build ID: 875baa884dd64abc9c8e454e82f584b519058e90
CPU threads: 4; OS: Linux 4.4; UI render: GL; VCL: gtk3; 
Ubuntu_16.04_x86-64
Locale: fr-FR (fr_FR.UTF-8); Calc: single

Best regards. JBF
Comment 10 QA Administrators 2018-09-03 02:43:02 UTC Comment hidden (obsolete)
Comment 11 Stephan Herrmann 2018-09-04 18:56:11 UTC
(In reply to QA Administrators from comment #10)
> If the bug is present, please leave a comment that includes the information
> from Help - About LibreOffice.

The bug is still present in:
Version: 6.0.3.2
Build ID: 1:6.0.3-0ubuntu1
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: kde4; 
Locale: de-DE (en_US.UTF-8); Calc: group


> 4a. If the bug was present with 3.3 - set version to 'inherited from OOo';

is already set in this bug.

IOW, wave underlining apparently never ever worked in presentations.
Comment 12 Stephan Herrmann 2018-10-19 20:44:22 UTC
I venture to guess that bug 37636 is related, too, which could indicate that in presentation mode several properties of underlines are ignored (the only exception: bold).

Another point in favor, underline color, just like wave style *is* correctly shown in the "Next Slide" preview, see also bug 37636 comment 16.
Comment 13 Commit Notification 2018-10-22 15:10:31 UTC
Mark Hung committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2aee5ab5a89efc8e5e42eb124afb80be637f379

tdf#70851 render wave underlines in slideshow.

It will be available in 6.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Stephan Herrmann 2018-10-27 21:52:05 UTC
Created attachment 146083 [details]
Test document

(In reply to Commit Notification from comment #13)
> Mark Hung committed a patch related to this issue.

Thanks for looking into this!

> It has been pushed to "master":
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=d2aee5ab5a89efc8e5e42eb124afb80be637f379
> 
> tdf#70851 render wave underlines in slideshow.
> 
> It will be available in 6.2.0.
> 
> The patch should be included in the daily builds available at
> http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> http://wiki.documentfoundation.org/Testing_Daily_Builds
> 
> Affected users are encouraged to test the fix and report feedback.

I picked up master~2018-10-26_20.46.25_LibreOfficeDev_6.2.0.0.alpha1_Linux_x86-64_deb.tar.gz and tested using the attached document.

While the release version fails to show any waves, the latest daily build still doesn't render the underline correctly.
Comment 15 Stephan Herrmann 2018-10-27 21:53:08 UTC
Created attachment 146084 [details]
Strange rendering still

PFA a screenshot from presentation mode showing the test document.
Comment 16 Stephan Herrmann 2018-10-27 21:55:03 UTC
(In reply to Stephan Herrmann from comment #15)
> Created attachment 146084 [details]
> Strange rendering still
> 
> PFA a screenshot from presentation mode showing the test document.

Forgot to mention that the preview (Presenter Console), which previously worked fine, now also shows the same incorrect rendering.
Comment 17 Mark Hung 2018-11-05 14:42:52 UTC
*** Bug 97352 has been marked as a duplicate of this bug. ***
Comment 18 Commit Notification 2018-11-05 23:16:25 UTC
Mark Hung committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/fff34169fa912ad5096f1652172ea2455e5cb4d3%5E%21

tdf#70851 fix strange waveline polygon.

It will be available in 6.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Jean-Baptiste Faure 2018-11-11 15:57:28 UTC
Verified fixed in Version: 6.2.0.0.alpha1+
Build ID: afbfe42e63cdba1a18c292d7eb4875009b0f19c0
Threads CPU : 4; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3; 
Ubuntu_18.04_x86-64
Locale : fr-FR (fr_FR.UTF-8); UI-Language: fr-FR
Calc: threaded

Best regards. JBF
Comment 20 Stephan Herrmann 2019-01-05 17:11:05 UTC
I also see this fixed in this pre-release:

Version: 6.2.0.1.0+
Build ID: f9f0c64be932e290a556e58ab9feea4a5d655f9d
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: kde5; 
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:libreoffice-6-2, Time: 2019-01-01_04:03:28
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded


Thanks a lot!