When change recording is on, adding a comment creates two insertion changes in the change list. I would think that this should only create a single entry in the change list, and it would be helpful if the type was 'comment', not 'insertion'...
I only get one Insertion, but let's switch the issue to the naming of the change. Win 7 64-bit Version: 4.4.0.0.alpha1+ Build ID: 8b21b5cbe78945b27525b4ce78ae3d981f90590f TinderBox: Win-x86@39, Branch:master, Time: 2014-11-06_03:55:51
Tested with Version: 7.3.1.2 (x64) / LibreOffice Community Build ID: 9fff0292474d6d0bf5df787b512c71d9ac4bc98e CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL I can only see one insertion, but I can't see the column "Type" in Manage Changes Dialog. Perhps appearance of the dialog has changed. Could you please retest? => NEEDINFO
(In reply to Dieter from comment #2) > I can only see one insertion, but I can't see the column "Type" in Manage > Changes Dialog. Perhps appearance of the dialog has changed. Could you > please retest? The name of the column is "Action" and "Insertion" is expressed with a green plus sign. In the Filter tab you can see the names of the change types in a dropdown, if you check the action box.
(In reply to Buovjaga from comment #3) > The name of the column is "Action" and "Insertion" is expressed with a green > plus sign. In the Filter tab you can see the names of the change types in a > dropdown, if you check the action box. Thank you for explanation. So ide is to have "Comment" a new action type. But before it should be clear, if comments hould be part of track changes (as far as I can see only inserting and deleting of comments are tracked as changes); see bug 147574
Let's ask UX what they think about adding a new type.
Michael, any blocker to have more action types at track changes in addition/deletion/format? Deletions are taken into the comments now (maybe the option to show deletions in margins needs to be enabled). Could imagine this as a general way for better feedback. Could be something like "(+) | <Author> | <Date> | Comment added".
Created attachment 178820 [details] Screenshot: new Insert/Delete Comment action icons in Manage Changes dialog window
Hi Heiko & Michael: here is the suggested fix for the new action icons, shown when the tracked change contains only a single comment, not any extra text changes. Likely this is a good compromise to keep it simple while offering better feedback (see on the attached screenshot): https://gerrit.libreoffice.org/c/core/+/131387
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/128d3b454467e34538903b2eab45e866f976b314 tdf#73125 sw: add Insert/Delete Comment Manage Changes action icons It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Please, file a new issue for the remaining Filter issue, i.e. filtering by the tracked comments, if it's needed.
Works like a charm. Icons are nice but it shouldn't be the only way of feedback. That's why I appreciate the automatic insertion of a TC comment, which could be "Comment added" and "Comment deleted" in this case.
(In reply to Heiko Tietze from comment #11) > Works like a charm. > > Icons are nice but it shouldn't be the only way of feedback. That's why I > appreciate the automatic insertion of a TC comment, which could be "Comment > added" and "Comment deleted" in this case. @Heiko: many thanks for your nice feedback and suggestion. Here is the proposed fix for using redline comments: https://gerrit.libreoffice.org/c/core/+/131659
(In reply to László Németh from comment #8) > Hi Heiko & Michael: here is the suggested fix for the new action icons, > shown when the tracked change contains only a single comment, not any extra > text changes. Likely this is a good compromise to keep it simple while > offering better feedback (see on the attached screenshot): > > https://gerrit.libreoffice.org/c/core/+/131387 https://geometrydash-unblocked.com I'm surprised at what you comment