Bug 73537 - Comments in Calc don't show author and date unlike Writer
Summary: Comments in Calc don't show author and date unlike Writer
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Balázs Varga (allotropia)
URL:
Whiteboard: target:24.2.0 target:7.6.0.0.beta2 in...
Keywords:
: 64999 80173 (view as bug list)
Depends on:
Blocks: Calc-Comments
  Show dependency treegraph
 
Reported: 2014-01-13 08:35 UTC by Rui Simoes
Modified: 2024-11-14 09:14 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Comments in Writer vs Comments in Calc (402.61 KB, image/png)
2014-01-13 08:35 UTC, Rui Simoes
Details
Diference between comments in Writer and in Calc (1.70 MB, image/jpeg)
2014-01-13 19:23 UTC, Rui Simoes
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rui Simoes 2014-01-13 08:35:17 UTC
Created attachment 91927 [details]
Comments in Writer vs Comments in Calc

I dont know this is a bug or something not implemented but why comments in writer have the name of author and date of comments and not in calc.

This is something I need to config?

-------
Windows 7 SP1 32bits (Portuguese-Portugal)
Libreoffice 4.0.2 (RC2)(PT-pt)
Comment 1 Rui Simoes 2014-01-13 19:23:30 UTC
Created attachment 91974 [details]
Diference between comments in Writer and in Calc
Comment 2 tommy27 2014-01-18 08:47:06 UTC
it's always been like that fro OOo era.

set status to NEW.

basically you ask to have author and date in Calc comments as well as in Writer.
this is an enhancement request.
Comment 3 Katarina Behrens (Inactive) 2017-03-09 10:37:07 UTC
*** Bug 80173 has been marked as a duplicate of this bug. ***
Comment 4 Commit Notification 2023-06-29 07:30:03 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/da8dead8e9282010893cbd12519e107baf03cd1a

tdf#73537 - sc: show author and creation date in calc comments

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-06-29 14:58:28 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/2f76c9a2aff418f7c908c4494a05f5e859a83746

tdf#73537 - sc: show author and creation date in calc comments

It will be available in 7.6.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Stéphane Guillou (stragu) 2023-07-01 13:47:33 UTC
Thanks Balázs for this improvement!

I just tested and I've got a follow-up:
Info is shown on hover reveal, but not when all comments are shown with View > Comments.
Do you want me to open a separate report or do you want to follow up here?
Cheers!

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c5bd661dc032ed8f664b0eac47f246d4d51b4d2c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 7 Maxim Monastirsky 2023-07-01 19:43:58 UTC
(In reply to Stéphane Guillou (stragu) from comment #6)
> I just tested and I've got a follow-up:
> Info is shown on hover reveal, but not when all comments are shown with View
> > Comments.
During code review we decided to not change visible comments. The reason is that the comment box often needs to be resized to fit the author/time metadata, but permanently visible comments are really part of the document layout, as they can be precisely resized and moved around, and we don't want to break the layout of existing documents. The other alternative is to append the metadata to the comment contents as editable text, like Excel does, but that will work only for new comments. (A third option might be to have a dedicated sidebar view of comments, and show the metadata there instead of in the document area. But that is way out of scope here.)
Comment 8 Maxim Monastirsky 2023-07-05 07:32:42 UTC
*** Bug 64999 has been marked as a duplicate of this bug. ***
Comment 9 Stéphane Guillou (stragu) 2023-07-05 12:37:44 UTC
(In reply to Maxim Monastirsky from comment #7)
> During code review we decided to not change visible comments.

Thanks for clarifying.

Wondering if a better option would be to automatically "pop down" the info, as an extension to the fixed-size comment box. This "pop-down" would only be visible when:
- in edit mode
- a comment is hovered over when all comments are shown
- a comment is revealed

Benefits of that would be:
- ability to see authorship when all comments are shown. It is odd that it is only possible to see that information when revealing single comments. Imagine needing to see authorship of one comment when all are shown: one would have to go to "View > Comments" to first hide them all, and _then_ hover over a cell corner to reveal, and then go back to their preferred display.
- does not change comment size as it is an extension to the fixed comment box
- does not change document layout as it only pops down on hover or on edit mode
- more consistent with Writer, which shows the info underneath the comment
- does not change position of comment text relative to the box and rest of the document (whereas the current solution moves it down).

Regarding the area expanding for showing the authorship info, Writer will ellipse long strings with "...". That popdown could do the same, and/or could have a minimum width that can overflow the comment box' width on the right.

What do you think? I can open an enhancement request as a follow-up.
(But I confess I haven't studied the Excel compatibility aspect.)

In any case, marking as verified.
Comment 10 Mike Kaganski 2023-08-23 08:36:50 UTC
This is missing in the release notes.
Comment 11 Stéphane Guillou (stragu) 2023-08-28 22:51:49 UTC
(In reply to Mike Kaganski from comment #10)
> This is missing in the release notes.

Done, with screenshot: https://wiki.documentfoundation.org/index.php?title=ReleaseNotes%2F7.6&type=revision&diff=683757&oldid=683666
Comment 12 alexahills 2024-06-25 11:43:45 UTC Comment hidden (spam)
Comment 13 gurgaonescort 2024-11-14 08:56:58 UTC Comment hidden (spam)