Bug 156885 - add toggle to show / hide authorship metadata in popup Calc comments
Summary: add toggle to show / hide authorship metadata in popup Calc comments
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.6.0.1 rc
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL: https://ask.libreoffice.org/t/comment...
Whiteboard:
Keywords: needsDevAdvice
Depends on:
Blocks: Calc-Comments
  Show dependency treegraph
 
Reported: 2023-08-23 22:09 UTC by Josh
Modified: 2023-09-08 06:42 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Josh 2023-08-23 22:09:42 UTC
Add an option to show, and not show, metadata in Calc's comment system.

NOTES: https://ask.libreoffice.org/t/comments-in-calc-added-dates-after-updating-from-7-5-to-7-6/94934/3
Comment 1 Stéphane Guillou (stragu) 2023-08-25 20:47:15 UTC
Balázs, I understand we don't have a way to turn that off currently, is that right?

In Tools > Options > LibreOffice Calc > View > Display, we already have "Comment indicator". I could imagine having "Comment authorship" in there as well.
Comment 2 Balázs Varga (allotropia) 2023-08-25 21:13:26 UTC
(In reply to Stéphane Guillou (stragu) from comment #1)
> Balázs, I understand we don't have a way to turn that off currently, is that
> right?
> 
> In Tools > Options > LibreOffice Calc > View > Display, we already have
> "Comment indicator". I could imagine having "Comment authorship" in there as
> well.

Yes, there is no config key to turn on/off this feature. Can be add ofc, but should be the default value true/turned on, I think.
Comment 3 Heiko Tietze 2023-08-28 09:59:34 UTC
Why should we make metadata optional in Calc but not other modules? What is the deal to hide the authorship from comments anyway?
Comment 4 Stéphane Guillou (stragu) 2023-08-28 10:41:52 UTC
(In reply to Heiko Tietze from comment #3)
> Why should we make metadata optional in Calc but not other modules? What is
> the deal to hide the authorship from comments anyway?

Because comments are used very differently in Calc, with their position and size relative to the rest of the content possibly being something important to the user (i.e. sized to not hide spreadsheet contents), and with the authorship possibly being completely irrelevant. (i.e. comments used as instruction popups. Users would be annoyed seeing author names and dates polluting the content.)

I previously thought they should be made more consistent with Writer's comment but Maxim's comments in bug 73537 comment 7 (and the discussion on gerrit) made me reconsider.
Comment 5 Heiko Tietze 2023-08-28 11:32:29 UTC
All good points but it still feels wrong to have an expert option. The sidebar idea sounds good, and I could imagine a function to clear metadata from (own) comments.
Comment 6 ady 2023-08-28 12:24:45 UTC
(In reply to Heiko Tietze from comment #5)
> All good points but it still feels wrong to have an expert option. The
> sidebar idea sounds good, and I could imagine a function to clear metadata
> from (own) comments.

FWIW, only recently Calc added the additional info to the comments. Additionally, normal comments (or "notes") in Calc are not the same as "tracking changes" comments, in which the author and date+time data probably have greater importance.

There are cases in which automatically adding this info in each comment might be useful, but there are (many) cases in which users want a _minimal_ comment (such as instructions, or a reminder), especially when the spreadsheet is aimed at themselves (not to be shared or edited by others). In those later cases, repeating unnecessary text within each comment is not useful (or even distracting, or even bothering).

Some Calc users might even claim that this (recently) added data should be OFF by default, imitating what was the "normal" situation until recently in LO Calc.

The (recently) added data might be useful for some users, but might be counterproductive too, so it needs some kind of toggle option or method to set it ON/OFF.
Comment 7 Stéphane Guillou (stragu) 2023-08-28 23:10:54 UTC Comment hidden (obsolete)
Comment 8 Stéphane Guillou (stragu) 2023-08-28 23:12:10 UTC
(In reply to Stéphane Guillou (stragu) from comment #7)
> What is the sidebar idea?

Ah, from Maxim's comment, got it.
Comment 9 Josh 2023-08-29 02:16:50 UTC
(In reply to Heiko Tietze from comment #3)
> Why should we make metadata optional in Calc but not other modules? What is
> the deal to hide the authorship from comments anyway?

It threw me off because it wasn't there before the update, and I have alot of comments.  I have use comments as a '3d spreadsheet' then use find to 'countif' the comments (or tags) of repeating patterns in the data set.
Comment 10 QA Administrators 2023-08-29 03:18:41 UTC Comment hidden (obsolete)
Comment 11 Eyal Rozenberg 2023-08-30 21:16:36 UTC
My opinion:

* Showing or hiding authorship metadata should indeed be toggle-able.
* It should be off by default
* The toggle should not be difficult to locate. Perhaps such a (global) toggle could appear even in the in-comment context menu.
* We could very well consider such a toggle for other modules; the fact that they don't have a toggle is not a reason to avoid adding one in Calc (especially since it seems to matter more here)
* It would be even better if the timestamp and the author could be toggled separately from each other. I might care about the date but know all comments are from just one person, for example.
Comment 12 Heiko Tietze 2023-09-08 06:42:00 UTC
The topic was on the agenda of the design meeting.

The majority agrees with the request and welcome an option. Rather than disabling a functionality I think we add a function to clear the meta data. 

And showing comments in a sidebar would be very beneficial for Calc.