Created attachment 105896 [details] showing paragraph dialog and sidebar line spacing values Steps: 1) Open writer 2) Goto paragraph dialog and set line spacing value for either at least, leading or fixed. 3) In the sidebar, open the line spacing drop down and it will have a different value than what is set Tested in 4.2.6 and master on linux. This problem also happens if you set it in the sidebar, it will have a different value when you open the paragraph dialog.
Jay, *, I don't believe there are necessarily linkages between the SVX controls of the Paragraph dialog, and the UI controls of the Paragraph Content Panel active in the SideBar deck. There is some common use of widgets and buttons, but they do not always draw settings from the same configuration. Suspect that is what is happening here. Probably another SideBar wart that should be corrected. The Dialog elements are here http://opengrok.libreoffice.org/xref/core/cui/source/tabpages/paragrph.cxx but not sure where the SideBar Paragraph Content Panel is pulling its settings from.
@Kendy, believe you tackled this with the commits Nov 4th. http://cgit.freedesktop.org/libreoffice/core/log/?id=5929a87b8137bf6326adfd4ddfd8075e585ae15c&qt=range&q=5929a87b8137bf6326adfd4ddfd8075e585ae15c..eca6f3056de43b2a74108f96df3b55633a486d0b Other than the keyboard navigation in the dropdown (bug 87120), its good. OK to close?
Unfortunately the problem is still not resolved. In the dialog, i set it to at least 1cm and then toolbar drop down shows at least 0.57cm. Version: 4.5.0.0.alpha0+ Build ID: 6163291b25d2dac74ac353c3879fdc520bee747e TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2014-12-09_01:35:51
(In reply to Jay Philips from comment #3) > Unfortunately the problem is still not resolved. In the dialog, i set it to > at least 1cm and then toolbar drop down shows at least 0.57cm. > > Version: 4.5.0.0.alpha0+ > Build ID: 6163291b25d2dac74ac353c3879fdc520bee747e > TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2014-12-09_01:35:51 @Jay, crud, you're right. @Kendy, did you miss a piece during conversion? The Formating toolbar Line spacing split button drop down matches the sidebar Paragraph Content panel Line spacing--both done with the ref'd commits. But the Format -> Paragraph Dialog Line Spacing .UI stanza is using different code--which seems disjoint from the toolbar/sidebar widget. Different list of line spaces to select and the units seem to be disconnected between the two .UI configurations. Notable on the 4.4.0 Beta builds where spacing units are in pt. rather than the inches set in sidebar (en-US defaults). Or even if changed to mm units. http://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/paraindentspacing.ui for the dialog (Format -> Paragraph) vs. http://opengrok.libreoffice.org/xref/core/svx/uiconfig/ui/paralinespacingcontrol.ui for the buttons (toolbar & sidebar).
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.4 or later) https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-12-20
The bug is still present on 5.1, 5.2 and master (5.3 alpha) How to reproduce the problem: 1- on a Writer document, right click on a paragraph → Paragraph → Indents and spacing tab → set the Line spacing as "Fixed" → set the value to, say, 0.6cm 2- go to the sidebar → Properties tab → Paragraph deck → open the "Line spacing" drop down menu → you'll see under "custom value" 0.34cm The paragraph formatting is right, but the sidebar is completely wrong.
Forgot to mention: the "Set Line Spacing" button on the Format toolbar shows the same problem.
Considering how bad the behaviour is (they show roughly the 57% of the real value), I think that *disabling* both, the sidebar and the toolbar line spacing button should be considered, at least until this problem get fixed.
Setting Assignee back to default. Please assign it back to yourself if you're still working on this issue
*** Bug 117965 has been marked as a duplicate of this bug. ***
Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
This remains an issue on current master/6.4.0alpha0 Version: 6.4.0.0.alpha0+ (x86) Build ID: 88f48b51f3cf25c78db278499d46d4913ab442ed CPU threads: 4; OS: Windows 10.0; UI render: GL; VCL: win; Locale: en-US (en_US); UI-Language: en-US Calc: threaded All of the indent and paragraph spacing values in the Sidebar look to have some rounding issues for the value being shown. But the line spacing when set "Fixed" seems to have the wrong conversion formula, as was reported in the dupe bug 117965 Seems worse if you change to a measuring unit diff from locale, and using Points to measure makes it obvious. @Jim R. its old, but you might find this of interest.
Hi all, here is a patch that seems to fix this bug - https://gerrit.libreoffice.org/#/c/73737/
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/+/849b837d1a3b185a8dd893a8f6eaed53605bcab1%5E%21 tdf#83618 Make line spacing values agree It will be available in 6.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 127943 has been marked as a duplicate of this bug. ***
@Jim, any chance of a backport to 6.3?
(In reply to V Stuart Foote from comment #16) > @Jim, any chance of a backport to 6.3? Hi Stuart, I'm not very knowledgeable about backporting. I think Xisco is the expert with that.
(In reply to Jim Raykowski from comment #17) > (In reply to V Stuart Foote from comment #16) > > @Jim, any chance of a backport to 6.3? > > Hi Stuart, > I'm not very knowledgeable about backporting. I think Xisco is the expert > with that. Done -> https://gerrit.libreoffice.org/#/c/80314/
Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-6-3": https://git.libreoffice.org/core/commit/fe3c08b5905a837cb63f57cefc8e43787c96b9c6 tdf#83618 Make line spacing values agree It will be available in 6.3.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/cd4b646040b56c1b75dd9913c6d1f5b2751f155f tdf#83618 Make line spacing values agree crash fix It will be available in 7.0.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ed6c5803cfe942932a1c7a6042808d68c2017559 tdf#83618 Make line spacing values agree crash fix It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/bb1ad6209de5433fc9f5848539d937f14cc215ce tdf#83618 Make line spacing values agree crash fix It will be available in 7.1.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I created a UItest in https://gerrit.libreoffice.org/c/core/+/109172. it works when I run it using this script < https://wiki.documentfoundation.org/Development/UITests#Running_the_test > However it fails when I execute it with make UITest_writer_tests2 UITEST_TEST_NAME=tdf83618.tdf83618.test_tdf83618, sigh
(In reply to Xisco Faulí from comment #23) > However it fails when I execute it with make UITest_writer_tests2 > UITEST_TEST_NAME=tdf83618.tdf83618.test_tdf83618, sigh It succeeds for me locally using SAL_USE_VCLPLUGIN=gen or kf5 or qt. It fails with SAl_USE_VCLPLUGIN=gtk3.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/efbdd13f96888ae06717afafb1e4014ce502aa3e tdf#154038 tdf#83618 fix wrong line spacing value It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/617558caec55960183c19ec8bedd701a674c8984 tdf#154038 tdf#83618 fix wrong line spacing value It will be available in 7.6.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.