Created attachment 106698 [details] Roundtrip before and after comparison This bug was observed on LibreOffice v4.4 under Linux. When you save as .pptx, the black and white in the pictures will be inverted the next time you open the file. Steps to reproduce the bug: 1. Open attachment 83059 [details] in Impress 2. Save as .pptx 3. Open in PowerPoint,OneDrive, or Impress 4. Compare the documents. Note In the 5 pictures in the middle, the black part has been turned to white.
Created attachment 106747 [details] stripped-down .PPTX with only 1 picture before RT
Can confirm that its in 4.4 master, 4.2.6, 3.6.7, and 3.3.0 on Linux. So the problem colors occur like this. 1) Master Slide - Parallelogram is RGB [85,85,85] on opening and [242,241,232] on reopening. 2) Slide 1 - Speaker and monitor icons are in Gray 9 on opening and [238,236,225] on reopening. 3) Slide 1 - There is a rectangle gradient going from #dddcd0 to #262626 on opening and #1f497d to #ffffff on reopening. 4) Slide 1 - There are 3 orange lines with style=continuous on opening and are blue on reopening with style=none, so they are invisible. (this is a regression as this is fine in 4.2.6) Version: 4.4.0.0.alpha0+ Build ID: 935e8fc98c033680029e4531747a2f680f50d5ca TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2014-09-21_23:17:52
Created attachment 108034 [details] document as originally rendered in Office2007
Created attachment 108035 [details] document as rendered in Office365 - PowerPoint 2013
Created attachment 108038 [details] document round trip LO433 pptx--odp--pptx on Windows w - LO 4331 So, more than just color flip on round trip--which on windows actually retains some of the black, but corrupts the object shape. The block gradients and word art is not being handled well during import into LibreOffice or on export back to OOXML.
Please ignore the rendering issue, as that has been fixed in 5.0. This bug is specifically about the regression between 4.3 and 4.4 where the black drawing( speaker and monitor) are turned white. Compare 4.3 roundtrip: attachment 108038 [details] with 4.4: attachment 106698 [details]
Created attachment 116117 [details] Simple Example of Inverted colors Here's another example of inverted color. In this case, orange -> blue on roundtrip. This is a regression, as 4.2 correctly round-trips the file.
I identified Jacobo's commits as the cause of this regression. d185dae ooxml: unit test for shape theme attributes preservation bc0a907 ooxml: Preserve shape theme attribute for solid fill 15e01d9 ooxml: Preserve shape style attribute fillRef
I have yet to check it, but the root cause could be the same as in #91332: theme xml files not being roundtripped.
Migrating Whiteboard tags to Keywords: (filter:pptx)
Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit]
Still reproducible Version: 6.0.0.0.alpha1+ Build ID: 2416d69ad4fa26b65d5b05a8575ac96af6b2c9a9 CPU threads: 2; OS: Linux 4.13; UI render: default; VCL: gtk3; Locale: zh-CN (zh_CN.UTF-8); Calc: group
Szymon Kłos, Your fix for Bug 103478 didn't address this case. Any idea what's going on?
Created attachment 139746 [details] Another Simple example of theme color lost In this example, the theme color used on the SmartArt on 2nd page is lost on export. If the first page is removed, the SmartArt's color is remembered on roundtrip.
After https://cgit.freedesktop.org/libreoffice/core/commit/?id=c344d74a6961ec39685d718fbb7c29dd186ca0a4 The orange circle in attachment 116117 [details] is no longer turning blue. However the other theme colors are still lost.
Noel, As someone who is in the process of overhauling our color handling code, do you have any thoughts on this topic? Any ideas on how to improve our interoperability with MSO documents that use themes or styles to control document colors.
Szymon Kłos committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=e673a47767cbd272d206ac50f2ac879d5ba71176 tdf#84205 If theme not found, use first It will be available in 6.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Szymon Kłos, We're getting there. The shape theme colors in attachment 139746 [details] are now preserved on roundtrip. Thanks! However, the original test doc and the stripped-down version, attachment 106747 [details] , are both still losing their color info after being roundtripped.
Szymon Kłos committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b8bb9a94266035b0d4579a7dbb3252a85fc896bc&h=libreoffice-6-0 tdf#84205 If theme not found, use first It will be available in 6.0.4. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Szymon Kłos committed a patch related to this issue. It has been pushed to "libreoffice-5-4": http://cgit.freedesktop.org/libreoffice/core/commit/?id=ee47da7ae49be26dcb69ba1b720be93720b79959&h=libreoffice-5-4 tdf#84205 If theme not found, use first It will be available in 5.4.8. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Szymon Kłos committed a patch related to this issue. It has been pushed to "libreoffice-5-4-7": http://cgit.freedesktop.org/libreoffice/core/commit/?id=40306c728ac4ba305106193637c547a699b67fdf&h=libreoffice-5-4-7 tdf#84205 If theme not found, use first It will be available in 5.4.7. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
A polite ping to Szymon Kłos: Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? Otherwise, Could you please explain what's missing? Thanks
(In reply to Xisco Faulí from comment #22) > A polite ping to Szymon Kłos: > Is this bug fixed? if so, could you please close it as RESOLVED FIXED ? > Otherwise, Could you please explain what's missing? > Thanks @Szymon Kłos, could you please reply to the questions above ?
Please see comment 18
Dear Luke, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still repo on attachment 106698 [details] and the stripped-down version, attachment 106747 [details]. Tested on Version: 7.3.0.0.alpha1+ (x86) Build ID: 4be0ae19065b1b50870bc0b2a28189ad39c96a8a Sarper Akdemir is working on this area. Should be retested when he is done.
Created attachment 190662 [details] Original left i RT opened right Reproducible for me in 24.2.