Created attachment 108470 [details] Problem with default Break setting (XLS on Left and XLSX on right) Steps to reproduce: 1. Create a chart in Excel with long label names (2 or more lines) 2. Save as .XLS and .XLSX 3. Open in Calc Note: no need to change any settings, just use all defaults. When Calc imports Excel XLS charts, it correctly sets: Text FLow:Break-enabled But for XLSX charts it sets Text FLow:Break-DISABLED This causes as the labels in XLSX to overlap and makes them unreadable.
Created attachment 108471 [details] Sample XLSX chart imported with overlapping labels
Created attachment 108472 [details] Sample XLS chart imported correctly
Created attachment 108490 [details] screenshot 4.3.x vs 4.4.x @Joey thanks 4 your report. I tested it under Win7x64 using 4.3.2.2 and 4.4.0.0.alpha1+ (*) if I save the provided XLS to XLSX and reload it, I see change in disposition of x axis labels. however in 4.3.2 the orientation in 45° oblique with no overlap (however still different from original XLS format), whilst in 4.4.0.0+ it's horizontal with overlapping text so the bug has different behaviour in 4.3.x and 4.4.x see my screenshots as an additional information, the XLSX saved by LibO are correctly displayed by MS Excel Viewer (*) Build ID: 6ba8b7f5eacac969e4781d63718083a05491b1bc TinderBox: Win-x86@42, Branch:master, Time: 2014-10-24_02:23:51
Added markus.mohrhard@googlemail.com
With Sushil's patch for Bug 84647, both issues had been resolved in 4.4, but now we are back to using the wrong OOXML defaults for: Text Flow:Overlap-enabled Text FLow:Break-enabled Could someone explain why we went back? Unless there's a good reason, could we please restore them? Thanks for looking into this!
I have merged two patches and resubmitted it. Please review. Link : https://gerrit.libreoffice.org/#/c/12213/
Sushil, Thanks for the update and all your help with this issue!
(In reply to Joey Reid from comment #5) > With Sushil's patch for Bug 84647, both issues had been resolved in 4.4, but > now we are back to using the wrong OOXML defaults for: > > Text Flow:Overlap-enabled > Text FLow:Break-enabled > > Could someone explain why we went back? Unless there's a good reason, could > we please restore them? Thanks for looking into this! As kohei explained in the commit where he reverted the change the patch is wrong as long as we don't also change the layouting algorithm: http://cgit.freedesktop.org/libreoffice/core/commit/oox/source/drawingml/chart/axismodel.cxx?id=f281d2d24c2a368c58d32b1b50acf83e0f056d90
Markus and Sushil, I was just confused because this bug had been fixed and then broken again with no mention on the tracker. Thanks for clearing that up. The reason Kohei gave for reverting the commit was "to avoid overlapping of angled text label objects." Try attachment 108471 [details] in this report with BOTH of with Sushil's patches and you'll see that the correct defaults for FLow:Break-enabled at at least partially addresses the overlapping issue caused by Bug 84647. I understand you want to be cautious with the stale and fresh builds, but shouldn't the master be using the correct defaults? That way developers are not trying to fix the layout algorithm when the root cause is incorrect defaults? Thanks so much for your help with the labeling issue!
Are the edge cases that our layout engine can't handle documented? By using the correct defaults, we can help you identify them.
We are still ignoring the OOXML break parameter causing charts with long label names to render incorrectly. Verified on: Version: 5.2.0.0.alpha1+ Build ID: 23ad336bfe61316b08f85e827b98fc593ac6908a
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.4.1 or 5.3.6 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20170929
Break parameter not imported causing chart to be incorrectly rendered in Version: 6.2.0.0.alpha0+ Build ID: 29306111ecaff2f66d4d53c990eef83cf97d1a65
This report seems to be based on an incorrect assumption that XML tag in the OOXML standard which maps to the ODF Break parameter. The fix for Bug 122091 resolved this bug https://cgit.freedesktop.org/libreoffice/core/commit/?id=015569fc919b Thanks Balazs!