Created attachment 114361 [details] screenshot Looking in the navigator tab of the sidebar in impress and draw, we can see that things are incorrectly being labelled as 'Shape X', even when they are not shapes. Wrong icons are also placed beside the incorrectly named shapes. Even the numbering is off when it deals with unnamed shapes, as can be seen in the attached screenshot, as the numbering gets reset when it jumps into a group. Version: 4.5.0.0.alpha0+ Build ID: 38c22ed2b8b8f3530b8a0fe5a23a329e8e511c76 TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2015-03-24_13:02:39
A text box also is some sort of 'shape' ?
(In reply to Cor Nouws from comment #1) > A text box also is some sort of 'shape' ? Yes it could be considered a shape, thought it is normally referred to as a frame, it should be labelled as a Text box/frame similar to how we label it 'Text Frame' in the statusbar. Same goes for inserting an image being labelled as a shape when the statusbar displays 'Bitmap'. If a user is to distinguish between all these objects being labelled 'Shape' in navigator, unless he names each of them himself, he wouldnt know what it was.
Confirmed. Win 7 Pro 64-bit Version: 4.5.0.0.alpha0+ Build ID: 8c3cf9dd48e40604867d3a28bddaccd65142df17 TinderBox: Win-x86@62-TDF, Branch:MASTER, Time: 2015-03-27_15:15:18 Locale: fi_FI
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.1.5 or 5.2.1 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20160920
Dear Yousuf Philips (jay), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still repro Arch Linux 64-bit Version: 7.1.0.0.alpha1+ Build ID: c54e1c22f30c23d00e2fe7521217569fcec59cc4 CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 13 November 2020
Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
In a recent master build, situation is slightly better: - groups have "(Group object)" appended, with a dedicated icon - text boxes have "(Text Frame '<contents>')" appended, but still the generic shape icon - found no issue in numbering Other objects not mentioned previously: - QR/barcode labelled as "Shape <number> (SVG)" (but correct image icon) - tables get "Shape <number> (Table)", but still the generic shape icon - fontwork are automatically assigned a name based on their style name (so no consistency whatsoever). Removing it reveals the default "Shape" built-in name. - formula objects, charts are assigned a generic "Object <number>" name, are shown in "Named Shapes" but editing their names shows an empty field (seems like a bug in itself) My summary of issues: - The word "Shape" is used as a default, but should probably be replaced for many objects, even if the existing appended parentheses clarify what it is (e.g. QR/barcodes, tables, images, text frames) - Inconsistency in how some objects are automatically given a name (e.g. fontwork objects) while others don't get one. Default should be no custom name. - Better icons needed for various objects (e.g. tables, formulas, charts) - Some objects listed when using the Navigator's "Named shapes" filter but "context menu > Name" shows an empty field Jim, maybe something of interest for you here? Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b10417eb1e5a4a6959e7fc1cdd9819e5b09d39a4 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded
Created attachment 187687 [details] demo of effort to improve unnamed custom shape names in
(In reply to Jim Raykowski from comment #9) > Created attachment 187687 [details] > demo of effort to improve unnamed custom shape names in Draw/Impress and improve Fontwork automatic naming in Writer/Calc WIP patch: https://gerrit.libreoffice.org/c/core/+/152568
(In reply to Stéphane Guillou (stragu) from comment #8) > - Some objects listed when using the Navigator's "Named shapes" filter but > "context menu > Name" shows an empty field Tracked in bug 138866. (In reply to Jim Raykowski from comment #9) > Created attachment 187687 [details] > demo of effort Jim, this looks great, thank you. Any chance in reviving the patch? I'd be happy to test it now.
(In reply to Stéphane Guillou (stragu) from comment #11) > Jim, this looks great, thank you. Any chance in reviving the patch? I'd be > happy to test it now. Revived :-)
Thanks Jim! :) Testing the patch and reviewing my comment 8 list: (In reply to Stéphane Guillou (stragu) from comment #8) > - The word "Shape" is used as a default, but should probably be replaced for > many objects, even if the existing appended parentheses clarify what it is > (e.g. QR/barcodes, tables, images, text frames) Still an issue. (Fixing this would also require changing the strings "Named Shapes" and "All Shapes" from the visibility dropdown. I guess replacing "Shapes" by "Objects" would be the obvious solution.) > - Inconsistency in how some objects are automatically given a name (e.g. > fontwork objects) while others don't get one. Default should be no custom > name. Solved by patch. > - Better icons needed for various objects (e.g. tables, formulas, charts) Still an issue. Because objects are grouped by page, extra visual hints are needed to navigate documents with dozens of objects. Currently, we can only tell apart 3 categories: images / OLE objects (math, chart) / everything else. In my opinion, we should have different icons at least for formulas, charts and tables. Follow-up on what your patch focuses on: wondering if you could have the same kind of type appended to "Object N" for unnamed charts and formulas?
(and to be clear: I think we should eventually split this report into bitesize chunks. I just thought we could follow up on your "automatic naming" patch before splitting whatever there is left to do.)
Note also bug 90241, related to naming objects.
Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1fd359790ed4a27902248d92ee343a4aeaf63c8e tdf#90242 Navigator: Improve custom shape naming It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.