Bug 90496 - UI: Hyperlink dialog should remember last used view
Summary: UI: Hyperlink dialog should remember last used view
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4.2.2 release
Hardware: All All
: medium enhancement
Assignee: Andreas Heinisch
URL:
Whiteboard: target:7.6.0
Keywords: needsDevEval
: 125246 129557 136263 136264 155859 (view as bug list)
Depends on:
Blocks: Dialog-Remember-Settings Hyperlink-Dialog
  Show dependency treegraph
 
Reported: 2015-04-07 13:11 UTC by respirorosso
Modified: 2023-11-01 13:03 UTC (History)
11 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description respirorosso 2015-04-07 13:11:19 UTC
After upgrading to 4.4.2.2 the behavior of Insert Hyperlink changed wrong. 


I select a text (i.e. a word) and I click Insert Hyperlink (Ctrl-K). A window appears. 

A) The window shows always "Internet" as default instead of "Document". 
"Document" had always showed as default (I always use it) until last 4.4.2.2 upgrade. 

B) the selected text (i.e. a word) is not copied in the form "Further Settings" "Text" when I change from "Internet" to "Document". 

to bypass A+B I need too much multiple clicks. 
could you please let me go back to the previous behavior? 


...
Then I also have a suggestion to make it even better: 

C) from the "Hyperlink" window under "Document" I add a "Target" to the form "Target in Document" by clicking on the bullseye. 
A window appears (always on the right, it was ok on the left) with all the objects (i use Bookmarks). **Here I suggest** to let a single click add the bookmark in the "Target in Document" form as "Target" (instead of double-clicking or clicking "Apply"), then clicking "OK" (instead of "Apply") closes the window; 
then, if we have solved A+B above, in the form "Further Settings" "Text" there already is the selected text (i.e. a word), so I only have to click "OK" to close the "Hyperlink" window with changes applied. 

very quick and neat. I recommend it.
Thank you very much.
Comment 1 Buovjaga 2015-04-15 18:22:17 UTC
Your B) is a duplicate of bug 86845.

I'm changing this to be about A) and propose that the dialog should remember the last used view.

Please create a separate enhancement request for C)

Tested on:

Win 7 Pro 64-bit, Version: 4.4.2.2
Build ID: c4c7d32d0d49397cad38d62472b0bc8acff48dd6
Locale: fi_FI

Version: 4.5.0.0.alpha0+
Build ID: afb82d3729bda2754d0add08cc6c4dce1dc76d59
TinderBox: Linux-rpm_deb-x86_64@46-TDF-dbg, Branch:master, Time: 2015-04-14_00:05:04
Locale: en_US
Comment 2 Robinson Tryon (qubit) 2015-12-13 11:21:31 UTC Comment hidden (obsolete)
Comment 3 Adolfo Jayme Barrientos 2016-06-23 23:27:12 UTC
*** Bug 100557 has been marked as a duplicate of this bug. ***
Comment 4 Dieter 2019-05-13 13:50:28 UTC
*** Bug 125246 has been marked as a duplicate of this bug. ***
Comment 5 Heiko Tietze 2019-05-13 13:55:08 UTC
Question was raised again in bug 125246. If we store the last UI position it would also apply to other dialogs like paragraph style. Do we want to remember the last tab, and if so a) per document, b) session, c) workplace respectively user configuration.
Comment 6 Cor Nouws 2019-06-07 07:42:11 UTC
(In reply to Heiko Tietze from comment #5)
> Question was raised again in bug 125246. If we store the last UI position it
> would also apply to other dialogs like paragraph style. Do we want to
> remember the last tab, and if so a) per document, b) session, c) workplace
> respectively user configuration.
In some (many?) cases, the TAB of a dialog is remembered between use.
Comment 7 TorrAB 2019-06-08 16:07:36 UTC
	The default choice (at the beginning of a session) 'Internet' is arbitrary. After the user has chosen 'Document', it can be expected that he will choose it again during the session —in the same document, or across several of them; he can change his choice, anyway.
Comment 8 Thomas Lendo 2019-10-15 19:17:24 UTC
I prefer user configuration. What's the benefit of only session?
Comment 9 TorrAB 2019-10-15 22:20:35 UTC Comment hidden (obsolete)
Comment 10 Heiko Tietze 2019-10-16 08:30:17 UTC
(In reply to TorrAB from comment #9)
> OK. How does the user specify his/her preference?

It would be stored silently in the registry and applied when ever you open the dialog again. Per session means the default tab is reset when you restart the application. And per document is self-explaining.
Comment 11 Heiko Tietze 2019-10-17 12:24:36 UTC
Benefit of the session only solution is that different scenarios require different workflows and therefore it makes sense to start with a default. But the general rule as requested in the meta bug 109265 makes also sense. So let's remember the last used tab position and restore it at the next session.
Comment 12 Dieter 2020-08-30 10:25:20 UTC
*** Bug 136263 has been marked as a duplicate of this bug. ***
Comment 13 Dieter 2020-09-14 06:34:51 UTC
*** Bug 136264 has been marked as a duplicate of this bug. ***
Comment 14 R. Green 2022-01-20 16:15:09 UTC
I also support the dialog opening at the last user view.
Comment 15 R. Green 2022-07-10 10:15:46 UTC
Relatd to this issue: The default window size for the dialog is usually too narrow to see the heading titles. And even if you adjust the document window to make it large enough to SEE the titles … the size resets to default the next time you open it!
Comment 16 Commit Notification 2023-04-28 18:35:09 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a9cea0ddeb5cd51db0720f96af75af75120908d9

tdf#90496 - Remember last used view in hyperlink dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 BogdanB 2023-04-29 03:46:54 UTC
Andreas, thanks for fixing this one.

Verified. Solved in
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a1acc2f46cc499631d66b1d7a923ed15ab4f28de
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

Is not ok in Version: 7.5.2.1 (X86_64) / LibreOffice Community
Build ID: e8bf3b441b8370f8440b0339fd9490765a8d57ca
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 18 Commit Notification 2023-05-03 16:51:25 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ebfd2f10b400ad215ccd2263267f48a79b1427ef

tdf#90496 - Remember last used view in hyperlink dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Andreas Heinisch 2023-05-03 16:54:45 UTC
I changed it from user configuration to session.
Comment 20 BogdanB 2023-05-03 18:02:20 UTC
I verified again, is per session now. After closing LO and opening again is the default.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d4ec4b875b952b05b8b1e0ba73dc31c1bcd27e43
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 21 Andreas Heinisch 2023-11-01 12:45:11 UTC
*** Bug 129557 has been marked as a duplicate of this bug. ***
Comment 22 Buovjaga 2023-11-01 13:03:15 UTC
*** Bug 155859 has been marked as a duplicate of this bug. ***