Bug 90810 - Writer generates A LOT of line feeds in footnotes when opening docx document
Summary: Writer generates A LOT of line feeds in footnotes when opening docx document
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.1.0
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-23 11:06 UTC by Vitaliy Filippov
Modified: 2016-10-10 12:02 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
The offending document (57.20 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2015-04-23 11:06 UTC, Vitaliy Filippov
Details
The bad result (72.66 KB, application/vnd.oasis.opendocument.text)
2015-04-23 11:14 UTC, Vitaliy Filippov
Details
The offending document compared MSO-LO (140.06 KB, image/jpeg)
2015-10-06 09:50 UTC, Timur
Details
The offending document compared MSO-LO FIXED (200.00 KB, image/jpeg)
2015-10-14 10:11 UTC, Timur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaliy Filippov 2015-04-23 11:06:56 UTC
Created attachment 115030 [details]
The offending document

When opening the attached DOCX document in LibreOffice, all footnotes become VERY long due to a LOT of added line feeds which weren't there in the original document.

Reproduces both on Windows and Linux, at least up to version 4.3.3 release.

May be related to Bug 39205.
Comment 1 Vitaliy Filippov 2015-04-23 11:14:56 UTC
Created attachment 115031 [details]
The bad result
Comment 2 Buovjaga 2015-04-25 14:17:55 UTC
Confirmed.

Win 7 Pro 64-bit Version: 5.0.0.0.alpha1+ (x64)
Build ID: f3375fa07f27bd2ade519af3c07d69040d10eaa9
TinderBox: Win-x86_64@42, Branch:master, Time: 2015-04-22_23:38:50
Locale: fi_FI

Ubuntu 15.04 64-bit
OpenOffice.org 3.3.0
OOO330m20 (Build:9567)
Comment 3 Timur 2015-10-06 09:50:40 UTC
Created attachment 119340 [details]
The offending document compared MSO-LO
Comment 4 Commit Notification 2015-10-06 16:20:50 UTC
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=3eff65e78a3a90b07c7a01ff26736fd25996e476

tdf#90810: skip all elements outside of the requested footnote

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2015-10-07 07:56:51 UTC
Stephan Bergmann committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=955c8f4c7b6038aa802e33074623b8eab0494d0c

Revert "tdf#90810: skip all elements outside of the requested footnote"

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2015-10-07 15:25:59 UTC
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7e50b8073ef40d1bbe79c1c4d6c967d760283b5a

tdf#90810: skip breaks outside of the requested footnote

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Timur 2015-10-12 15:27:48 UTC
I guess it's fixed. Please backport.
Not so simple to test as before because daily builds for Windows are late.
Comment 8 Timur 2015-10-14 10:11:53 UTC
Created attachment 119600 [details]
The offending document compared MSO-LO FIXED

Looks like the problem in this bug is fixed. I guess the document still suffers from Bug 86726 - FILEOPEN: Spacing and Line spacing increased in DOCX Footnote.
Comment 9 Cor Nouws 2015-12-15 10:24:15 UTC
Checked in 5.1.0 beta2 and master 5.2. Looks good. Thanks!
(Is not yet backported to 5.0.x or 4.4.x)