Steps to reproduce: 1. Draw a shape in PowerPoint 2. Save ( ex: attachment 116696 [details] ) 3. Open in Impress 4. Save ( ex: attachment 116697 [details]) 5. Close and reopen in Impress Note the round-tripped file has a thicker line width This maybe to related to the fact the file is corrupted, Bug 92221
Yep, 0,07 cm instead of 0,04 cm. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: 3ecef8cedb215e49237a11607197edc91639bfcd TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-06-19_23:16:58 Locale: fi-FI (fi_FI)
When values get changed on roundtrip, it's often a OOXML transitional vs OOXML 2013 default that needs to be set/changed. Moggi fixed a bunch of these with his recent OOXML chart export fixes. Could that be the case here? Adding Andras who's been improving the DrawingML export filters.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.1.6 or 5.2.3 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20170103
.01" -> .03" Version: 5.4.0.0.alpha0+ (x64) Build ID: bf80bbb7b75febc2769d6b64e6981224982f8fe2
Created attachment 139744 [details] Triangle created in MSO 2007 correctly imported with 2pt line width In the .pptx file, by changing \ppt\theme\theme1.xml FROM: <a:ln algn="ctr" cmpd="sng" cap="flat" w="9525"> <a:ln algn="ctr" cmpd="sng" cap="flat" w="25400"> <a:ln algn="ctr" cmpd="sng" cap="flat" w="38100"> TO: <a:ln algn="ctr" cmpd="sng" cap="flat" w="6350"> <a:ln algn="ctr" cmpd="sng" cap="flat" w="12700"> <a:ln algn="ctr" cmpd="sng" cap="flat" w="19050"> I was able to fix this issue. The TO: are the defaults MS Office 2013, and 2016 uses. MS Office 2007 uses the old FROM: defaults. Our pptx importer correctly reads and uses these values, but they are lost on export.
Created attachment 139745 [details] Triangle created in MSO 2016 correctly imported with 1 pt line width Here is a 2016 file to compare the theme1.xml
Tamás. You have been working on the exporter. Is this something you could take a look at?
https://cgit.freedesktop.org/libreoffice/core/commit/?id=c344d74a6961ec39685d718fbb7c29dd186ca0a4 Preserved the color attribute in themes.
On roundtrip, shapes with the default, 1 pt., line width are still being changed to 2 pt. in Version: 6.2.0.0.alpha0+ (x64) Build ID: 5e8cd8683d345b75297994b3f7aab851835eb124 If a manual width is specified, line widths are correctly preserved on roundtrip.
Created attachment 147030 [details] We have retested this problem and it seems to be fixed in version 6.1.2.
(In reply to Luke from comment #0) > Steps to reproduce: > 1. Draw a shape in PowerPoint > 2. Save ( ex: attachment 116696 [details] ) > 3. Open in Impress > 4. Save ( ex: attachment 116697 [details]) > 5. Close and reopen in Impress > > Note the round-tripped file has a thicker line width Still repro, reverting status change. Arch Linux 64-bit Version: 6.3.0.0.alpha0+ Build ID: 51e6a95757906dff8b2819a4141bf3dc7938e95f CPU threads: 8; OS: Linux 4.19; UI render: default; VCL: gtk3_kde5; Locale: fi-FI (fi_FI.UTF-8); UI-Language: en-US Calc: threaded Built on 24 November 2018
This looks very similar to Bug 92223 which was fixed by remembering the schemes in the theme. https://cgit.freedesktop.org/libreoffice/core/commit/?id=c344d74a6961
Dear Luke, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
*** Bug 151952 has been marked as a duplicate of this bug. ***
Tibor Nagy committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/25e9766e9b87342b6f1b29dc146d5f33e12157a7 tdf#92222 PPTX export: fix line width of the shape in theme It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in: Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 651658d37bcb3f493942dd5d0b9a0d65c96f105c CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL threaded
Tibor Nagy committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/3c58ab7f075a0c8528f00a9f22919e598c18e092 tdf#92222 PPTX export: fix line width of the shape in theme It will be available in 7.4.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Tibor Nagy The fix for this breaks files that were created with older versions of MSO. All you've done is change the default from the old standard to the new one? Lines on older MSO files like attachment 139744 [details] are now converted from 2 pts to 1 on roundtrip? Did you consider a more general solution?
@Tibor Did you take a look at https://cgit.freedesktop.org/libreoffice/core/commit/?id=c344d74a6961 It's the same issue of different color defaults instead of thickness, but solves it by remembering the color scheme from loaded OOXML file.