Bug 92484 - UI: lock toolbar by default
Summary: UI: lock toolbar by default
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
3.3.0 release
Hardware: All All
: medium enhancement
Assignee: ahmad_g
URL:
Whiteboard: target:7.0.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Toolbars
  Show dependency treegraph
 
Reported: 2015-07-01 19:11 UTC by Marek Dolezel
Modified: 2021-05-11 06:54 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Dolezel 2015-07-01 19:11:32 UTC
I think we should have a toolbar locked by default to avoid accidental removal. I do realize that you can make it visible again if removed, but average Benjamin may not realize this.
Comment 1 tommy27 2015-07-01 21:07:39 UTC
enhancement request. status NEW.
Comment 2 Robinson Tryon (qubit) 2016-08-25 05:49:39 UTC Comment hidden (obsolete)
Comment 3 Heiko Tietze 2017-03-09 10:59:07 UTC
You are talking about "Lock Toolbar Position" in general and not specifically for the Standard or Formatting toolbar? Is there an issue or large number of requests that boils down to undocked toolbars?
Comment 4 Heiko Tietze 2017-03-21 16:53:54 UTC
Basically we want freedom for users and locking toolbars so that everyone needs to disabled the lock first is the opposite. The response to this request was low, so I close it as WFM.
Comment 5 andreas_k 2018-04-26 15:25:09 UTC
I would lock the toolbars by default, cause right click to unlock (and configure) toolbars are not that difficult to recognize and the benefit would be that you can't move them around accidentally.
Comment 6 Samuel Mehrbrodt (allotropia) 2018-04-26 15:31:58 UTC
Agree with Andreas.
Moving toolbars around is an expert feature, and experts should be able to unlock them.

Reopening this bug.
Comment 7 Pedro 2018-04-26 15:34:39 UTC
I fully agree with Marek Dolezel, Andreas and Samuel.
The toolbars should be locked by default in all available toolbars.Even as an advanced user sometimes I accidentally move toolbars around. I can imagine how confusing this must be to a less proefficient user.

Also unlocking a toolbar to move it around is something an advanced user easily knows how to do.
Comment 8 Heiko Tietze 2018-04-26 15:45:43 UTC Comment hidden (obsolete)
Comment 9 Samuel Mehrbrodt (allotropia) 2018-04-26 15:48:12 UTC Comment hidden (obsolete)
Comment 10 Pedro 2018-04-27 09:42:56 UTC Comment hidden (obsolete)
Comment 11 Heiko Tietze 2018-04-28 05:37:01 UTC Comment hidden (obsolete)
Comment 12 Pedro 2018-04-29 11:14:33 UTC Comment hidden (obsolete)
Comment 13 Heiko Tietze 2018-04-30 13:11:50 UTC Comment hidden (obsolete)
Comment 14 Pedro 2018-04-30 19:59:19 UTC Comment hidden (me-too)
Comment 15 andreas_k 2018-04-30 20:22:24 UTC Comment hidden (me-too)
Comment 16 Heiko Tietze 2018-05-01 07:33:26 UTC Comment hidden (obsolete)
Comment 17 andreas_k 2018-05-01 07:48:13 UTC Comment hidden (obsolete)
Comment 18 Heiko Tietze 2018-05-01 07:59:48 UTC Comment hidden (obsolete)
Comment 19 Pedro 2018-05-01 10:12:54 UTC Comment hidden (obsolete)
Comment 20 Heiko Tietze 2018-05-02 04:51:49 UTC Comment hidden (obsolete)
Comment 21 Pedro 2018-05-02 08:43:23 UTC Comment hidden (obsolete)
Comment 22 Heiko Tietze 2019-03-11 15:22:20 UTC
Flagged my hesitation comments as obsolete. Toolbars should become locked by default and have to get unlocked manually. It requires to add the property Locked=true in *WindowState.xcu (and reset the profile).

For example, officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu

<node oor:name="private:resource/toolbar/standardbar" oor:op="replace">
...     
  <prop oor:name="Locked" oor:type="xs:boolean">
    <value>true</value>
  </prop>
...
</node>

It's a lot of grunt work...

"find . -name *WindowState.xcu"
./officecfg/registry/data/org/openoffice/Office/UI/WriterFormWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/ChartWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/MathWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbRelationWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/XFormsWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/StartModuleWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/BasicIDEWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbQueryWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/WriterWebWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbTableWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/WriterReportWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbReportWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbBrowserWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/BaseWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DbTableDataWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu
./officecfg/registry/data/org/openoffice/Office/UI/CalcWindowState.xcu
(and some other non-relevant files)

grep "private:resource/toolbar/" officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu
      <node oor:name="private:resource/toolbar/standardbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/findbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/textobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/toolbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/tableobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/numobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/drawingobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/alignmentbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/bezierobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/extrusionobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/formtextobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/formsfilterbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/formsnavigationbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/formcontrols" oor:op="replace">
      <node oor:name="private:resource/toolbar/moreformcontrols" oor:op="replace">
      <node oor:name="private:resource/toolbar/formdesign" oor:op="replace">
      <node oor:name="private:resource/toolbar/frameobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/fullscreenbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/graffilterbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/graphicobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/insertbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/oleobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/optimizetablebar" oor:op="replace">
      <node oor:name="private:resource/toolbar/previewobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/drawtextobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/viewerbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/drawbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/mediaobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/colorbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/basicshapes" oor:op="replace">
      <node oor:name="private:resource/toolbar/arrowshapes" oor:op="replace">
      <node oor:name="private:resource/toolbar/flowchartshapes" oor:op="replace">
      <node oor:name="private:resource/toolbar/starshapes" oor:op="replace">
      <node oor:name="private:resource/toolbar/symbolshapes" oor:op="replace">
      <node oor:name="private:resource/toolbar/calloutshapes" oor:op="replace">
      <node oor:name="private:resource/toolbar/fontworkobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/fontworkshapetype" oor:op="replace">
      <node oor:name="private:resource/toolbar/navigationobjectbar" oor:op="replace">
      <node oor:name="private:resource/toolbar/changes" oor:op="replace">
      <node oor:name="private:resource/toolbar/textstylebar" oor:op="replace">
Comment 23 Samuel Mehrbrodt (allotropia) 2019-03-12 06:41:09 UTC
Instead of changing every single file, it would probably make more sense to just change the default to "Locked" just once.

https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/globalsettings.cxx?r=a457c7c6#173
Comment 24 ahmad_g 2020-02-20 15:25:58 UTC
(In reply to Heiko Tietze from comment #22)
> Flagged my hesitation comments as obsolete. Toolbars should become locked by
> default and have to get unlocked manually. It requires to add the property
> Locked=true in *WindowState.xcu (and reset the profile).
> 
> For example,
> officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu
> 
> <node oor:name="private:resource/toolbar/standardbar" oor:op="replace">
> ...     
>   <prop oor:name="Locked" oor:type="xs:boolean">
>     <value>true</value>
>   </prop>
> ...
> </node>
> 
> It's a lot of grunt work...
> 
> "find . -name *WindowState.xcu"
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterFormWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/ChartWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/MathWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbRelationWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/XFormsWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/StartModuleWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.
> xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/BasicIDEWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbQueryWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterWebWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbTableWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterReportWindowState.
> xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbReportWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbBrowserWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/BaseWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbTableDataWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/CalcWindowState.xcu
> (and some other non-relevant files)
> 
> grep "private:resource/toolbar/"
> officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu
>       <node oor:name="private:resource/toolbar/standardbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/findbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/textobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/toolbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/tableobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/numobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/drawingobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/alignmentbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/bezierobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/extrusionobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/formtextobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/formsfilterbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/formsnavigationbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/formcontrols"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/moreformcontrols"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/formdesign" oor:op="replace">
>       <node oor:name="private:resource/toolbar/frameobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/fullscreenbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/graffilterbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/graphicobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/insertbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/oleobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/optimizetablebar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/previewobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/drawtextobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/viewerbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/drawbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/mediaobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/colorbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/basicshapes" oor:op="replace">
>       <node oor:name="private:resource/toolbar/arrowshapes" oor:op="replace">
>       <node oor:name="private:resource/toolbar/flowchartshapes"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/starshapes" oor:op="replace">
>       <node oor:name="private:resource/toolbar/symbolshapes"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/calloutshapes"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/fontworkobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/fontworkshapetype"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/navigationobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/changes" oor:op="replace">
>       <node oor:name="private:resource/toolbar/textstylebar"
> oor:op="replace">


Could it be done by changing this line to locked(true)?

Code pointer : https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/windowstateconfiguration.cxx?r=8c6ca694#156
Comment 25 Heiko Tietze 2020-02-20 15:29:12 UTC
(In reply to ahmad_g from comment #24)
> Could it be done by changing this line to locked(true)?
> 
> Code pointer :
> https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/
> windowstateconfiguration.cxx?r=8c6ca694#156

Think it was Samuel's idea in comment 23.
Comment 26 ahmad_g 2020-02-20 20:25:45 UTC
(In reply to Heiko Tietze from comment #25)
> (In reply to ahmad_g from comment #24)
> > Could it be done by changing this line to locked(true)?
> > 
> > Code pointer :
> > https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/
> > windowstateconfiguration.cxx?r=8c6ca694#156
> 
> Think it was Samuel's idea in comment 23

Yup, i saw the comment. i was just trying to apply it and build it to make sure it's valid so i was asking to verify the line i was thinking of it's the one to be changed but it made no change when i build it.
Comment 27 ahmad_g 2020-02-26 20:12:01 UTC
(In reply to Heiko Tietze from comment #22)
> Flagged my hesitation comments as obsolete. Toolbars should become locked by
> default and have to get unlocked manually. It requires to add the property
> Locked=true in *WindowState.xcu (and reset the profile).
> 
> For example,
> officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu
> 
> <node oor:name="private:resource/toolbar/standardbar" oor:op="replace">
> ...     
>   <prop oor:name="Locked" oor:type="xs:boolean">
>     <value>true</value>
>   </prop>
> ...
> </node>
> 
> It's a lot of grunt work...
> 
> "find . -name *WindowState.xcu"
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterFormWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/ChartWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/MathWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbRelationWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/XFormsWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/StartModuleWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.
> xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/BasicIDEWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbQueryWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterWebWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbTableWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/WriterReportWindowState.
> xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbReportWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbBrowserWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/BaseWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DbTableDataWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu
> ./officecfg/registry/data/org/openoffice/Office/UI/CalcWindowState.xcu
> (and some other non-relevant files)
> 
> grep "private:resource/toolbar/"
> officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu
>       <node oor:name="private:resource/toolbar/standardbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/findbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/textobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/toolbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/tableobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/numobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/drawingobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/alignmentbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/bezierobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/extrusionobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/formtextobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/formsfilterbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/formsnavigationbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/formcontrols"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/moreformcontrols"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/formdesign" oor:op="replace">
>       <node oor:name="private:resource/toolbar/frameobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/fullscreenbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/graffilterbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/graphicobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/insertbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/oleobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/optimizetablebar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/previewobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/drawtextobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/viewerbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/drawbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/mediaobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/colorbar" oor:op="replace">
>       <node oor:name="private:resource/toolbar/basicshapes" oor:op="replace">
>       <node oor:name="private:resource/toolbar/arrowshapes" oor:op="replace">
>       <node oor:name="private:resource/toolbar/flowchartshapes"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/starshapes" oor:op="replace">
>       <node oor:name="private:resource/toolbar/symbolshapes"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/calloutshapes"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/fontworkobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/fontworkshapetype"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/navigationobjectbar"
> oor:op="replace">
>       <node oor:name="private:resource/toolbar/changes" oor:op="replace">
>       <node oor:name="private:resource/toolbar/textstylebar"
> oor:op="replace">

I waited for Samuel to solve the bug the way he suggested. i will try your suggestion for now until an easier way to be done. i just want you to check my change after me. 

I will search for every toolbar and make it Locked true.
Comment 28 Maxim Monastirsky 2020-02-26 21:14:41 UTC
Changing this single line should do the trick (after resetting the user profile):

https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/UI/WindowState.xcs?r=46b720b1#33
Comment 29 ahmad_g 2020-02-26 22:07:08 UTC
(In reply to Maxim Monastirsky from comment #28)
> Changing this single line should do the trick (after resetting the user
> profile):
> 
> https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/
> openoffice/Office/UI/WindowState.xcs?r=46b720b1#33

I've tried your suggestion and  Heiko Tietze suggestion part for standardbar only
and i make build-nocheck for it to see the change and i see no change it's not locked i open writer with command soffice --writer. changing in master branch. is any part of this wrong?
Comment 30 Maxim Monastirsky 2020-02-26 22:20:57 UTC
(In reply to ahmad_g from comment #29)
> i open writer with command soffice --writer
This opens your system LO, not the one you build. You need to run instdir/program/soffice --writer instead.

Also make sure to reset the user profile, i.e. remove the instdir/user directory (if exists).
Comment 31 ahmad_g 2020-02-26 22:32:45 UTC
(In reply to Maxim Monastirsky from comment #30)
> (In reply to ahmad_g from comment #29)
> > i open writer with command soffice --writer
> This opens your system LO, not the one you build. You need to run
> instdir/program/soffice --writer instead.
> 
> Also make sure to reset the user profile, i.e. remove the instdir/user
> directory (if exists).

Thank you! It works now! toolbar is locked thanks to your hint.
Comment 32 ahmad_g 2020-02-27 16:04:28 UTC
I've submitted the patch successfully! but it needs mentor to review so it can be merged.
Comment 33 Buovjaga 2020-02-27 16:19:41 UTC
(In reply to ahmad_g from comment #32)
> I've submitted the patch successfully! but it needs mentor to review so it
> can be merged.

I found it: https://gerrit.libreoffice.org/c/core/+/89603
Comment 34 Commit Notification 2020-02-27 17:22:04 UTC
A_GAN committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f2db813374b8d65e1edec1387fa0c534b40885e1

tdf#92484 UI: lock toolbar by default

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 35 Warren 2020-09-12 17:14:47 UTC
I would not lock them, or give the user the ability to unlock them.
This is part of the learning process for new users. If they use another office program and the toolbars disappear, they will not know how to fix it.
One of the features that I use all the time is the ability to use the tear-off options for some of the formatting toolbars.
Such as background color, font color, borders. These are must haves for those of us that do lots of formatting all the time.
Just my opinion.
Comment 36 Maxim Monastirsky 2020-09-12 17:33:02 UTC
(In reply to Warren from comment #35)
> or give the user the ability to unlock them.
There is. Right click on a toolbar > Lock Toolbar Position toggles the locking state.

> One of the features that I use all the time is the ability to use the
> tear-off options for some of the formatting toolbars.
> Such as background color, font color, borders. These are must haves for
> those of us that do lots of formatting all the time.
This is a regression from the welding work, and has nothing to do with the change made in this bug. Please report it in a new bug.
Comment 37 Warren 2020-09-12 17:46:24 UTC
(In reply to Maxim Monastirsky from comment #36)
> (In reply to Warren from comment #35)
> > or give the user the ability to unlock them.
> There is. Right click on a toolbar > Lock Toolbar Position toggles the
> locking state.
> 
> > One of the features that I use all the time is the ability to use the
> > tear-off options for some of the formatting toolbars.
> > Such as background color, font color, borders. These are must haves for
> > those of us that do lots of formatting all the time.
> This is a regression from the welding work, and has nothing to do with the
> change made in this bug. Please report it in a new bug.

This moves the toolbar. It does not unlock the tearoffs!
Comment 38 Maxim Monastirsky 2020-09-12 17:50:43 UTC
(In reply to Warren from comment #37)
> This moves the toolbar. It does not unlock the tearoffs!
Again - the tearoff problem is *not related* in any way to the change that was made in this bug. Please open a new bug for this problem.
Comment 39 Warren 2020-09-12 18:01:40 UTC
(In reply to Maxim Monastirsky from comment #38)
> (In reply to Warren from comment #37)
> > This moves the toolbar. It does not unlock the tearoffs!
> Again - the tearoff problem is *not related* in any way to the change that
> was made in this bug. Please open a new bug for this problem.

Bullcrap! when you made your change it took away the ability to do tearoffs.
The same thing was done when v5.3 was released, and then it was fixed.
Comment 40 Maxim Monastirsky 2020-09-12 18:55:35 UTC
(In reply to Warren from comment #39)
Oh, great! So I assume you're familiar with the code, or at least did a proper bibisect (https://wiki.documentfoundation.org/QA/Bibisect), so that you make the claim that the tearoff problem is a result of this bug?

The only chance to get the problem fixed, is to properly report it in a new dedicated bug. Posting here unrelated comments certainly won't help.
Comment 41 Buovjaga 2020-09-12 20:22:41 UTC
(In reply to Warren from comment #39)
> (In reply to Maxim Monastirsky from comment #38)
> > (In reply to Warren from comment #37)
> > > This moves the toolbar. It does not unlock the tearoffs!
> > Again - the tearoff problem is *not related* in any way to the change that
> > was made in this bug. Please open a new bug for this problem.
> 
> Bullcrap! when you made your change it took away the ability to do tearoffs.
> The same thing was done when v5.3 was released, and then it was fixed.

Warren: please learn to discuss in a non-raging way.
Comment 42 Warren 2020-09-13 13:08:48 UTC
(In reply to Maxim Monastirsky from comment #40)
> (In reply to Warren from comment #39)
> Oh, great! So I assume you're familiar with the code, or at least did a
> proper bibisect (https://wiki.documentfoundation.org/QA/Bibisect), so that
> you make the claim that the tearoff problem is a result of this bug?
> 
> The only chance to get the problem fixed, is to properly report it in a new
> dedicated bug. Posting here unrelated comments certainly won't help.

No Sir, I am just a product user. Bug has been reported. Sorry if I offended you, or any other member of this group. Thank you for setting me straight!
Comment 43 Warren 2020-09-13 13:11:04 UTC
(In reply to Buovjaga from comment #41)
> (In reply to Warren from comment #39)
> > (In reply to Maxim Monastirsky from comment #38)
> > > (In reply to Warren from comment #37)
> > > > This moves the toolbar. It does not unlock the tearoffs!
> > > Again - the tearoff problem is *not related* in any way to the change that
> > > was made in this bug. Please open a new bug for this problem.
> > 
> > Bullcrap! when you made your change it took away the ability to do tearoffs.
> > The same thing was done when v5.3 was released, and then it was fixed.
> 
> Warren: please learn to discuss in a non-raging way.

Sir, please my answer in Comment 42. My apologies.
Comment 44 Buovjaga 2020-09-13 13:48:01 UTC
(In reply to Warren from comment #42)
> (In reply to Maxim Monastirsky from comment #40)
> > (In reply to Warren from comment #39)
> > Oh, great! So I assume you're familiar with the code, or at least did a
> > proper bibisect (https://wiki.documentfoundation.org/QA/Bibisect), so that
> > you make the claim that the tearoff problem is a result of this bug?
> > 
> > The only chance to get the problem fixed, is to properly report it in a new
> > dedicated bug. Posting here unrelated comments certainly won't help.
> 
> No Sir, I am just a product user. Bug has been reported. Sorry if I offended
> you, or any other member of this group. Thank you for setting me straight!

Ok, I searched with your info and found you had reported bug 136520. Let's continue there.
Comment 45 Ninpodeshi 2021-04-15 07:30:23 UTC
PLEASE undo this!
I am trying to be civil, so apologies in advance if this seems harsh.


A Solution in Search of a Problem.

I've used LO for several years and never had an issue with accidental undocking of toolbars.  Yes, I undocked several when I first started using LO, but that only made me curious to explore the program. The accidental undockings were easy to replace when I needed to continue working.  But, when I wasn't pressed for time, I played with the feature and learned that I could dock toolbars anywhere I wanted!  By locking them, that natural learning is prohibited.  Also, as I'll discuss below, the unintuitive method of unlocking the toolbars makes it unlikely that a new user would ever find it without searching for online help.  But, then again, the new user would not even know to search out how to unlock & undock the toolbars because this is a feature unique to LO. This effectively hides one of LO's most useful and innovative features.  (I only know of a couple web browsers that even make use of the sides of the screen for interface commands, and they are nowhere near as useful or versatile as LO's interface.)


A Solution Creating Problems.

I have had to search how to unlock the toolbars 3 different times now.  When I right-click on a toolbar, I do not get the pop-up menu unless I right-click twice.  This is very unintuitive and makes me think I am not doing it right, which is why I have had to look up how to unlock the toolbars 3 times now.

But then the problems go further.  It is not just the unintuitive double-right-clicking, but one must double-right-click EACH toolbar separately in order to unlock them.  Why?  That compiles annoyance on top of annoyance.  

How much annoyance is justified to prevent the perceived problem?  Double-right-clicking each toolbar is annoying.  Hopefully, I won't forget this oddity in a month or so when I need a toolbar I haven't used in this install yet and forget how to unlock them.  I just reinstalled LO, so I will find out if I must also unlock each separate toolbar on every program, but, honestly, this is a time wasting annoyance.


Hiding LO's Utility under an Antiquated Interface.

Without the ability to undock a toolbar, the toolbar interface looks like the old out-of-date MS Office interface. The buttons are either present or absent, which is no different than the MS pre-Ribbon interface.  For the new user who is unaware of LO's toolbar versatility, this essentially hides the feature.

 The ability to move LO toolbars around is wonderful.  Combined with the Sidebar, they allow the user to dedicate more screen space to the document by placing toolbars to the side.  (To clarify with a contrast, if the toolbars were placed only on top, they would eat into the vertical space and force the user to shrink the zoom on the document in order to see it in its entirety.)  I find this more efficient space use to be a great feature of LO.

Even better, LO allows intuitive toolbar placement.  In Draw, for example, I maintain the toolbars common to Writer at the top and can place the more Draw related toolbars on the bottom and side.  This makes it much easier to find the needed functions.

I came to LO after using Ribbon in MS Office.  I thought the notebook/grouped bar interface was great when it came out.  (It's still great, btw, and you folks at LO did a really cool thing by making the different interfaces that people can choose from.)  Then I decided to update my skills and went through some LO trainings online.  

The LO trainings introduced me to the Sidebar and really showed me the utility of the toolbars.  I now vastly prefer the standard toolbar interface to the grouped bar because of its versatility and utility.  If the toolbars were locked by default when I first began using LO, I'm not sure I ever would have discovered this feature, and LO would have just looked like an Antiquated MS copy instead of the unique and innovative office suite that it is.


In summary, this change does little to nothing to fix any perceived problem.  It does however, create annoyances and problems for users while hiding one of LO's most intuitive and versatile features.  Please, please, please, change it back.
Comment 46 Buovjaga 2021-04-15 07:32:25 UTC
Reopened is the wrong status, so reverting.
Comment 47 Buovjaga 2021-04-15 07:33:53 UTC
(In reply to Ninpodeshi from comment #45)
> I have had to search how to unlock the toolbars 3 different times now.  When
> I right-click on a toolbar, I do not get the pop-up menu unless I
> right-click twice.  This is very unintuitive and makes me think I am not
> doing it right, which is why I have had to look up how to unlock the
> toolbars 3 times now.
> 
> But then the problems go further.  It is not just the unintuitive
> double-right-clicking, but one must double-right-click EACH toolbar
> separately in order to unlock them.  Why?  That compiles annoyance on top of
> annoyance.  

Please create new reports for these specific problems.
Comment 48 Ninpodeshi 2021-04-15 08:17:11 UTC
(In reply to Buovjaga from comment #46)
> Reopened is the wrong status, so reverting.

I did not see reverting as an option.

As for the problems, there is only one: locking the toolbars by default.  The other problems resolve once the default locking is removed.  Should I create a new bug report for that?
Comment 49 Ninpodeshi 2021-04-15 08:18:01 UTC
Nevermind. 

I see that you meant you reverted it to resolved status.

I'll file a new bug report.
Comment 50 Buovjaga 2021-04-15 08:20:55 UTC
(In reply to Ninpodeshi from comment #48)
> (In reply to Buovjaga from comment #46)
> > Reopened is the wrong status, so reverting.
> 
> I did not see reverting as an option.

I meant to say that I reverted your status change. Reopened is for bugs not completely fixed, while you wanted to communicate your disagreement.

> As for the problems, there is only one: locking the toolbars by default. 
> The other problems resolve once the default locking is removed.  Should I
> create a new bug report for that?

No, you should create reports for the right-click issue (which I do not experience myself) and your idea for changing the behaviour to unlocking all toolbars at once.
Comment 51 Heiko Tietze 2021-04-15 08:32:37 UTC
(In reply to Ninpodeshi from comment #49)
> I'll file a new bug report.

Comment on this bug 131817
Comment 52 BogdanB 2021-05-10 07:18:10 UTC
It's ok in Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 1a99b4e44190e182d56a04678850d62635d74c65
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

The toolbar is locked by default. And it's very easy to unlock it.
Comment 53 Ninpodeshi 2021-05-10 11:25:35 UTC
Locked by default IS the problem.  

I'm only running 7.1.2, but it is extremely annoying to unlock each toolbar separately.  It seems that one must unlock them for each program in the suite too, though I'm not sure about this.  

Sometimes, right clicking on the toolbar does not pull up the menu that allows one to unlock the toolbar.  I now know to just try again until the right-click menu shows, but this still wastes time to unlock the toolbars over and over again.

Further, locking the toolbars be default hides one of the most innovative features of the LO UI -- the ability to dock or float toolbars whenever and where ever one wants.    This feature is great when doing a lot of editing.  When toolbars are locked, however, there is no intuitive way to see how to undock and move them, especially for new users. I discovered this feature purely by accident, and likely never would have found it if the toolbars were locked.  Please don't hide one of the best features of the UI.  

I must ask also, how do we know that users want the toolbars set in stone?  Have there been multiple complaints, or some sort of user feedback?  It really does more to limit one's choices than to expand them, especially for new users.
Comment 54 Ninpodeshi 2021-05-10 11:49:05 UTC
(In reply to Buovjaga from comment #50)
> (In reply to Ninpodeshi from comment #48)
> > (In reply to Buovjaga from comment #46)
> > > Reopened is the wrong status, so reverting.
> > 
> > I did not see reverting as an option.
> 
> I meant to say that I reverted your status change. Reopened is for bugs not
> completely fixed, while you wanted to communicate your disagreement.
> 
> > As for the problems, there is only one: locking the toolbars by default. 
> > The other problems resolve once the default locking is removed.  Should I
> > create a new bug report for that?
> 
> No, you should create reports for the right-click issue (which I do not
> experience myself) and your idea for changing the behaviour to unlocking all
> toolbars at once.

Buovjaga, 

I should create a report for the right-click issue?  

I cannot tell what the exact problem is.  Right-clicking on a toolbar often does not bring the drop down menu that allows one to unlock.  I often have to right click a few times before I get the menu.  When I do get the drop down menu, there is often a lag between right-clicking it and it appearing.  I do not notice this lag when clicking on toolbar icons or clicking on the regular drop-down menus. 

This is made more problematic because of the way the toolbars often auto-resize and sit next to other toolbars.  They blend into each other visually.  Before right-clicking to unlock, I check for the vertical dots to see if it is already unlocked.  When locked, the vertical dots are not present, and that makes it difficult to see where one toolbar ends and the next begins.  

(Apologies for the length.  I'm trying to be precise so you can determine if I should file this as a bug report.)

As far as the cause of this particular bug, I cannot say.  I often have 3 of the LO programs open at once when I'm working on a project.  So, it could be that I'm taxing the processor too much?  You know better than I how complicated bug tracing can be, and I wouldn't be surprised if this is yet another problem caused by Win10.  What I do know, though, is that this problem did not occur before the toolbars were locked by default.
Comment 55 Buovjaga 2021-05-10 12:38:44 UTC
(In reply to Ninpodeshi from comment #54)
> Buovjaga, 
> 
> I should create a report for the right-click issue?  

I guess so
Comment 56 Heiko Tietze 2021-05-10 13:45:03 UTC
(In reply to Ninpodeshi from comment #54)
> I cannot tell what the exact problem is.  Right-clicking on a toolbar often
> does not bring the drop down menu that allows one to unlock.

Enabled/disabled items?
Comment 57 BogdanB 2021-05-10 18:47:11 UTC
Could be unlock available for all toolbars at once? And again when lock toolbars to lock all at once?
Comment 58 Buovjaga 2021-05-11 06:54:29 UTC
(In reply to BogdanB from comment #57)
> Could be unlock available for all toolbars at once? And again when lock
> toolbars to lock all at once?

Heiko mentioned bug 131817 in comment 51