I think we should have a toolbar locked by default to avoid accidental removal. I do realize that you can make it visible again if removed, but average Benjamin may not realize this.
enhancement request. status NEW.
We're replacing our use of the 'ux-advise' component with a keyword: Component -> LibreOffice Add Keyword: needsUXEval [NinjaEdit]
You are talking about "Lock Toolbar Position" in general and not specifically for the Standard or Formatting toolbar? Is there an issue or large number of requests that boils down to undocked toolbars?
Basically we want freedom for users and locking toolbars so that everyone needs to disabled the lock first is the opposite. The response to this request was low, so I close it as WFM.
I would lock the toolbars by default, cause right click to unlock (and configure) toolbars are not that difficult to recognize and the benefit would be that you can't move them around accidentally.
Agree with Andreas. Moving toolbars around is an expert feature, and experts should be able to unlock them. Reopening this bug.
I fully agree with Marek Dolezel, Andreas and Samuel. The toolbars should be locked by default in all available toolbars.Even as an advanced user sometimes I accidentally move toolbars around. I can imagine how confusing this must be to a less proefficient user. Also unlocking a toolbar to move it around is something an advanced user easily knows how to do.
Locked toolbars make the UI jumping. Unlocked and floating is a way to avoid this.
(In reply to Heiko Tietze from comment #8) > Locked toolbars make the UI jumping. Don't understand what you mean with jumping. How would that be any different to unlocked toolbars?
I would also like to know why... Supposedly locking would prevent jumping?
(In reply to Samuel Mehrbrodt (CIB) from comment #9) > Don't understand what you mean with jumping. How would that be any different > to unlocked toolbars? I read "locked" as "docked". A docked toolbar occupies space, either vertically or horizontally. And when it shows up the other content adjusts its position.
No, locked means right-clicking the toolbar and lock its position. Since we are offering default UIs like the Standard Toolbar, Single Toolbar and Sidebar. It doesn't make sense that the toolbars in these UIs are unlocked and the user can accidentally move the toolbars around.
(In reply to Pedro from comment #12) > No, locked means right-clicking the toolbar and lock its position. > Since we are offering default UIs like the Standard Toolbar, Single Toolbar > and Sidebar. It doesn't make sense that the toolbars in these UIs are > unlocked and the user can accidentally move the toolbars around. If the majority thinks that is a good idea I'm not opposing. However, right click and close is also not too far away.
So Samuel, Andreas do you agree about locking the toolbars by default?
+1
Please introduce this as an option so we can keep the familiar behavior for the standard layout and NB designers decide whether toolbars are locked or not.
Confuse l thought its only for standard toolbars in NB there are no toolbars.
(In reply to andreas_k from comment #17) > Confuse l thought its only for standard toolbars in NB there are no toolbars. There are user interface variants with Notebookbars - and those can be docked. But I don't see a reason to change the familiar standard interface. So I recommend to do it optional with the UI definition.
But we are not changing the familiar Standard interface. We are just locking the standard toolbar interface in place so that people don't accidentally move it around. I don't understand your grievance?
(In reply to Pedro from comment #19) > But we are not changing the familiar Standard interface. We are just locking > the standard toolbar interface in place so that people don't accidentally > move it around. > > I don't understand your grievance? The standard layout allows today undocking without the need to unlock and we should keep that. The locked property should be changed only for Notebookbars (or rater any non-standard UI).
Okay, we know that. However, Marek, Samuel, Andreas and me agree on locking the toolbar by default while you disagree. I guess this means that the toolbars should be locked by default any way?
Flagged my hesitation comments as obsolete. Toolbars should become locked by default and have to get unlocked manually. It requires to add the property Locked=true in *WindowState.xcu (and reset the profile). For example, officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu <node oor:name="private:resource/toolbar/standardbar" oor:op="replace"> ... <prop oor:name="Locked" oor:type="xs:boolean"> <value>true</value> </prop> ... </node> It's a lot of grunt work... "find . -name *WindowState.xcu" ./officecfg/registry/data/org/openoffice/Office/UI/WriterFormWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/ChartWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/MathWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/DbRelationWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/XFormsWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/StartModuleWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/BasicIDEWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/DbQueryWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/WriterWebWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/DbTableWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/WriterReportWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/DbReportWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/DbBrowserWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/BaseWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/DbTableDataWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu ./officecfg/registry/data/org/openoffice/Office/UI/CalcWindowState.xcu (and some other non-relevant files) grep "private:resource/toolbar/" officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu <node oor:name="private:resource/toolbar/standardbar" oor:op="replace"> <node oor:name="private:resource/toolbar/findbar" oor:op="replace"> <node oor:name="private:resource/toolbar/textobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/toolbar" oor:op="replace"> <node oor:name="private:resource/toolbar/tableobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/numobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/drawingobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/alignmentbar" oor:op="replace"> <node oor:name="private:resource/toolbar/bezierobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/extrusionobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/formtextobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/formsfilterbar" oor:op="replace"> <node oor:name="private:resource/toolbar/formsnavigationbar" oor:op="replace"> <node oor:name="private:resource/toolbar/formcontrols" oor:op="replace"> <node oor:name="private:resource/toolbar/moreformcontrols" oor:op="replace"> <node oor:name="private:resource/toolbar/formdesign" oor:op="replace"> <node oor:name="private:resource/toolbar/frameobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/fullscreenbar" oor:op="replace"> <node oor:name="private:resource/toolbar/graffilterbar" oor:op="replace"> <node oor:name="private:resource/toolbar/graphicobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/insertbar" oor:op="replace"> <node oor:name="private:resource/toolbar/oleobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/optimizetablebar" oor:op="replace"> <node oor:name="private:resource/toolbar/previewobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/drawtextobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/viewerbar" oor:op="replace"> <node oor:name="private:resource/toolbar/drawbar" oor:op="replace"> <node oor:name="private:resource/toolbar/mediaobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/colorbar" oor:op="replace"> <node oor:name="private:resource/toolbar/basicshapes" oor:op="replace"> <node oor:name="private:resource/toolbar/arrowshapes" oor:op="replace"> <node oor:name="private:resource/toolbar/flowchartshapes" oor:op="replace"> <node oor:name="private:resource/toolbar/starshapes" oor:op="replace"> <node oor:name="private:resource/toolbar/symbolshapes" oor:op="replace"> <node oor:name="private:resource/toolbar/calloutshapes" oor:op="replace"> <node oor:name="private:resource/toolbar/fontworkobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/fontworkshapetype" oor:op="replace"> <node oor:name="private:resource/toolbar/navigationobjectbar" oor:op="replace"> <node oor:name="private:resource/toolbar/changes" oor:op="replace"> <node oor:name="private:resource/toolbar/textstylebar" oor:op="replace">
Instead of changing every single file, it would probably make more sense to just change the default to "Locked" just once. https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/globalsettings.cxx?r=a457c7c6#173
(In reply to Heiko Tietze from comment #22) > Flagged my hesitation comments as obsolete. Toolbars should become locked by > default and have to get unlocked manually. It requires to add the property > Locked=true in *WindowState.xcu (and reset the profile). > > For example, > officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu > > <node oor:name="private:resource/toolbar/standardbar" oor:op="replace"> > ... > <prop oor:name="Locked" oor:type="xs:boolean"> > <value>true</value> > </prop> > ... > </node> > > It's a lot of grunt work... > > "find . -name *WindowState.xcu" > ./officecfg/registry/data/org/openoffice/Office/UI/WriterFormWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/ChartWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/MathWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbRelationWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/XFormsWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/StartModuleWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState. > xcu > ./officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/BasicIDEWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbQueryWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/WriterWebWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbTableWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/WriterReportWindowState. > xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbReportWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbBrowserWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/BaseWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbTableDataWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/CalcWindowState.xcu > (and some other non-relevant files) > > grep "private:resource/toolbar/" > officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu > <node oor:name="private:resource/toolbar/standardbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/findbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/textobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/toolbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/tableobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/numobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/drawingobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/alignmentbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/bezierobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/extrusionobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/formtextobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/formsfilterbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/formsnavigationbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/formcontrols" > oor:op="replace"> > <node oor:name="private:resource/toolbar/moreformcontrols" > oor:op="replace"> > <node oor:name="private:resource/toolbar/formdesign" oor:op="replace"> > <node oor:name="private:resource/toolbar/frameobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/fullscreenbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/graffilterbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/graphicobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/insertbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/oleobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/optimizetablebar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/previewobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/drawtextobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/viewerbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/drawbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/mediaobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/colorbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/basicshapes" oor:op="replace"> > <node oor:name="private:resource/toolbar/arrowshapes" oor:op="replace"> > <node oor:name="private:resource/toolbar/flowchartshapes" > oor:op="replace"> > <node oor:name="private:resource/toolbar/starshapes" oor:op="replace"> > <node oor:name="private:resource/toolbar/symbolshapes" > oor:op="replace"> > <node oor:name="private:resource/toolbar/calloutshapes" > oor:op="replace"> > <node oor:name="private:resource/toolbar/fontworkobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/fontworkshapetype" > oor:op="replace"> > <node oor:name="private:resource/toolbar/navigationobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/changes" oor:op="replace"> > <node oor:name="private:resource/toolbar/textstylebar" > oor:op="replace"> Could it be done by changing this line to locked(true)? Code pointer : https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/windowstateconfiguration.cxx?r=8c6ca694#156
(In reply to ahmad_g from comment #24) > Could it be done by changing this line to locked(true)? > > Code pointer : > https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/ > windowstateconfiguration.cxx?r=8c6ca694#156 Think it was Samuel's idea in comment 23.
(In reply to Heiko Tietze from comment #25) > (In reply to ahmad_g from comment #24) > > Could it be done by changing this line to locked(true)? > > > > Code pointer : > > https://opengrok.libreoffice.org/xref/core/framework/source/uiconfiguration/ > > windowstateconfiguration.cxx?r=8c6ca694#156 > > Think it was Samuel's idea in comment 23 Yup, i saw the comment. i was just trying to apply it and build it to make sure it's valid so i was asking to verify the line i was thinking of it's the one to be changed but it made no change when i build it.
(In reply to Heiko Tietze from comment #22) > Flagged my hesitation comments as obsolete. Toolbars should become locked by > default and have to get unlocked manually. It requires to add the property > Locked=true in *WindowState.xcu (and reset the profile). > > For example, > officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu > > <node oor:name="private:resource/toolbar/standardbar" oor:op="replace"> > ... > <prop oor:name="Locked" oor:type="xs:boolean"> > <value>true</value> > </prop> > ... > </node> > > It's a lot of grunt work... > > "find . -name *WindowState.xcu" > ./officecfg/registry/data/org/openoffice/Office/UI/WriterFormWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/ChartWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/MathWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbRelationWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/XFormsWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/StartModuleWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState. > xcu > ./officecfg/registry/data/org/openoffice/Office/UI/ImpressWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/BasicIDEWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbQueryWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/WriterWebWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbTableWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/WriterReportWindowState. > xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbReportWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbBrowserWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/BaseWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DbTableDataWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/DrawWindowState.xcu > ./officecfg/registry/data/org/openoffice/Office/UI/CalcWindowState.xcu > (and some other non-relevant files) > > grep "private:resource/toolbar/" > officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu > <node oor:name="private:resource/toolbar/standardbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/findbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/textobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/toolbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/tableobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/numobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/drawingobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/alignmentbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/bezierobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/extrusionobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/formtextobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/formsfilterbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/formsnavigationbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/formcontrols" > oor:op="replace"> > <node oor:name="private:resource/toolbar/moreformcontrols" > oor:op="replace"> > <node oor:name="private:resource/toolbar/formdesign" oor:op="replace"> > <node oor:name="private:resource/toolbar/frameobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/fullscreenbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/graffilterbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/graphicobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/insertbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/oleobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/optimizetablebar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/previewobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/drawtextobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/viewerbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/drawbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/mediaobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/colorbar" oor:op="replace"> > <node oor:name="private:resource/toolbar/basicshapes" oor:op="replace"> > <node oor:name="private:resource/toolbar/arrowshapes" oor:op="replace"> > <node oor:name="private:resource/toolbar/flowchartshapes" > oor:op="replace"> > <node oor:name="private:resource/toolbar/starshapes" oor:op="replace"> > <node oor:name="private:resource/toolbar/symbolshapes" > oor:op="replace"> > <node oor:name="private:resource/toolbar/calloutshapes" > oor:op="replace"> > <node oor:name="private:resource/toolbar/fontworkobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/fontworkshapetype" > oor:op="replace"> > <node oor:name="private:resource/toolbar/navigationobjectbar" > oor:op="replace"> > <node oor:name="private:resource/toolbar/changes" oor:op="replace"> > <node oor:name="private:resource/toolbar/textstylebar" > oor:op="replace"> I waited for Samuel to solve the bug the way he suggested. i will try your suggestion for now until an easier way to be done. i just want you to check my change after me. I will search for every toolbar and make it Locked true.
Changing this single line should do the trick (after resetting the user profile): https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/UI/WindowState.xcs?r=46b720b1#33
(In reply to Maxim Monastirsky from comment #28) > Changing this single line should do the trick (after resetting the user > profile): > > https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/ > openoffice/Office/UI/WindowState.xcs?r=46b720b1#33 I've tried your suggestion and Heiko Tietze suggestion part for standardbar only and i make build-nocheck for it to see the change and i see no change it's not locked i open writer with command soffice --writer. changing in master branch. is any part of this wrong?
(In reply to ahmad_g from comment #29) > i open writer with command soffice --writer This opens your system LO, not the one you build. You need to run instdir/program/soffice --writer instead. Also make sure to reset the user profile, i.e. remove the instdir/user directory (if exists).
(In reply to Maxim Monastirsky from comment #30) > (In reply to ahmad_g from comment #29) > > i open writer with command soffice --writer > This opens your system LO, not the one you build. You need to run > instdir/program/soffice --writer instead. > > Also make sure to reset the user profile, i.e. remove the instdir/user > directory (if exists). Thank you! It works now! toolbar is locked thanks to your hint.
I've submitted the patch successfully! but it needs mentor to review so it can be merged.
(In reply to ahmad_g from comment #32) > I've submitted the patch successfully! but it needs mentor to review so it > can be merged. I found it: https://gerrit.libreoffice.org/c/core/+/89603
A_GAN committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f2db813374b8d65e1edec1387fa0c534b40885e1 tdf#92484 UI: lock toolbar by default It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
