Bug 92824 - Limit the number of context menu spellcheck/autocorrect suggestions
Summary: Limit the number of context menu spellcheck/autocorrect suggestions
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
3.6.0.4 release
Hardware: Other All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevEval, topicUI
: 124436 (view as bug list)
Depends on:
Blocks: Context-Menu Spell-Checking AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2015-07-19 07:41 UTC by tommy27
Modified: 2019-04-18 13:05 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (68.55 KB, image/png)
2015-07-19 07:41 UTC, tommy27
Details
The Hunspell driven spellcheck & autocorrect popup with just English dictionary (19.44 KB, image/png)
2016-10-05 13:59 UTC, V Stuart Foote
Details
Hunspell driven F7 dialog for "Hk" search (12.51 KB, image/png)
2016-10-05 14:03 UTC, V Stuart Foote
Details
F7 dialog (125.41 KB, image/jpeg)
2016-10-05 14:16 UTC, tommy27
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tommy27 2015-07-19 07:41:12 UTC
Created attachment 117325 [details]
screenshot

spin-off of Bug 92774

Where a short acronym (2 or 3 letters) is not in the dictionary, right clicking may produce a very long list of autocorrect options. It is necessary to scroll down to the options for handling this - ignore, add to dictionary etc. 

as you may see in the screenshot the amount of autocorrect suggestions is so long that makes very annoying tanf time consuming to scroll down trough the list to reach the option items.

so, I think it would be better to limit the number of those autocorrect suggestions (I think 20 would be enough) in order to avoid the scrolling and always have to options items always at reach
Comment 1 tommy27 2015-07-19 07:53:31 UTC
reproducible even in older versions, at least up to 3.6.0 but I suspect is inherited from OOo
Comment 2 John 2015-07-19 08:12:46 UTC
I confirm that this could do with improvement, either by arbitrarily limiting the number of choices offered or, perhaps better, to review the logic behind the offered suggestions. For example, putting dwp into LO generates a screenful of options. In Word 2010 (only when I must...) just 5 options are offered.
Comment 3 Jean-Baptiste Faure 2015-07-20 05:15:38 UTC
If I understand well, it has nothing to do with auto-correction. It is not auto-correct suggestions but correct spelling suggestions.

Best regards. JBF
Comment 4 tommy27 2015-07-20 05:52:27 UTC
@JBF
I do not agree.
if  you select one of those suggestions, LibO will correct the typed word with that choice.

if you wanna that LibO reminds that replacement for the next time you type it you have to select one of the bottom menu items which is "Always correct to" which reopens the same list.

in both cases, dealing with such long lists is annoying and unproductive...
from my experience is unlikely that the desired autocorrect replacement will be in the last items of the list...

as said before 20 would be enough...
Comment 5 Robinson Tryon (qubit) 2016-08-25 05:38:58 UTC Comment hidden (obsolete)
Comment 6 tommy27 2016-10-05 07:38:03 UTC
still present in LibO 5.1.5.2
Comment 7 V Stuart Foote 2016-10-05 13:59:27 UTC
Created attachment 127825 [details]
The Hunspell driven spellcheck & autocorrect popup with just English dictionary

@tommy27, *

Is this an integration issue with Hunspell? 

On WIndows 10 Pro with 5.2.2 and *only* the en-US dictionary installed.

If using the same "Hk" digraph I get a sane list of alternates that actually relate to the digraph entered (attached).

The clips you show seem to have really strange suggestions, as if the replacements are being pulled from dictionaries for multiple languages without regard for the language of the paragraph.

What shows for you with cursor on the "Hk" digraph and entering the F7 "Spelling and Gramar:" dialog? What other entries are in the "Text language" list box?
Comment 8 V Stuart Foote 2016-10-05 14:03:09 UTC
Created attachment 127826 [details]
Hunspell driven F7 dialog for "Hk" search

The Hunspell driven F7 "Spelling and Grammar" dialog for the same "Hk" search.
Comment 9 tommy27 2016-10-05 14:16:13 UTC
Created attachment 127827 [details]
F7 dialog

here it is
Comment 10 Yousuf Philips (jay) (retired) 2016-10-07 06:22:41 UTC
With 8 entries already in the main context menu, the suggestion list should likely not exceed 10 entries. For users who want more suggestions, they have easy access to jump into the spelling or autocorrect dialogs from the context menu.

If more entries are wanted to be shown, maybe a more submenu entry can appear at the bottom of the suggestions, but this shouldnt have more than 20 entries in it. The autocorrect submenu can have 20 entries in it, if wanted.
Comment 11 tommy27 2016-10-07 07:00:14 UTC
hi jay, is something you are able to tweak? 

as seen in my screenshot, sometimes the list of suggested entries is really too long.

I agree we should limit it to a number between 10 and 20.
Comment 12 Yousuf Philips (jay) (retired) 2016-10-07 07:21:00 UTC
hey tommy, nope not likely something i can tweak. :(

So lets pass it on to the devs. :)
Comment 13 V Stuart Foote 2016-10-07 13:37:48 UTC
No, the problem with an artificial limit to the number of lookups is that the source "dictionary" can not qualify the match--so there is good chance the match needed will not show at the top of the list before filtering. The list needs to be complete--and a "more" button or scroll provided to keep the lists height constrained.

The other problem seems to be that currently the Hunspell dictionary and grammar checker is not filtering out the candidate matches.  We get selections from all installed dictionaries/word lists--but the result should be limited. 

Seems it should by default return matches from the dictionary/thesaurus for the selected language of the paragraph being entered, or maybe that of the document. But not return matches from all installed dictionaries/word lists as it seems to be doing now.
Comment 14 Yousuf Philips (jay) (retired) 2016-10-07 16:09:02 UTC
(In reply to V Stuart Foote from comment #13)
> No, the problem with an artificial limit to the number of lookups is that
> the source "dictionary" can not qualify the match--so there is good chance
> the match needed will not show at the top of the list before filtering. The
> list needs to be complete--and a "more" button or scroll provided to keep
> the lists height constrained.

Having an endlessly scrolling list to show ever possible lookup match would be bad UX in my view and against the easy access concept of the context menu.

> The other problem seems to be that currently the Hunspell dictionary and
> grammar checker is not filtering out the candidate matches.  We get
> selections from all installed dictionaries/word lists--but the result should
> be limited. 

Yep that seems to be the major issue here of it not removing duplicates.

> Seems it should by default return matches from the dictionary/thesaurus for
> the selected language of the paragraph being entered, or maybe that of the
> document. But not return matches from all installed dictionaries/word lists
> as it seems to be doing now.

Yes it should only bring results based on the selection else the paragraph, as we have the 'Set Language for Selection' and ''Set Language for Paragraph' entries in the context menu, and the red underline only shows up based on these two settings.
Comment 15 QA Administrators 2017-10-23 14:09:38 UTC Comment hidden (obsolete)
Comment 16 andreas_k 2019-04-18 13:05:52 UTC
*** Bug 124436 has been marked as a duplicate of this bug. ***