Bug 93901 - "Edit Paragraph Style" dialog does not save changes after using "apply" button
Summary: "Edit Paragraph Style" dialog does not save changes after using "apply" button
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.4.0 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:5.1.0
Keywords:
: 78959 94029 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-09-03 20:32 UTC by Stefan
Modified: 2021-09-17 18:10 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan 2015-09-03 20:32:29 UTC
- Set cursor to a paragraph
- open the dialog "Edit Paragraph style"
- change font type
- click "Apply"
- change the font type again
- click "Apply" (nothing happens)
- click "OK"
- Open the dialog again -> the last change is lost
Comment 1 Stefan 2015-09-03 20:34:11 UTC
moved to component "Writer"
Comment 2 m_a_riosv 2015-09-03 22:04:01 UTC
Hi @Stefan, thanks for reporting.

I can't reproduce with:
Win10x64
Versión: 4.4.5.2 Id. de compilación: a22f674fd25a3b6f45bdebf25400ed2adff0ff99

Please could you attach a sample file as simple as possible where to reproduce the issue.

Could be that the paragraph has a direct character format? I has preference on the paragraph styel.
Comment 3 Stefan 2015-09-03 22:23:46 UTC
Thank you for check this report. I investigated some more information:

This bug is only active, if my UI-Language is set to "German". So it's an i32n-problem?
Comment 4 m_a_riosv 2015-09-03 23:39:08 UTC
Although I don't know German, I have tested with German UI, and I'm not able to reproduce the issue either.

Please try resetting the user profile, sometimes solves strange issues.
https://wiki.documentfoundation.org/UserProfile
Comment 5 Stefan 2015-09-04 08:15:00 UTC
OK. I defaulted my userprofile with no effect.

Can you please check this (changed a little bit!):

- Set cursor to a paragraph
- open the dialog "Edit Paragraph style"
- change font from (A) to (B)
- click "Apply"
- change the font back to (A)
- click "Apply" (nothing happens)
- click "OK"
- Open the dialog again -> the last change is lost


Maybe, you can now reproduce.
Comment 6 m_a_riosv 2015-09-05 03:20:16 UTC
Thanks @stefan,

I can see it now. seems the issue is trying to use again the font selected when the box is opened. And happen also with Spanish, so not specific for German.

First version that I have installed with the issue:
Win10x64
LibreOffice 3.4.5 OOO340m1 (Build:502)

Maybe when was implemented the Apply option.
Comment 7 Oliver Specht (CIB) 2015-09-08 12:11:50 UTC
Happens with most (if not all) attributes. The controls on the tabpages remember their initial values to prevent sending unchanged items. Those initial values are not updated on 'Apply'. As a result it is not possible to go back to the initial value.
Comment 8 m_a_riosv 2015-09-08 23:07:57 UTC
*** Bug 94029 has been marked as a duplicate of this bug. ***
Comment 9 Ulrich Windl 2015-09-09 06:10:13 UTC
So the important pattern is that after having committed a change with Apply, the setting is ignored for OK if it's the setting with which the dialog had been opened. So I guess the logic of "something changed" is severely broken.
The use pattern is rather common if you want to try some change temporarily (e.g. while hunting for obscure bugs).
Comment 10 Stefan 2015-09-09 19:43:56 UTC
Obscure bugs need no "hunting" in LO :P
Comment 11 Commit Notification 2015-09-11 11:14:50 UTC
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=a212ef2b6ebadb22a9abf6d042aa2b5fd9ac1cf0

tdf#93901: apply handling in style/edit dialog improved

It will be available in 5.1.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 12 Cor Nouws 2015-09-13 07:17:09 UTC
(In reply to Ulrich Windl from comment #9)

> The use pattern is rather common if you want to try some change temporarily

Yes of course, you're right in that.
Thanks @Oliver for the fix!
Comment 13 Justin L 2021-09-17 18:10:18 UTC
*** Bug 78959 has been marked as a duplicate of this bug. ***