Bug 94169 - Open split button recent document list should show icons next to entries
Summary: Open split button recent document list should show icons next to entries
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
4.1.6.2 release
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 92050 (view as bug list)
Depends on:
Blocks: Recent-Document-List
  Show dependency treegraph
 
Reported: 2015-09-12 18:25 UTC by Yousuf Philips (jay) (retired)
Modified: 2017-12-20 05:37 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yousuf Philips (jay) (retired) 2015-09-12 18:25:41 UTC
Similar to the New split button showing icons next to its entries, the Open split button which shows the recent document list with icons next to each entry depending on which app loads it.
Comment 1 Robinson Tryon (qubit) 2015-12-13 11:24:19 UTC Comment hidden (obsolete)
Comment 2 Maxim Monastirsky 2015-12-13 11:59:06 UTC
The problem is that you can't know for sure what app will load each file, before actually trying to open it (some files have wrong extensions (or don't have extension at all), some formats are supported by more than one app - like txt, rtf, html etc.). One possible solution is to store the last used app next to each history item. Then this can be also reused for Bug 65017.
Comment 3 V Stuart Foote 2015-12-13 16:26:14 UTC
(In reply to Maxim Monastirsky from comment #2)
> ... One possible solution is to store the last
> used app next to each history item. 

+1

Picking up the icons as set for the StartCenter (and when no thumbnail is generated bug 74834 or bug 61320) for assignment on the MRU menu list would be good.

But, do see the problem with depending on the "Filter" value as recorded for each document when added to the MRU HistoryInfo PickList ItemList -- as is it does not seem to actually control the LO component that will launch the item.

As in bug 65017, you can open an .RTF  (Rich Text Format) document in Writer or Calc-- and the filter shows as "Rich Text Format" or "Rich Text Format (StarCalc)"
but then on launching from the MRU menu, or the StartCenter thumbnails, LibreOffice does not honor that value and uses some other default.
Comment 4 Maxim Monastirsky 2015-12-13 19:10:21 UTC
(In reply to V Stuart Foote from comment #3)
> But, do see the problem with depending on the "Filter" value as recorded for
> each document when added to the MRU HistoryInfo PickList ItemList -- as is
> it does not seem to actually control the LO component that will launch the
> item.
Yes, we *intentionally* don't honor it for several years now. See this commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=c238c19d2fed00919e02c4bc268d99ceaa73aca1
Comment 5 V Stuart Foote 2015-12-15 17:09:00 UTC
*** Bug 92050 has been marked as a duplicate of this bug. ***
Comment 6 Maxim Monastirsky 2015-12-15 18:42:28 UTC
(In reply to V Stuart Foote from comment #3)
> Picking up the icons as set for the StartCenter (and when no thumbnail is
> generated bug 74834 or bug 61320) for assignment on the MRU menu list would
> be good.
BTW Currently the start center does this by simply matching the extension, see here: http://opengrok.libreoffice.org/xref/core/sfx2/source/control/recentdocsview.cxx#82
Comment 7 Robinson Tryon (qubit) 2016-08-25 04:45:00 UTC Comment hidden (obsolete)
Comment 8 Heiko Tietze 2017-12-19 08:45:34 UTC
While I think it would be good to have an indicator what module opens for the recent documents the overall opinion seems to be WONTFIX.
Comment 9 Yousuf Philips (jay) (retired) 2017-12-19 19:01:55 UTC
(In reply to Heiko Tietze from comment #8)
> While I think it would be good to have an indicator what module opens for
> the recent documents the overall opinion seems to be WONTFIX.

Both Maxim and Stuart agreed with the enhancement and Maxim gave code pointer in comment 6 on how it is implemented in the start center.
Comment 10 Heiko Tietze 2017-12-20 05:37:57 UTC
(In reply to Yousuf Philips (jay) from comment #9)
> (In reply to Heiko Tietze from comment #8)
> > While I think it would be good to have an indicator...
> Both Maxim and Stuart agreed with the enhancement...

So we all agree :-).

Actually I was reading this as an enhancement request for the open recent document toolbar button / menu (.uno:RecentFileList) rather than the start center. Would be my preference at least.