Bug 95852 - Can't edit forms immediately after opening. WORKAROUND: Navigate to next page by clicking on left page list OR right-click
Summary: Can't edit forms immediately after opening. WORKAROUND: Navigate to next page...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
4.5.0.0.alpha0+ Master
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 107206 120389 136862 (view as bug list)
Depends on:
Blocks: Form-Controls
  Show dependency tree / graph
 
Reported: 2015-11-16 11:12 UTC by Valery
Modified: 2023-10-15 18:32 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Valery 2015-11-16 11:12:05 UTC 
In a form with the text box it is impossible to enter some text to it. (The only way I found to do it is to right mouse button click to that text box. Then it gets the focus and becomes editable).

Steps to reproduce:
1. Create new drawing;
2. Switch on Design mode in Form Controls toolbox;
3. Create Text Box;
4. Switch off Design mode in Form Controls toolbox;
5. Try to enter some text to that Text Box.
Comment 1 Buovjaga 2015-11-16 18:22:52 UTC 
Yep, I reproduce. 4.3 is ok.

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+
Build ID: b216cc1b8096eb60c27f67e8c27b7cd756c75e38
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-11-12_00:06:20
Locale: fi-FI (fi_FI)

Version: 4.3.0.1
Build ID: 67f5430184326974072b65403ef1d9d934fc4481
Comment 2 raal 2015-11-18 09:41:10 UTC 
bibisect-win32-5.0, oldest version contains bug too.
git checkout oldest: Version: 4.5.0.0.alpha0+
Build ID: 57d6b92b69a31260dea0d84fcd1fc5866ada7adb
Comment 3 raal 2015-11-19 17:35:20 UTC 
(In reply to Valery from comment #0)
> 5. Try to enter some text to that Text Box.

Right click is the trick :-)
Comment 4 raal 2015-11-19 18:01:25 UTC 
This seems to have begun at the below commit.
Adding Cc: to Marco Cecchetti ; Could you possibly take a look at this one?
Thanks
 4e9a26b54b5533353b8d56e813a02635d7efb21c is the first bad commit
commit 4e9a26b54b5533353b8d56e813a02635d7efb21c
Author: Matthew Francis <mjay.francis@gmail.com>
Date:   Sun Mar 15 05:10:04 2015 +0800

    source-hash-967a386bccb15b99915a1e878e42450fbe9a2d0e
    
    commit 967a386bccb15b99915a1e878e42450fbe9a2d0e
    Author:     Marco Cecchetti <mrcekets@gmail.com>
    AuthorDate: Wed Nov 5 20:15:32 2014 +0100
    Commit:     Marco Cecchetti <mrcekets@gmail.com>
    CommitDate: Wed Nov 5 20:21:43 2014 +0100
    
        Fix for SUSE L3 bug 624546 (freedesktop 83733)
    
        Problem:
        When I'm in outline mode, if I select a slide in the left slide preview
        pane, ctrl-c, then select another slide I would like it after and hit
        ctrl-v; it refuses to cut/paste.
    
        Analysis:
        This issue is due to the fact that the outline view always grabs focus
        when activated and a view is activated whenever is pushed to the
        sfx shell stack even if it is not the new top-most active view shell
        (see `ViewShellManager`, `SfxViewShell`, `SfxDispacther`).
    
        Solution:
        Make the `OutlineViewShell` grabs focus only if it is the top-most
        active view shell.
    
        Rationale:
        When `OutlineViewShell::Activate` is invoked, instead of removing
        the focus grabbing action completely, we check if the
        `OutlineViewShell` instance is the the top-most view shell and
        perform the focus grabbing action only in such a case. This change
        required to have also the `DrawViewShell` grabbing focus on
        activation (only when it is the top-most view shell). In order to
        implement this solution I needed to add a new method (and data
        member) to the `ViewShellManager` class. I named it
        `GetTopViewShell`. This method returns a pointer to the top-most
        active view shell of the internal stack. The returned pointer is
        updated in the `UpdateShellStack` method, before the sfx shell
        stack is updated.
    
        For more details see :
        https://gist.github.com/mcecchetti/15b3ebc505d6582ea0db
    
        Change-Id: I619a406864f50f0e62dee3fcb9ac5d46e3d48272

bibisect-44max$ git bisect log
# bad: [cf6ea17155fabb2a120ba07c150735591ac861d7] source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2
# good: [fc71ac001f16209654d15ef8c1c4018aa55769f5] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
git bisect start 'latest' 'oldest'
# good: [8cf60cc706948588e2f33a6d98b7c55d454e362a] source-hash-f340f0454627939f1830826fb5cc53a90e6c62a4
git bisect good 8cf60cc706948588e2f33a6d98b7c55d454e362a
# good: [8cf60cc706948588e2f33a6d98b7c55d454e362a] source-hash-f340f0454627939f1830826fb5cc53a90e6c62a4
git bisect good 8cf60cc706948588e2f33a6d98b7c55d454e362a
# good: [7beddf3808dadd525d7e55c00a5a90a2b44c23d3] source-hash-2f10386ce577f52e139aa23d41bc787d8e0b4d59
git bisect good 7beddf3808dadd525d7e55c00a5a90a2b44c23d3
# good: [fb3ec529b3f37f0c7eab2e9b7a9cc695c0f27676] source-hash-0516d123f53917d1833c7e8a8c528a619c71a0af
git bisect good fb3ec529b3f37f0c7eab2e9b7a9cc695c0f27676
# bad: [47a64818ddfe63bbb8e6448fcc476f55996d61b1] source-hash-d12efada389643ab0e13a280246d14caed273029
git bisect bad 47a64818ddfe63bbb8e6448fcc476f55996d61b1
# bad: [5ce59f880a90cf8134a9d765c2b94bc4f6f5a865] source-hash-e377a65a1e6acf6241ce0bd2fc35a6a786cd8de9
git bisect bad 5ce59f880a90cf8134a9d765c2b94bc4f6f5a865
# bad: [a568e53084f7d0a47b9e814b938f8deab225f7fc] source-hash-8cdcea2689600ef16829a3f951ddf6fb8e9125a0
git bisect bad a568e53084f7d0a47b9e814b938f8deab225f7fc
# good: [3c987d7227c844df37802b80ccd8fec798dfe360] source-hash-6e4ee0c0f5b0e314ead2e87438e09eae513e5dc3
git bisect good 3c987d7227c844df37802b80ccd8fec798dfe360
# good: [87d7d87521fcc3acbe035d3a5e0a6bd74c96860e] source-hash-5e48dc03fe3dfb173fe65c46d52552149b255032
git bisect good 87d7d87521fcc3acbe035d3a5e0a6bd74c96860e
# bad: [b153d5222738044cd6aa8b249c8371d28d92caca] source-hash-9632045906baf165076d11a97f45b153d8e2acb7
git bisect bad b153d5222738044cd6aa8b249c8371d28d92caca
# good: [313358ad8c5d66d0424f67d133d7170e5a42c0e7] source-hash-ea272d9fe4bf2dc7419f76e2ddee707d768ccd50
git bisect good 313358ad8c5d66d0424f67d133d7170e5a42c0e7
# good: [f96b11ff77327e1f5c94937755fc41b8f4e1db04] source-hash-3943daaa353ca3cd4ae1873249c94ed2856dd99a
git bisect good f96b11ff77327e1f5c94937755fc41b8f4e1db04
# good: [f9d49af44e00db3c5ebef0cdd8f272b22cc9b2d3] source-hash-33b5b467224fef8d99ba3f6f4cba3d404119c100
git bisect good f9d49af44e00db3c5ebef0cdd8f272b22cc9b2d3
# bad: [4e9a26b54b5533353b8d56e813a02635d7efb21c] source-hash-967a386bccb15b99915a1e878e42450fbe9a2d0e
git bisect bad 4e9a26b54b5533353b8d56e813a02635d7efb21c
# good: [65b5cc30bc812d9672a9d9c751af0dec390f165e] source-hash-a9a9718bb1f64318429562ecdaa3d3763d9e2f4a
git bisect good 65b5cc30bc812d9672a9d9c751af0dec390f165e
# first bad commit: [4e9a26b54b5533353b8d56e813a02635d7efb21c] source-hash-967a386bccb15b99915a1e878e42450fbe9a2d0e
Comment 5 Robinson Tryon (qubit) 2015-12-13 11:14:21 UTC Comment hidden (obsolete)
Comment 6 Xisco Faulí 2017-09-29 08:50:21 UTC Comment hidden (obsolete)
Comment 7 Timur 2018-08-09 15:33:14 UTC Comment hidden (obsolete)
Comment 8 Xisco Faulí 2018-10-16 16:02:23 UTC 
*** Bug 120389 has been marked as a duplicate of this bug. ***
Comment 9 Xisco Faulí 2018-10-16 16:03:30 UTC 
*** Bug 107206 has been marked as a duplicate of this bug. ***
Comment 10 QA Administrators 2019-10-17 02:36:34 UTC Comment hidden (obsolete)
Comment 11 Timur 2020-09-24 12:22:25 UTC 
Repro 7.1+
Comment 12 Xisco Faulí 2020-10-12 18:26:07 UTC 
*** Bug 136862 has been marked as a duplicate of this bug. ***
Comment 13 QA Administrators 2022-10-13 03:32:36 UTC Comment hidden (spam)