Bug 95945 - Remove the 'Slide Master' icon from the View menu
Summary: Remove the 'Slide Master' icon from the View menu
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
5.1.0.0.alpha1
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Main-Menu Display-View-Selector
  Show dependency treegraph
 
Reported: 2015-11-20 11:16 UTC by Óvári
Modified: 2022-06-01 03:37 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Óvári 2015-11-20 11:16:28 UTC
Win 8.1
Version: 5.1.0.0.alpha1+ (x64)
Build ID: 186f365a2c541c51e404b1fa819f35c9152adaf1
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-11-19_23:26:12

Is it possible to put the icons in the Display Mode in the View menu next to:
Normal
Outline
Notes
Slide Sorter
Slide Master
Notes Master
Handout Master

Thank you
Comment 1 Buovjaga 2015-11-22 09:50:02 UTC
Let's ask UX.
Comment 2 Heiko Tietze 2015-11-22 10:45:48 UTC
You mean "possible" because of the radio button that are bind to these options. Or are you making a proposal to add an icon there?

I'd disagree with the idea. Radio buttons must not assigned to an icon. Alternatively it could be a toggle button (like bold|italic|underline) but such controls doesn't reflect the actual function, which is switching views/tabs. Furthermore those icon would make sense only if there would be a pendant in the UI.
Comment 3 Óvári 2015-11-22 12:08:20 UTC
Sorry for the misunderstanding Heiko Tietze.

I meant replacing the Radio buttons with the icons used in Display Mode.

The selected mode would have a box around it's corresponding icon.

An example where this is currently implemented:
View menu -> Comments (no box around icon for Comments)
View menu -> Comments (box around icon for Comments)

Version: 5.1.0.0.alpha1+ (x64)
Build ID: 186f365a2c541c51e404b1fa819f35c9152adaf1
TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-11-19_23:26:12
displays an icon next to 'Slide Master'. Icons in the Display Mode tab and the View menu should be the same for consistency.

Thank you
Comment 4 Heiko Tietze 2015-11-23 10:58:38 UTC
The menu item to show comments is used for an on/off feature, and should rather display its state per check mark instead of the "boxed icon" that is actually a toggle button. Those toggle buttons are sometimes good as an alternative to radio buttons that provide a mutual exclusive selection: you can have only one kind of view at a time. However, toggle buttons might look nice but depending on the OS/display theme it can be really hard to identify the state (box/frame) in a glance. So the clear check mark is to prefer from the usability POV.

If you want to learn more about this topic you may want to read our HIG [1] or the more verbose Microsoft guidelines [2] where you should look for "Bullets and checkmarks" as well as the following "Icons" section.

Beside this considerations there are issues with the menu. The slide master state has an icon on Windows, the dependency of features (master) is not reflected in the menu, switching from normal to notes ends up in notes master (but not always), and sometimes I don't get the check mark for normal state.

[1] https://wiki.documentfoundation.org/Design/MenuBar
[2] https://msdn.microsoft.com/en-us/library/windows/desktop/dn742392%28v=vs.85%29.aspx
Comment 5 Óvári 2015-11-23 11:34:39 UTC
Thank you Heiko Tietze for your references in comment 4.

Perhaps the title of this bug should be changed to "Remove Slide Master icon from View menu in accordance with HIG (human interface guidelines)"?
Comment 6 Óvári 2015-11-23 11:42:15 UTC
Perhaps the "Display Mode" in the context of Slide, Notes, Outline etc could be changed to "Layout" as my understanding of display is the physical object (CRT, LED, LCD monitor/projector)?
Comment 7 Óvári 2015-11-23 11:44:13 UTC
Heiko Tietze, I agree with your comment 4:
"So the clear check mark is to prefer from the usability POV (point of view)."
Comment 8 Yousuf Philips (jay) (retired) 2015-12-01 07:09:36 UTC
Yep we dont need icons for the views, but we should remove the 'slide master' icon just from the menu and i'm not sure how it is possible to do it.

@Maxim, @Samuel: Is there of a means of not showing the small icon for an uno command only in the menu, as removing the samll icon file would cause problems for users using small toolbar icons.
Comment 9 QA Administrators 2017-03-06 15:47:03 UTC Comment hidden (obsolete)
Comment 10 Óvári 2017-03-07 01:20:25 UTC
(In reply to QA Administrators from comment #9)
> If the bug is present, please leave a comment that includes:
> a) the version of LibreOffice;
> b) your operating system;
> c) any changes you see in the bug behavior
LibreOffice Version: 5.3.0.3
Build ID: 7074905676c47b82bbcfbea1aeefc84afe1c50e1
CPU Threads: 2; OS Version: Linux 4.4; UI Render: default; VCL: gtk2; Layout Engine: new

Operating system: Linux Mint 18.1 Cinnamon 64-bit

Changed heading based on comment #9
Comment 11 QA Administrators 2018-05-28 02:32:03 UTC Comment hidden (obsolete)
Comment 12 QA Administrators 2020-05-28 03:42:48 UTC Comment hidden (obsolete)
Comment 13 Óvári 2020-05-31 02:14:03 UTC
No icons are showing in version 6.4.4.2. Thank you
Comment 14 Buovjaga 2020-05-31 08:40:05 UTC
(In reply to Óvári from comment #13)
> No icons are showing in version 6.4.4.2. Thank you

I believe this is just because you are using GTK3 and it doesn't display any icons anywhere. The icons are still there with backends that show them.
Comment 15 Óvári 2020-05-31 08:43:45 UTC
(In reply to Buovjaga from comment #14)
> I believe this is just because you are using GTK3 and it doesn't display any
> icons anywhere. The icons are still there with backends that show them.

Thanks for reopening this issue.

We fully transitioned off Windows in 2019. Only have Linux Mint Cinnamon.

Will select (never email me about this bug) as we can't check anymore. Sorry.
Comment 16 QA Administrators 2022-06-01 03:37:22 UTC
Dear Óvári,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug