Hi, I do want to remove the autocorrection of the (c) to the copyright symbol. Therefore I went to Autocorrection settings, replacement table and removed the *.(c) entry from "the list". --> "the list" in this case is from EVERY list, i.e. Deutsch (Deutschland), Deutsch (Belgien), Deutsch (...). So, none of the lists has the entry *.(c) I verified that the language I am actually writing in is set to Deutsch (Deutschland)(Character, paragraph, whole document, does not matter). STILL: every time I type (c) it gets autocorrected to the copyright symbol. Version: 5.0.4.2 Build-ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78 Gebietsschema: de-DE (de_DE.UTF-8) Google suggests that it would have been mattered that the replacement table must match to the actual language used (or set) while typing. Apparently this does not work for me. I'll have to write (c) (and do not mean the copyright symbol) all the time, so currently using Ctrl+z all the time ... :-( Funnily, if I add the copyright symbol to the replacement list and let it be autocorrected to (c), this works, so instead of typing Ctrl+Z I can hit Del and Space and get the autocorrected (c)opyright autocorrected into just (c).
Did you check the (all) autocorrect list? It's on top of the autocorrect language list
Please tell your linux distro and version
HI, yes I tried the [all] list on top of the language list. It was empty, so there was nothing to remove. LInux distribution is Linux Mint 17.2 KDE (i.e. Ubuntu 14.04 base). KDE Systems settings is set to Deutschland, preferred language (and also the only one) is Deutsch. locale yields: :~ > locale LANG=de_DE.UTF-8 LANGUAGE= LC_CTYPE="de_DE.UTF-8" LC_NUMERIC="de_DE.UTF-8" LC_TIME="de_DE.UTF-8" LC_COLLATE="de_DE.UTF-8" LC_MONETARY="de_DE.UTF-8" LC_MESSAGES="de_DE.UTF-8" LC_PAPER="de_DE.UTF-8" LC_NAME="de_DE.UTF-8" LC_ADDRESS="de_DE.UTF-8" LC_TELEPHONE="de_DE.UTF-8" LC_MEASUREMENT="de_DE.UTF-8" LC_IDENTIFICATION="de_DE.UTF-8" LC_ALL= The odd thing is, LO uses the replacement table if I define own autocorrections (as the {copyright symbol} to {(c)} one ...).
did you try removing the *.(c) entry from english autocorrect lists as well? I remember a bug (I cannot recall the exact number right now) where there was an unwanted english i to I autocorrect even in non-english documents
OK I have removed the autocorrection entry for *.(c) or *.(C) from all English dictionaries. --> Problem persists Went on an deleted the corresponding entries in all French dictionaries: --> Problem persists I also checked the "Standard - Deutsch (Deutschland)" which is in the list under the letter 'S' (where *D*eutsch would not right away be expected ;-) in that list I had already removed the *.(c) entry and inserted the reverse autocorrection for testing. I am not sure whether continuing with the Spanish/Italian ones is helpful? Copyright autocorrection seems "hardcoded".
mmmh... did you try resetting the user profile? https://wiki.documentfoundation.org/UserProfile
This is what I did now: Closed LO Went to /home/<username>/.config/libreoffice/4/ Renamed the folder /user to /user_bckp Started LO (fresh /user folder is generated) now with default settings. Verified that Language for the paragraph and character is set to Deutsch. Went to Autocorrection list to remove .*(c) (acknowledge with OK) And ... :drumroll: ... problem persists. Closed LO and switched back to user backup folder.
please go under Tools/Language Setting/Languages and tell your setup about: - user interface - locale - default language for documents
Information found under "Extras"/"Optionen"/"Spracheinstellungen": UI set to: Standard - Deutsch (Deutschland) locale set to: Standard - Deutsch (Deutschland) Default lang. f. documents set to: Standard - Deutsch (Deutschland)
are you sure you don't have any other special character software in your Linux computer that may interfere with LibreOffice? otherwise I have no more ideas... I can't reproduce your bug under Windows 8.1 x64 using LibO 5.0.3.1 and recent 5.2.0.0 alpha another Linux tester is needed to replicate your issue.
Not reproduced. Changed lang of document to German (Germany). (c) was autocorrected. Removed the autocorrection rule for (c) in German (Germany). (c) was not autocorrected anymore. Ubuntu 15.10 64-bit Version: 5.0.3.2 Build ID: 1:5.0.3~rc2-0ubuntu1 Locale: en-US (en_US.UTF-8)
I can reproduce the following: Changed the Languagge of the entire Text to English (GB) (for which I hat removed (c) from the autocorrection list in the earlier attempts): --> (c) is not autocorrected. So switching from Standard Deutsch (Deutschland) for the entire text to English (GB), where (c) has been removed from the autocorrection list let LO behave just as expected. However, changing the Language of the entire text back to German (where in all lists (c) has equally been removed): --> (c) is again autocorrected to the copyright symbol. Beluga: does the autocorrection removal of (c) work in your Default language?
(In reply to Benjamin Quest from comment #12) > Beluga: does the autocorrection removal of (c) work in your Default language? English doesn't seem to have the autocorrection rule.
The problem is that there is an autocorrection for German(Germany) in two versions - in the share directory there is acor_de.dat and in the user directory there is acor_de-DE.dat If a the search in the language/country combination file is not found then the auto correction looks for the pure language version. If you delete this acor_de-DE.dat in your user configuration and call the AutoCorrect options dialog to remove the (c) from the German list then the acor_de.dat file is loaded and a new acor_de-DE.dat is created. There is no acor-en.dat in the share directory. The installation should probably create a acor_de-DE.dat instead of acor_de.dat.
(In reply to Oliver Specht (CIB) from comment #14) > If you delete this acor_de-DE.dat in your user configuration and call the > AutoCorrect options dialog to remove the (c) from the German list then the > acor_de.dat file is loaded and a new acor_de-DE.dat is created. As far as I see this problem, there is no possibility to remove the "(c)" from the general German list. You can only delete entries from lists respective to the different countries. The bug does not only occur with "(c)" but with every entry of the replacement lists. Hence summary changed. Another use case where the deletion fails are wrong entries in the default lists. In bug 103156 there are some examples for German (Switzerland). The replacement table is used for all modules of LibreOffice (Writer, Calc,...), hence component changed to 'Linguistic'. Bug exists already in version 3.3.0. Hence inherited form OOo. Used version: 5.2.2, Win7.
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Bug is still reproducible in LO 5.4.1.2 (Manjaro stable default package). Once Manjaro stable updates to 5.4.2 I'll report again.
*** Bug 119177 has been marked as a duplicate of this bug. ***
The bug is still open in LO 6.1.5.2 also in Windows7 (Feb. 2019) It seems that LO uses always the acor_xx.dat files located in the path: "C:\Program Files\LibreOffice\share\autocorr" (for Windows7) instead of the new acor files which are created in the profile path: "D:\Daten\Users\%username%\AppData\Roaming\LibreOffice\4\user\autocorr" These new autocorr files are created when you apply changes for the first time in the autocorr replacement table, for a specific language. How is it possible that after 3 years a such annoying bug has still not an assignee?
(In reply to Harald Koester from comment #15) > Bug exists already in version 3.3.0. Hence inherited form OOo. Does it? Following the steps of bug 139396 it appears to work with Version: 4.3.7.2 Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba Versie: 4.2.0.4 Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71 and also fine in 4.0 Adding bibisectrequest based on that assumption
On pc Debian x86-64 with master sources updated today, I could reproduce this. I tried with the example of tdf#139377 where Dirk (I put in cc) would like to avoid LO from replacing "daß" by "dass". After deleting the entry, LO still does the replacement even after having restarted LO. If we take the example of German language from Germany, the initial replacement file (ie with a brand new LO profile) is "acor_de.dat" present in "share" directory. Just for information, these dat files are in fact zip files with a specific structure, see: julien@debianamd:/tmp/test$ ls acor_de.dat julien@debianamd:/tmp/test$ mv acor_de.dat acor_de.zip julien@debianamd:/tmp/test$ unzip acor_de.zip Archive: acor_de.zip extracting: mimetype inflating: DocumentList.xml inflating: META-INF/manifest.xml inflating: SentenceExceptList.xml inflating: WordExceptList.xml When deleting an entry in the autocorrect dialog and click Ok, LO generates a "acor_de-DE.dat" in "user" directory this time. This "acor_de-DE.dat" contains all the replacements from "acor_de.dat" except the deleted entry. Important thing to note: "acor_de.dat" in "share" doesn't change and still contains all replacements (included "daß"=>"dass") Remark: the extra "-DE" in the file name is because I used Germany locale. If I switch to Austria locale for example, it will use initial "acor_de.dat" from "share" so it won't use "acor_de-DE.dat" from "user" directory) After some debugging, I noticed that the type of replacement "daß"->"dass" was done in SvxAutoCorrect::SearchWordsInList (see https://opengrok.libreoffice.org/xref/core/editeng/source/misc/svxacorr.cxx?r=40e98c87#1920). 1) it begins in the block: 1932 // First search for eLang, then US-English -> English 1933 // and last in LANGUAGE_UNDETERMINED 1934 if (m_aLangTable.find(aLanguageTag) != m_aLangTable.end() || CreateLanguageFile(aLanguageTag, false)) 1935 { 1936 //the language is available - so bring it on 1937 std::unique_ptr<SvxAutoCorrectLanguageLists> const& pList = m_aLangTable.find(aLanguageTag)->second; 1938 pRet = lcl_SearchWordsInList( pList.get(), rTxt, rStt, nEndPos ); 1939 if( pRet ) 1940 { 1941 rLang = aLanguageTag; 1942 return pRet; 1943 } 1944 } gdb showed that pList.get() used "acor_de-DE.dat" (from "user") and when searching "daß", it doesn't enter if block at line 1939 as expected. 2) But then LO keeps in the next block: 1946 // If it still could not be found here, then keep on searching 1947 LanguageType eLang = aLanguageTag.getLanguageType(); 1948 // the primary language for example EN 1949 aLanguageTag.reset(aLanguageTag.getLanguage()); 1950 LanguageType nTmpKey = aLanguageTag.getLanguageType(false); 1951 if (nTmpKey != eLang && nTmpKey != LANGUAGE_UNDETERMINED && 1952 (m_aLangTable.find(aLanguageTag) != m_aLangTable.end() || 1953 CreateLanguageFile(aLanguageTag, false))) 1954 { 1955 //the language is available - so bring it on 1956 std::unique_ptr<SvxAutoCorrectLanguageLists> const& pList = m_aLangTable.find(aLanguageTag)->second; 1957 pRet = lcl_SearchWordsInList( pList.get(), rTxt, rStt, nEndPos ); 1958 if( pRet ) 1959 { 1960 rLang = aLanguageTag; 1961 return pRet; 1962 } 1963 } and here pList.get() shows "acor_de.dat" from "share". So when searching "daß", it finds the replace (since "acor_de.dat" isn't changed when deleting an entry) I'm gonna propose this straightforward patch: diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx index ae6dceb33adf..0f048114462b 100644 --- a/editeng/source/misc/svxacorr.cxx +++ b/editeng/source/misc/svxacorr.cxx @@ -1941,6 +1941,8 @@ const SvxAutocorrWord* SvxAutoCorrect::SearchWordsInList( rLang = aLanguageTag; return pRet; } + else + return nullptr; } // If it still could not be found here, then keep on searching If a correspond acor file is found in user, it goes into 1) like previously but instead of keeping on with 2), if there's no replacement found, it returns nullptr. I tested this patch with a brand new LO profile (so without "acor_de-DE.dat"), the replacement works since we don't enter the first if of 1) and so we go into 2).
Patch waiting for review here https://gerrit.libreoffice.org/c/core/+/109039 for master branch.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ae56dc05b27f05ffcee99845d661a237e70a7a51 tdf#96787: AutoCorrect: after deleting a replacement entry, it's still used It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/8f2f805b07ddb3450b48e32dc7171625d81d8a84 tdf#96787: AutoCorrect: after deleting a replacement entry, it's still used It will be available in 7.1.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/6046b52ba01dc7dcde4140973c06bec19dadf2a3 tdf#96787: AutoCorrect: after deleting a replacement entry, it's still used It will be available in 7.0.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Adolfo pushed cherry-pick commits for 7.1. and 7.0 branches. Let's put this one to FIXED then.
@Julien, I'm asking before actual trying. Removal does work instantly? So so without a restart LibreOffice before the change is applied? [Asking because auto-complete, did require that (at least in the recent past)]
(In reply to Telesto from comment #27) > @Julien, > I'm asking before actual trying. Removal does work instantly? So so without > a restart LibreOffice before the change is applied? [Asking because > auto-complete, did require that (at least in the recent past)] Yes it worked without restarting LO (unless I missed something).
*** Bug 140981 has been marked as a duplicate of this bug. ***
So glad I noticed right before it was fixed! I missed 5 years of aggravation :-D
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/39dfb6393ac95787e4259b9509a12b686a9a0dae tdf#96787 AutoCorrect: find item with ".*" and between :colons: It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Fixed in master, starting back-porting to 24.8 and 24.2. It seems, (one of the) problems was that the relevant item, here ".*(c)" was hardly noticeable in the many AutoCorrection items. This was fixed by improving the selection in the list box. Note: ".*(c)" means the replacement at the end of the words, too, e.g. typing SomeThing(c) will be replaced by SomeThing©. Full commit description: tdf#96787 AutoCorrect: find item with ".*" and between :colons: It was very hard to disable autocorrection of (c)->© and other AutoCorrect items, because the searched Replace string "(c)" etc. didn't jump the list cursor to the corresponding ".*(c)" item. Now skip ".*" pattern matching marks, also colon (emoji replacement) characters, so the list cursor jumps to the line ".*(c)"->© typing only "(c" etc., allowing users to press Delete to disable its autocorrection without knowing about the special AutoCorrect patterns. Follow-up to commit 50be3fa1f0f3b8870af5bda88b65f835ef37d77e "tdf#141773 AutoCorrect: fix broken [All] dictionaries".
László Németh committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/0c65059eb7c281e34921ce1297dd3f8ffcc4c790 tdf#96787 AutoCorrect: find item with ".*" and between :colons: It will be available in 24.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
László Németh committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/2b995b4b069843aafe2bea353c0138b8a8aca237 tdf#96787 AutoCorrect: find item with ".*" and between :colons: It will be available in 24.8.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.