Bug 103156 - Create locale appropriate AutoCorrect replacement tables for each German language locale (de-AT, de-DE, de-LI, de-CH, de-LU)
Summary: Create locale appropriate AutoCorrect replacement tables for each German lang...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
Version:
(earliest affected)
4.3.2.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyMedium, easyHack, topicDebug
: 113681 139396 (view as bug list)
Depends on:
Blocks: AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2016-10-12 13:31 UTC by Harald Koester
Modified: 2022-02-16 14:21 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
AutoCorrect subvariant for Switzerland (14.67 KB, application/zip)
2017-02-17 12:44 UTC, Harald Koester
Details
AutoCorrect subvariant for Liechtenstein (14.67 KB, application/zip)
2017-02-17 12:46 UTC, Harald Koester
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Koester 2016-10-12 13:31:12 UTC
Description:
In Switzerland and Liechtenstein the spelling of several German words is different to the spelling of German in other countries, where German is spoken. This affects words with the letter 'ß'. In Switzerland and Liechtenstein this letter is not used. Instead they use a double-s ('ss'). 
In the AutoCorrect replacement list for German (Switzerland, Liechtenstein) this difference is not considered. 

Steps to Reproduce:
In order to reproduce the bug:
[1] Open the AutoCorrect options.
[2] Select tab Replace.
[3] Select as language “German (Switzerland)”.
[4] View two examples of the replacement list:
(a) “:Blumenstrauß:” replaced by symbol of Blumenstrauß: Keyboards in Switzerland don't have an 'ß' on their keyboard. Hence users aren't able to type this string and hence a replacement with the respective symbol is not possible. Expected: “:Blumenstrauss:”. In all replacements of this kind the 'ß' should be replaced by 'ss' in the Swiss and Liechtensteiner list.
(b) “Gruss” replaced by “Gruß”: If a user in Switzerland types the corrects string (Gruss) it is replaced by the wrong string (Gruß). Expected: This kind of replacements should be removed from the Swiss and Liechtensteiner list.

Actual Results:  
See Steps to Reproduce.

Expected Results:
See Steps to Reproduce.


Reproducible: Always

User Profile Reset: No

Additional Info:
Bug occurs the first time with version 4.3.2. Versions before don't have explicit lists for Switzerland and Liechtenstein.


User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:49.0) Gecko/20100101 Firefox/49.0
Comment 1 Samuel Mehrbrodt (allotropia) 2016-10-12 13:46:04 UTC
(In reply to Harald Koester from comment #0)
> Description:
> In Switzerland and Liechtenstein the spelling of several German words is
> different to the spelling of German in other countries, where German is
> spoken. This affects words with the letter 'ß'. In Switzerland and
> Liechtenstein this letter is not used. Instead they use a double-s ('ss'). 
> In the AutoCorrect replacement list for German (Switzerland, Liechtenstein)
> this difference is not considered. 

Do you know whether this affects "German - Austria" and "German - Luxembourg" too?
Comment 2 Harald Koester 2016-10-12 23:09:04 UTC
(In reply to Samuel Mehrbrodt (CIB) from comment #1)
> (In reply to Harald Koester from comment #0)
> > Description:
> > In Switzerland and Liechtenstein the spelling of several German words is
> > different to the spelling of German in other countries, where German is
> > spoken. This affects words with the letter 'ß'. In Switzerland and
> > Liechtenstein this letter is not used. Instead they use a double-s ('ss'). 
> > In the AutoCorrect replacement list for German (Switzerland, Liechtenstein)
> > this difference is not considered. 
> 
> Do you know whether this affects "German - Austria" and "German -
> Luxembourg" too?

In Austria, Luxembourg and Belgium the 'ß' is used like in Germany. Hence no changes in the AutoCorrect replacement list for this states are necessary.

Problems may occur with 'foreign' keyboards that don't have an 'ß' and a user likes to edit a correct German text. This is only possible with additional efforts, e. g. via Special Characters or with macros. An AutoCorrect function that replaces an 'ss' by an 'ß' for the respective words would be fine for this case. That may also help German users, because there is an uncertainty about the use of the 'ß' since the orthograpy reform of 1996.
Comment 3 tommy27 2016-12-23 05:37:03 UTC
> ...
> Bug occurs the first time with version 4.3.2. Versions before don't have
> explicit lists for Switzerland and Liechtenstein.
> ...

(In reply to Harald Koester from comment #0)
I think this is due to the fact that since that release, German language subvariants that had no specific autocorrect list inherits the default German autocorrect list you can find in "...\Bin\LibreOffice 5\share\autocorr\"

that file is "acor_de.dat" and is used as the base for all german speaking countries and then applied to all german subvariants (Germany, Switzerland, Liechtenstein, etc. etc.) and stored under "...User\LibreOffice 5\user\autocorr\" in specific subvariant lists such as "acor_de-GE.dat" or "acor_de-CH.dat" etc. etc.

what you can do to fix this bug is to take a default set of autocorrect german words and manually remove all the "double-s ('ss') -> 'ß'" unwanted autocorrections.

then upload here the resulting clean "acor_de-CH.dat" file (and the same for Liechtenstein) and we will ask developers to ship those new specific files in next LibO releases.

as you may see under "...\Bin\LibreOffice 5\share\autocorr\" we already do a similar thing for other languages as well, like english subvariants etc. etc.

thanks for your bug report.
Comment 4 Harald Koester 2017-02-17 12:44:56 UTC
Created attachment 131292 [details]
AutoCorrect subvariant for Switzerland
Comment 5 Harald Koester 2017-02-17 12:46:04 UTC
Created attachment 131293 [details]
AutoCorrect subvariant for Liechtenstein
Comment 6 Harald Koester 2017-02-17 12:47:05 UTC
(In reply to tommy27 from comment #3)

> what you can do to fix this bug is to take a default set of autocorrect
> german words and manually remove all the "double-s ('ss') -> 'ß'" unwanted
> autocorrections.
> 
> then upload here the resulting clean "acor_de-CH.dat" file (and the same for
> Liechtenstein) and we will ask developers to ship those new specific files
> in next LibO releases.

Done.
Comment 7 tommy27 2017-02-18 15:05:35 UTC
thanks Harald, now we need a developer to do a patch with your files.

@sophie
is this something the german localization team can do?
Comment 8 tommy27 2017-04-22 12:20:25 UTC
ping for sophie
Comment 9 sophie 2017-04-24 09:52:01 UTC
Hi, 
@Harald: thanks for reporting and for the files
@tommy: I'll ask to the German team is one of them can commit the patch, and thanks for the ping :) Sophie
Comment 10 tommy27 2017-07-24 04:01:02 UTC
any news Sophie?
Comment 11 Julien Nabet 2017-11-06 19:34:24 UTC
*** Bug 113681 has been marked as a duplicate of this bug. ***
Comment 12 tommy27 2018-09-05 02:25:16 UTC
patch files made available from the reporter but not yet committed by a developer.
please take a look to finally close this ticket.
Comment 13 V Stuart Foote 2021-01-04 22:48:27 UTC
Work on bug 131510 (for 7.0.4 and 7.1.0) only "corrected" daß -> dass in standard German (de-DE) usage.

There are still 69 occurrences of ß (U+00DF LATIN SMALL LETTER SHARP S : Eszett) spellings in the sole German list autocorr/lang/de/DocumentList.xml, as a mix of replacements, and :emoji: notations.

Seems for the 1996 orthography reform, given the differing acceptance there should really be new acor_de-AT.dat (Austria), acor_de-DE.dat (Germany), acor_de-LI.dat (Lichtenstein), acor_de-CH.dat (Swizerland) and even non-signator acor_de-LU.dat (Luxembourg) delineation made for the autocorrect lists to complement what already exists for the locales in i18pool/source/localedata/data/*
Comment 14 V Stuart Foote 2021-01-05 03:53:53 UTC
Adjusting summary. In addition to acor_*.dat attachments for de-LI and de-CH should prepare similar for each German language locale to allow the user locale to correctly populate an appropriate autocorrection table in user profile.
Comment 15 V Stuart Foote 2021-01-05 03:55:05 UTC
*** Bug 139396 has been marked as a duplicate of this bug. ***
Comment 16 Ronny Standtke 2021-01-27 16:47:01 UTC
I maintain a Linux distribution used in many Swiss schools. Our users are complaining that LibreOffice is replacing perfectly fine Swiss German words with German variants (like Harald's example "Gruss" -> "Gruß").

Harald uploaded the corrected locale specific files almost three years ago. Developers don't seem to care. What a shame...

Is there anything we can to to speed things up a bit?
Comment 17 Buovjaga 2021-01-27 18:04:00 UTC
(In reply to Ronny Standtke from comment #16)
> Is there anything we can to to speed things up a bit?

Anyone can make the changes directly inside the Gerrit code review system without having to download the source code and set up a development environment. See
https://gerrit.libreoffice.org/Documentation/user-inline-edit.html
https://wiki.documentfoundation.org/Infra/SingleSignOn
https://gerrit.libreoffice.org/
Comment 18 Samuel Mehrbrodt (allotropia) 2021-02-01 08:52:33 UTC
EasyHack: Add the attached files to the folder extras/source/autocorr/lang/ , next to "de" folder.
Adjust the makefiles in the "extras" module accordingly.
Comment 19 0b100100 2022-02-15 09:32:32 UTC
I'm trying to fix the Autocorrection set for [de-CH] and [de-LI] with the following commit: https://gerrit.libreoffice.org/c/core/+/129929

This does not yet include the proposed change by comment 13 (https://bugs.documentfoundation.org/show_bug.cgi?id=103156#c13) which proposes to adapt every [de] sub-variants to the 1996 orthography reform.
Comment 20 0b100100 2022-02-16 14:21:58 UTC
> This does not yet include the proposed change by comment 13
> (https://bugs.documentfoundation.org/show_bug.cgi?id=103156#c13) which
> proposes to adapt every [de] sub-variants to the 1996 orthography reform.
Of course I meant the adaption of every [de] sub-variant to their different acceptances of the 1996 orthography reform...