Bug 97878 - Failure of Save icon
Summary: Failure of Save icon
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
5.1.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-15 15:28 UTC by robertw
Modified: 2016-03-24 15:13 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description robertw 2016-02-15 15:28:05 UTC
The Save icon in the Standard toolbar of Writer / Calc / Draw does not actually save. I always used this button to save but now I have to use File / Save. If you must mess about with what was a standard Save button, please use another icon for the extra items and not the basic button [eg it shows Save as (which is already a standard icon so why duplicate?) and Save Remote file (whatever that is?) but not the basic Save]. All it seems to do is alter the icon image from one with a cross to the standard one with no saving effect.
Comment 1 V Stuart Foote 2016-02-15 16:47:12 UTC
The Standard Toolbar button is now state aware. If changes have been made to a document if will activate replacement icon with -- in Tango a "green outlined white star", in Breeze "a red dot",  indicating changes to the document have not been saved.

The save button still performs the same uno:Save command that the <Ctrl>+S short cut, or File -> Save menu performs. When no changes have occurred to the document, the button still preforms a save composing ODF and overwriting the existing document. Of if not yet saved as ODF, will open the OS or LO file dialog to name the document.

And finally, the save button now provides a split button action making a Save As command to local Filesystem, and Save remote to save to remote (CMIS, WebDav, SMB, FTP or SSH served).
Comment 2 robertw 2016-02-15 17:32:30 UTC
Sorry but this is not the case. My documents etc (apart from Draw) are all saved in Microsoft format. When I click on the new icon I get no green bar travelling along the bottom showing saving and no new version shown as saved in Windows Explorer file system. I only get a correct Save when going File / Save.
Therefore as far as I am concerned, the Save icon is still not working correctly.
Comment 3 V Stuart Foote 2016-02-15 18:39:16 UTC
Can not confirm. 

On Windows 8.1 Enterprise 64-bit en-US with
Version: 5.1.0.3 (x64)
Build ID: 5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737
CPU Threads: 8; OS Version: Windows 6.29; UI Render: default; 
Locale: en-US (en_US)

Save button detects state and works correctly working with either LibreOffice ODF 1.2 or OOXML.  The OOXML (.docx and .xlsx) are written to file system when the Save button (with alert flag icon as noted) is selected. Time stamp of file updates, and flaged icon reverts to show no pending changes.

Please try with a new profile, and in the dialog shown on first instance of saving to other than ODF format -- uncheck the "Ask wehn not saving in ODF or default format" or from the Tools -> Options -> Load/Save -> General: Default File Format and ODF Settings area: uncheck the "Warn when not saving in ODF or default format".

Also, which Windows OS are your working with?  

Please provide those details and set back to UNCONFIRMED
Comment 4 robertw 2016-02-15 19:27:06 UTC
Ok. I am running Windows 7 and saving as Microsoft 97-2003 {mainly because graphs etc in xlxs caused bugs which I have previously reported and were accepted) i.e I am using plain docs and xls.
I have unchecked the "Ask if not ODF" in the Tools /Options/General and tried saving - still no action.
There were absolutely no problems saving correctly to these same Microsoft files in 5.0.3 / 5.0.4 and previous versions of 4.4 etc so why does it occur now? {unless the coding has been changed to include the "Save as" and "Remote save" functions and something has been missed]
I apologise but I don't understand / not knowledgeable enough to know what you mean by "Try a new profile"
Comment 5 V Stuart Foote 2016-02-15 20:06:12 UTC
So changed from OOXML (docx, xlsx) to MS Office 97-2003 binanry (doc, xls). Still,
no issues with the state aware save button of LO 5.1.0.3 on Windows 8.1 Pro

Details for working with your per-user profile are found in this Wiki:

https://wiki.documentfoundation.org/UserProfile

Alternatively you can create a new use account that will receive a default LibreOffice profile and check if that is having issues.
Comment 6 Maxim Monastirsky 2016-02-15 22:05:49 UTC
Can't reproduce under Fedora 23 (64-bit). Just to make sure we're testing the same thing:

1. Open .doc file and make some change (let's say add a word).
2. Click on the save button, and ensure that it shows the default icon (i.e. without the star) again.
3. Close the document.
4. Open the document again.
5. Does it have the change you did in step 1?
Comment 7 robertw 2016-02-16 11:02:41 UTC
Comment 6.  I did as requested and the change did appear. I have tried spreadsheets as well and they appear to be operating OK.  This is with the orange /white cross on the save icon. It would appear that the fault may be in how my computer is loading LO and that it is not getting it correct each time. [I seem to recall the cross was Green / white before.]  I am based in UK and will try it for rest of today to check it is OK [If it is I'm sorry I bothered both of you but it definitely was not saving correctly when I made my initial contact hence my suspicion now it is loading issue].
Comment 8 robertw 2016-02-16 15:24:42 UTC
I think I have solved the issue, which is not apparent from any notes I have seen. Previously, I would have to just click once on the Save icon and it would save. Now, with this version, just clicking once does not save the file. However, if you double click, it does save as per normal. This appears to be the missing piece of information I was unaware of. Thank you for your help but I think the bug? has been resolved now although this double click action requirement should really be mentioned somewhere where people can find / read it.
Comment 9 Maxim Monastirsky 2016-02-16 20:45:00 UTC
(In reply to robertw from comment #8)
> although this double click
> action requirement should really be mentioned somewhere where people can
> find / read it.
There is no such requirement. It should work with a single click like before (and it does for me).
Comment 10 robertw 2016-02-18 13:02:26 UTC
I am sorry but a single click does not ensure it is saved. Only by double clicking does it save with the green bar scan. A single click just seem to alter the lock file [1Kb] but not the actual file.
Comment 11 tommy27 2016-03-16 06:18:53 UTC
please retest with LibO 5.1.1.3 and tell if issue persists.
give also a look at Bug 97725 and tell if you think it's the same problem.
Comment 12 robertw 2016-03-16 12:05:10 UTC
Haven't loaded LO 5.1.1.3 yet as I don't automatically update for minor changes.  However, I have looked at Bug 97725 and it does look very similar i.e. the Save icon not actually saving. As mentioned previously, I got round this by double-clicking which saved correctly with the green bar etc.

I have also found that when exiting LO using the File/ Exit LO route (when in the Opening / Closing screen) this does not work and I have to use red cross in top RHS to close [This should probably be reported as a separate Bug]
Comment 13 robertw 2016-03-23 19:48:23 UTC
(In reply to tommy27 from comment #11)
> please retest with LibO 5.1.1.3 and tell if issue persists.
> give also a look at Bug 97725 and tell if you think it's the same problem.

Dear Tommy27. Have loaded LO 5.1.1.3 over top of 5.1.0.3 and the problem persists. When I click on the Save [with orange cross]I just get the two alternatives displayed Save As and Save Remote File. No green bar goes along the bottom and it isn't shown as saved in Windows Explorer. I still have to double-click to initiate a proper Save.
Comment 14 V Stuart Foote 2016-03-23 20:09:06 UTC
(In reply to robertw from comment #13)
> ... Have loaded LO 5.1.1.3 over top of 5.1.0.3 and the problem
> persists. When I click on the Save [with orange cross]I just get the two
> alternatives displayed Save As and Save Remote File. No green bar goes along
> the bottom and it isn't shown as saved in Windows Explorer. I still have to
> double-click to initiate a proper Save.

Please be aware that there are two distinct target areas on the button--the floppy disk icon, and the down pointing triangle. The down pointing triangle will always open the split menu exposing the "Save As" and "Save Remote File" button widgets as you describe. 

Clicking the floppy drive icon should always perform the .uno:Save action, but is redrawn with the "orange cross" that visually indicates that the document has changes pending.

The .uno:Save command action on the Save button, is the same as entering <Ctrl>+S on the keyboard. If a new document has not be saved--it will open the Save-as dialog.

Does a <Ctrl>+S keyboard entry show the "progress bar" widget advance across the UI?
Comment 15 robertw 2016-03-23 20:33:37 UTC
(In reply to V Stuart Foote from comment #14)
> (In reply to robertw from comment #13)
> > ... Have loaded LO 5.1.1.3 over top of 5.1.0.3 and the problem
> > persists. When I click on the Save [with orange cross]I just get the two
> > alternatives displayed Save As and Save Remote File. No green bar goes along
> > the bottom and it isn't shown as saved in Windows Explorer. I still have to
> > double-click to initiate a proper Save.
> 
> Please be aware that there are two distinct target areas on the button--the
> floppy disk icon, and the down pointing triangle. The down pointing triangle
> will always open the split menu exposing the "Save As" and "Save Remote
> File" button widgets as you describe. 
> 
> Clicking the floppy drive icon should always perform the .uno:Save action,
> but is redrawn with the "orange cross" that visually indicates that the
> document has changes pending.
> 
> The .uno:Save command action on the Save button, is the same as entering
> <Ctrl>+S on the keyboard. If a new document has not be saved--it will open
> the Save-as dialog.
> 
> Does a <Ctrl>+S keyboard entry show the "progress bar" widget advance across
> the UI?

I am aware [The arrow tip of pointer has been on broad blue band of Save icon]. However clicking once on this still opens the extra two choices. If I single click in the same place the options disappear [but orange cross remains]. If I then single click in the same place again, it sometimes saves and on another occasion won't. The <Ctrl>+S works OK with green bar going across base. The problem remains that single clicking on the Save icon does NOT perform the .uno:Save action as it used to in earlier LO 4. versions.
Comment 16 Maxim Monastirsky 2016-03-23 21:20:42 UTC
(In reply to robertw from comment #13)
> When I click on the Save [with orange cross]I just get the two
> alternatives displayed Save As and Save Remote File.
Oh, I think I understand the problem now. Toolbar buttons that have also a dropdown require a relatively fast click to activate the main part of the button. If I click the main part (i.e. the floppy drive icon), and hold the mouse button down long enough, it will open the dropdown instead of executing the main command. Now doing this could be indeed very tricky for some people, esp. when using some touchpad‏s.
Comment 17 robertw 2016-03-23 23:06:45 UTC
Reply to Comment 16. If the speed of click is indeed the problem and I am using a mouse [not touch screen], may I suggest a possible solution. The solution is to remove the drop down from the Save button and add it to the already existing Save As button [I didn't/don't understand the need for two Save As positions anyway]. This would return the Save button to that in LO4 versions which worked perfectly.
Comment 18 Maxim Monastirsky 2016-03-23 23:35:41 UTC
(In reply to robertw from comment #17)
> The
> solution is to remove the drop down from the Save button and add it to the
> already existing Save As button
This was suggested earlier, but rejected by the design team.

> [I didn't/don't understand the need for two Save As positions anyway].
The separate "Save As" button isn't visible in 5.1 with the default configuration. I guess you customized this toolbar in the past, and now continue to use the same user profile with 5.1.

Anyway, 5.2 will have an optional save button that don't have the dropdown. As for 5.1 - you could try the workaround from Bug 98730 comment 28 (at the cost of losing the indication of whether the document was modified since last save).
Comment 19 robertw 2016-03-24 15:06:23 UTC
Reply to comment 18. Thank you for the update. I look forward to LO 5.2  It would appear that you have identified the problem correctly as due to clicking speed which is not something that crossed my mind. I tried today and it worked OK.
Thank you for your help in solving it. I have not seen this possibility mentioned elsewhere.