Bug 99330 - Left character border formatting is missing with ordered and unordered lists and paragraphs that start with a bookmark
Summary: Left character border formatting is missing with ordered and unordered lists ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.2 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 95943 119053 147846 149517 (view as bug list)
Depends on:
Blocks: Paragraph-Borders
  Show dependency treegraph
 
Reported: 2016-04-15 16:12 UTC by Neo
Modified: 2024-11-05 17:51 UTC (History)
11 users (show)

See Also:
Crash report or crash signature:


Attachments
Incorrect rendering of box style (16.60 KB, image/png)
2016-04-15 16:12 UTC, Neo
Details
Boxed text cutoff example (142.56 KB, application/vnd.oasis.opendocument.text)
2016-05-03 13:16 UTC, Neo
Details
simple document (8.96 KB, application/vnd.oasis.opendocument.text)
2018-09-18 22:15 UTC, Xisco Faulí
Details
Character style example around bullets, with and without a styled ZWS (32.05 KB, image/png)
2024-01-31 16:30 UTC, Peter Gervai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Neo 2016-04-15 16:12:48 UTC
Created attachment 124371 [details]
Incorrect rendering of box style

As you can see on the 4th bullet in the attached screenshot, the box around PERF is cut off on the left side.  A few more bullets down, you can see how it should look.  I created a style that includes the border around the text.

Also, related to another bug report I've written, when a symbol character is inserted into a line, the spacing on that line is compressed or otherwise all messed up.  On that same 4th bullet, you can see the extra space between -->   (6L).  Note:  The single character arrow was created automatically when I typed --> then hit the space bar.
Comment 1 raal 2016-04-17 20:08:51 UTC Comment hidden (obsolete)
Comment 2 Neo 2016-05-03 13:16:40 UTC
Created attachment 124813 [details]
Boxed text cutoff example

In this document you can see the bullet character and space cuts off the boxed text style.
Comment 3 QA Administrators 2016-11-08 12:26:10 UTC Comment hidden (obsolete)
Comment 4 QA Administrators 2016-12-07 12:28:58 UTC Comment hidden (obsolete)
Comment 5 Octavio Alvarez 2018-09-12 15:32:20 UTC
I am seeing this too in:

Version: 6.1.0.2 (x64)
Build ID: b3972dcf1284967612d5ee04fea9d15bcf0cc106
CPU threads: 4; OS: Windows 10.0; UI render: default; 
Locale: en-US (en_US); Calc: group threaded


Steps to reproduce:

1. New Writer document.
2. Type "The following is a list of items:", press Enter.
3. Type "Item 1", press Enter.
4. Type "Item 2", do not press Enter.
5. Select Item 1 and Item 2.
6. Format > Character... > Borders > Presets: Set All Four Borders. OK.
7. Click on the "Toggle Bulleted List" button in the toolbar.

Bad behavior should appear: borders are cut. There is no way to just set the behavior to the text without including the bullet.
Comment 6 Xisco Faulí 2018-09-18 22:15:54 UTC
Created attachment 145002 [details]
simple document
Comment 7 Xisco Faulí 2018-09-18 22:18:57 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=f8b6c3949e2c1f23549a2ef879e728cdb7149235

author	Zolnai Tamás <zolnaitamas2000@gmail.com>	2013-08-21 21:30:41 +0200
committer	Zolnai Tamás <zolnaitamas2000@gmail.com>	2013-08-23 21:01:37 +0200
commit f8b6c3949e2c1f23549a2ef879e728cdb7149235 (patch)
tree 256fc0266b2f32d3cc2c868f26c954c8ecc21a04
parent 9509a46683e40fc2feea6631b701b766797b7882 (diff)
CharBrd 7: Border shadow

Bisected with: bibisect-linux64-6.2

Adding Cc: to Zolnai Tamás
Comment 8 Xisco Faulí 2018-09-18 22:21:56 UTC
*** Bug 95943 has been marked as a duplicate of this bug. ***
Comment 9 Xisco Faulí 2018-09-18 22:22:16 UTC
*** Bug 119053 has been marked as a duplicate of this bug. ***
Comment 10 QA Administrators 2019-09-19 03:14:15 UTC Comment hidden (obsolete)
Comment 11 Kenneth Hanson 2020-04-01 01:26:15 UTC
Bug still present in v6.4.2.2.

Also, it should be noted that this bug applies to numbering as well.
Comment 12 BogdanB 2020-09-28 15:54:49 UTC
Repro in
Version: 7.0.1.2
Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 13 BogdanB 2021-01-27 21:14:35 UTC
Also in
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: f2389a70da606768a39ee599de6a5b24058734aa
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 14 Justin L 2021-05-05 09:00:19 UTC
I'm not sure why version was set to 4.2. I don't even SEE any borders in 
"box style cut off.odt" until bibisect-50max
author	Miklos Vajna on 2015-02-03 19:36:36 +0100
commit f1f6b6db730ae67a427c7974b59a5e19ab571984
xmloff: write character borders in the extension namespace for now

As soon as the borders appeared, the left border wasn't seen in "box style cut off.odt", and there was a gap in the borders for comment 6's "Untitled 1.odt".

I don't see any reason for the bibisect result, or for calling this a regression.
Comment 15 sdc.blanco 2022-06-20 11:13:13 UTC
*** Bug 147846 has been marked as a duplicate of this bug. ***
Comment 16 sdc.blanco 2022-06-20 11:22:06 UTC
Have expanded the summary to cover documented cases from bug 147846 

Tested with:

Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: bbec710bd25fc5da27636cde73fe4ab23c76904f
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win

May also be a problem with TOC / index entries - see bug 149517
Comment 17 Buovjaga 2023-01-27 10:34:05 UTC
*** Bug 149517 has been marked as a duplicate of this bug. ***
Comment 18 Peter Gervai 2024-01-31 15:58:04 UTC
Still present in 
Version: 24.2.0.2 (X86_64) / LibreOffice Community
Build ID: 420(Build:2)
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: hu-HU (en_US.UTF8); UI: en-US
Debian package version: 4:24.2.0~rc2-2
Calc: threaded

But I guess this will not self-heal or fix itself and there seem to be no activity about that, so probably this will be present in all future versions, too. 

(Putting a space before makes the border visible, but that obviously isn't the solution.)
(Well, actually, putting a zero-width space before it, using a different style actually works around the problem without visible deterioration but it's still not a solution.)

My test was simply creating a character style with border and put it into a bullet list.
Comment 19 Peter Gervai 2024-01-31 16:29:28 UTC
Additional information, based on my test of a character style with border:

It seems that the border is invisible when LO thinks that the "space" before the leftmost character is the same style. 

Switching on Character Style Spotlight mode reveals that 
- when the first (leftmost) character is styled with border,
- then the _bullet_ (the parts before the leftmost chartacter) is styled with same style, bordered, and thus the left border is not drawn (since the same style is before the character so the border ought to be somewhere leftwards).

Other bullets are styled borderless (No Character Style) iff the first character (whatever it is, even a zero-width space) is styled borderless (No Character Style).

So I believe this problem is related to the "limbo style" of the "default" lists: the bullets do not seem to have a real style, they are randomly selecting styles based on the first character, and their real visible style comes from elsewhere (the bullet list style I suppose). It is not possible to force the bullet to be a specific character style: when I try it changes then it immediately changes back.
Comment 20 Peter Gervai 2024-01-31 16:30:13 UTC
Created attachment 192296 [details]
Character style example around bullets, with and without a styled ZWS
Comment 21 Justin L 2024-11-05 17:51:11 UTC
repro 25.2+  (testing with comment 6's Untitled.odt saved as DOC and DOCX)

(In reply to Justin L from comment #14)
> I'm not sure why version was set to 4.2.
Comment 7's "Bisected with: bibisect-linux64-6.2" must be wrong. That commit is in the 4.2 time frame.

4.2 is when borders first showed up in DOCX (already missing left border)
with 4.2 commit cfc64c7e895d990023400573d8416ce80cf0da29
Author: Zolnai Tamás on Sun Sep 8 11:23:45 2013 +0200
        CharBrd 9.2: DOCX filters
    
        - Modify HasTextItem() method to able to get
        character attributes during export.
        (in this case RES_CHARTR_SHADOW)
        - Only one side of the border can be exported.
        Selecting order: (top, left, bottom, right)
        - During import set all four side and use the Word
        default shadow type (back, bottom-right, border width wide)


(modern WW9) DOC support also started a little later - I assume with
4.2 commit ad51d4952dc30e0d1cdcc6037556cd7c66a61542
Author: Luke Deller on Wed Mar 5 23:30:39 2014 +1100
    Full colour borders in .doc import/export

Interestingly, at this point the bullets didn't have the left side '[' painted, but numbering did (toggle bullets off and on to verify!!!).

The left side '[' was painted for bullet points starting in 7.2
with commit 0a32371cc2f93fad7954e0fe9c48976aae6c5b9f
Author: Justin Luth on Wed Mar 10 14:41:57 2021 +0200
    tdf#108518 partial revert tdf#64222 sw: better DOCX im/export
    ...of paragraph marker formatting