Steps to reproduce: 1. Open any presentation file in read-only mode. 2. Use page up/down keys to browse the document. Expected results: selected document page changes according to the pressed keys. Actual results: selected document page doesn't change. I think this is not a duplicate of bug #89688. That one refers to any application of the suite, and closing the read-only mode infobar works as a workaround. This one only happens in Impress, and closing the infobar has no effect. Version: 5.1.5.2 Build ID: 5.1.5.2-3.fc24 CPU Threads: 4; OS Version: Linux 4.6; UI Render: default; Locale: en-US (en_US.UTF-8); Calc: group
I've the same experience - more keys do not work
This is a regression that was introduced in two stages: - in 5.0.0.5 the Navigator pane is focused initially, Page Up/Down works once you click in the presentation, - in 5.1.0.3 the Navigator pane is not focused at the start, and clicking into the presentation doesn't help, Page Up/Down does nothing.
First stage, bibisected using repo bibisect-50max. # bad: [dda106fd616b7c0b8dc2370f6f1184501b01a49e] source-hash-0db96caf0fcce09b87621c11b584a6d81cc7df86 # good: [5b9dd620df316345477f0b6e6c9ed8ada7b6c091] source-hash-2851ce5afd0f37764cbbc2c2a9a63c7adc844311 git bisect start 'latest' 'oldest' # good: [0c30a2c797b249d0cd804cb71554946e2276b557] source-hash-45aaec8206182c16025cbcb20651ddbdf558b95d git bisect good 0c30a2c797b249d0cd804cb71554946e2276b557 # bad: [2ce02b2ce56f12b9fcb9efbd380596975a3a5686] source-hash-17d714eef491bda2512ba8012e5b3067ca19a5be git bisect bad 2ce02b2ce56f12b9fcb9efbd380596975a3a5686 # bad: [e4deb8a42948865b7b23d447c1547033cb54535b] source-hash-ce46c98dbeb3364684843daa5b269c74fce2af64 git bisect bad e4deb8a42948865b7b23d447c1547033cb54535b # bad: [15e8b5cc6b4784fecd63b2a5a04ac086b3e9fc01] source-hash-26b500afcaed704db7a300836f466517c309ee77 git bisect bad 15e8b5cc6b4784fecd63b2a5a04ac086b3e9fc01 # bad: [534715525a93b0d7d56ba123d253c927cccf0afe] source-hash-40c9a46b78b8919aae82dd9b94774d63bb9cb4e6 git bisect bad 534715525a93b0d7d56ba123d253c927cccf0afe # good: [c255ade961c9628f72d2fbca268fdf3a4e5f60c2] source-hash-4bdbea5447f36beb9cc33df173a89a49a9918290 git bisect good c255ade961c9628f72d2fbca268fdf3a4e5f60c2 # good: [2b4739cd51404149b1279b86643f1fee719de667] source-hash-8ee20e2691aa6f67c67d40c61a8cd1569458b5a8 git bisect good 2b4739cd51404149b1279b86643f1fee719de667 # good: [9891e7d487540e4650378e546aea5025876d02cf] source-hash-b2f76e0e8a81b456f47b677cd881cc105f781cdb git bisect good 9891e7d487540e4650378e546aea5025876d02cf # skip: [891b689ba95b9e53609194ee2a1a2d3b8955843c] source-hash-01f406bc28f53acc5a2734af637aa8074a5d1813 git bisect skip 891b689ba95b9e53609194ee2a1a2d3b8955843c # good: [4484ce03daa4db83ee9ce6e54396d6f1a0ddcb2a] source-hash-6a3c5af4eb96d03110fcbc856c6920bfcf4063c7 git bisect good 4484ce03daa4db83ee9ce6e54396d6f1a0ddcb2a # bad: [18afb8632caa524fbc70ed5ce3808e23e5dad16f] source-hash-d05a64df34fd143670cb939b72abfb32d6b714c7 git bisect bad 18afb8632caa524fbc70ed5ce3808e23e5dad16f # good: [b02369ea724c86023b074987f04fd60f956c4618] source-hash-4cd7b4ab8aeaf61f5e30e4b63e039b7bb9519e85 git bisect good b02369ea724c86023b074987f04fd60f956c4618 # good: [b52e9a820cbacc502e51aeae755415ea1ac8994a] source-hash-100c518e980f6abdc93c727c524b738200236bf2 git bisect good b52e9a820cbacc502e51aeae755415ea1ac8994a # good: [cfa6015c1d535c8e22bef6a6abb9363c757693d1] source-hash-9e678c14e4fc8e58b1e0530744f648fa3958d338 git bisect good cfa6015c1d535c8e22bef6a6abb9363c757693d1 # only skipped commits left to test # possible first bad commit: [18afb8632caa524fbc70ed5ce3808e23e5dad16f] source-hash-d05a64df34fd143670cb939b72abfb32d6b714c7 # possible first bad commit: [891b689ba95b9e53609194ee2a1a2d3b8955843c] source-hash-01f406bc28f53acc5a2734af637aa8074a5d1813
The change in behavior in LO 5.0 was caused by one of the following two, adjacent timer/scheduler-related commits. The problem with the results is that these commits only contain renamings, like switching to different called functions. The issue is likely in a different commit from Tobias in the area. https://cgit.freedesktop.org/libreoffice/core/commit/?id=01f406bc28f53acc5a2734af637aa8074a5d1813 author Tobias Madl <tobias.madl.dev@gmail.com> 2015-03-06 10:39:49 (GMT) committer Tobias Madl <tobias.madl.dev@gmail.com> 2015-03-06 12:27:12 (GMT) "adapted comments and variable names" https://cgit.freedesktop.org/libreoffice/core/commit/?id=d05a64df34fd143670cb939b72abfb32d6b714c7 author Tobias Madl <tobias.madl.dev@gmail.com> 2015-03-06 13:48:18 (GMT) committer Tobias Madl <tobias.madl.dev@gmail.com> 2015-03-06 13:51:48 (GMT) "Timer/Idle: adapted inherited funktions"
Lets try to bisect the 5.1 regression - it is the most debilitating if we can; I guess that the bisection is not working well for the 5.0 regression - at least I can't see either of those patches causing this (as you say) =) Thanks !
Second stage, bibisected using repo bibisect-win32-5.1. 4439ed5b92e8e8db85b6121c060088afad3e2581 is the first bad commit commit 4439ed5b92e8e8db85b6121c060088afad3e2581 Author: Norbert Thiebaud <nthiebaud@gmail.com> Date: Tue Dec 15 20:18:14 2015 -0800 source 0145083c067effe56cc30c7ea4b2e95b9f600d17 # bad: [05d11632892a322664fb52bac90b2598b7fb7544] source 5616d22b57a9a5e57d545e912e029162a230829b # good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source ab465b90f6c6da5595393a0ba73f33a1e71a2b65 git bisect start '05d11632892a322664fb52bac90b2598b7fb7544' 'oldest' # good: [97526ab777da7e58ce283c05498262ecdd4d6f7f] source 4ea70f87f7a2b61eda6e5ab1f48debf6fcfadc1f git bisect good 97526ab777da7e58ce283c05498262ecdd4d6f7f # good: [86fee7ded76d9c2756ccab6aef160a2d7fab0ab6] source 1b62841b1859ae3443e2bf1ebe99ec3d6afb6cc2 git bisect good 86fee7ded76d9c2756ccab6aef160a2d7fab0ab6 # good: [11864a7db429a57aeea021e0b3f1fb1412282d32] source e5b721a14c1c8e5261a70588b30353cbb5bd55c6 git bisect good 11864a7db429a57aeea021e0b3f1fb1412282d32 # good: [7d52a87c0aa24498584ec522705cfae3a3a5a038] source 479df22d0b4b0e0393fcf621e7380b38415bcef8 git bisect good 7d52a87c0aa24498584ec522705cfae3a3a5a038 # good: [bea538a879f50238f4c9c6f05e3d7390db9d76c7] source 7289a140fc68dc898ba2b2357cc960968195f236 git bisect good bea538a879f50238f4c9c6f05e3d7390db9d76c7 # good: [cec09749b56c5e7f080ebfc289f7ea713baf2a65] source 86a52d6bb9ba75a1a56589bce0cb51a72a46ed19 git bisect good cec09749b56c5e7f080ebfc289f7ea713baf2a65 # good: [a58ef3a2e3e0cf983714816eb663e67d8ea2c39e] source 33b5bcc9e77b27cedfdeee61e11956bec6960cce git bisect good a58ef3a2e3e0cf983714816eb663e67d8ea2c39e # good: [448a0bb90f7ce36c802897ca6d018227c1ffc9a6] source 4b4e78d6bec6e4cf4d9fc5afdf8604f034fc0b82 git bisect good 448a0bb90f7ce36c802897ca6d018227c1ffc9a6 # good: [b4012444c766706faff08d866fabd5dc82304044] source 06456a9951783b5696592ae587fb209cd0411144 git bisect good b4012444c766706faff08d866fabd5dc82304044 # bad: [0e7b50599582239f15d2235e3519f23e497d8825] source a166945a45b33c408a03731e8c0b455e23b85446 git bisect bad 0e7b50599582239f15d2235e3519f23e497d8825 # good: [996da8549808959046896b6a5f7940f8ad6f6e33] source aba8c8e38539a8590048553ee751cdd57fa2c149 git bisect good 996da8549808959046896b6a5f7940f8ad6f6e33 # good: [d0de7c5d3ed853f5198cf73eb8cfc9a38646600d] source 8bbd11758537eff98b5cfc08c55091dec54b4bf6 git bisect good d0de7c5d3ed853f5198cf73eb8cfc9a38646600d # bad: [a8f1c539d329aed46a777668f7b34331956efffb] source 0050019b54a266db92aa71069668ee58e12a7876 git bisect bad a8f1c539d329aed46a777668f7b34331956efffb # bad: [4439ed5b92e8e8db85b6121c060088afad3e2581] source 0145083c067effe56cc30c7ea4b2e95b9f600d17 git bisect bad 4439ed5b92e8e8db85b6121c060088afad3e2581 # first bad commit: [4439ed5b92e8e8db85b6121c060088afad3e2581] source 0145083c067effe56cc30c7ea4b2e95b9f600d17 Original commit (in 5.2, the above is a backported one): https://cgit.freedesktop.org/libreoffice/core/commit/?id=9149dbf17329180e2c9e2fb39243c65acc07a182
Michael, regarding the first stage, is it possible that the scheduler change had an impact on the order how UI components were initialized, which might not have been specified properly, and so the focus ended up in a different component? (or it is caused by a misconfiguration that surfaced here?) The second stage is caused by the backport of the following commit from 5.2. This one is only configuration, so again it seems the issue is elsewhere... https://cgit.freedesktop.org/libreoffice/core/commit/?id=9149dbf17329180e2c9e2fb39243c65acc07a182 author Yousuf Philips <philipz85@hotmail.com> 2015-11-20 05:40:59 (GMT) committer Yousuf Philips <philipz85@hotmail.com> 2015-12-07 15:44:08 (GMT) "tdf#91909 Add shortcuts to slide navigation"
*** Bug 106837 has been marked as a duplicate of this bug. ***
(In reply to Buovjaga from comment #8) > *** Bug 106837 has been marked as a duplicate of this bug. *** Note: "The entire Slide | Navigate menu is grayed-out"
*** Bug 118580 has been marked as a duplicate of this bug. ***
Patch submitted to gerrit: https://gerrit.libreoffice.org/#/c/57077/
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=614804f034a114544dc14047e72ca18a946fbae3 tdf#101930: Allow page up/down and first/last page in read-only mode It will be available in 6.2.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-6-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=c3bc3a59cd44ee4eb75c22084f825ce61ba217b0&h=libreoffice-6-1 tdf#101930: Allow page up/down and first/last page in read-only mode It will be available in 6.1.0.2. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks for fixing this!
Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-6-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1ba1279ed2163305a1a88c520b888ffa49e4dbb9&h=libreoffice-6-0 tdf#101930: Allow page up/down and first/last page in read-only mode It will be available in 6.0.6. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.