Bug 103347 - FILEOPEN: PPTX - Using the slide title as slide name has problems when multiple slides have the same title
Summary: FILEOPEN: PPTX - Using the slide title as slide name has problems when multip...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.1.0.4 release
Hardware: All All
: medium minor
Assignee: Tibor Nagy
URL:
Whiteboard: interoperability target:7.2.0
Keywords: filter:pptx
: 113968 (view as bug list)
Depends on:
Blocks: Slide-Show PPTX
  Show dependency treegraph
 
Reported: 2016-10-20 10:04 UTC by Puma El Busta
Modified: 2021-06-04 11:13 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
pptx file for testing (131.01 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2016-10-20 19:42 UTC, Puma El Busta
Details
Screenshot of the original document side by side in PP and Impress (387.46 KB, image/png)
2021-01-28 13:34 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Puma El Busta 2016-10-20 10:04:02 UTC
Description:
The 'Start slideshow from currend slide' starts slideshow from the first slide, even if I press shift+F5 or try it from the menu.
I am trying to play .pptx slideshows - if I create new slideshow it works properly.

Steps to Reproduce:
1.open .pptx file (probably created with MS PP)
2.navigate to any other slde than the first one
3.press shift+F5 or select option from menu

Actual Results:  
starts slideshow from first slide

Expected Results:
start slideshow from the current slide


Reproducible: Always

User Profile Reset: No

Additional Info:
OS:
3.13.0-98-generic #145-Ubuntu SMP Sat Oct 8 20:13:07 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

packages with 'libreoffice' in name:
ii  libreoffice                           1:5.1.3~rc2-0ubuntu1~trusty1            amd64        office productivity suite (metapackage)                              
ii  libreoffice-avmedia-backend-gstreamer 1:4.2.8-0ubuntu4                        amd64        GStreamer backend for LibreOffice                                    
ii  libreoffice-base                      1:5.1.3~rc2-0ubuntu1~trusty1            amd64        office productivity suite -- database                                
ii  libreoffice-base-core                 1:5.1.3~rc2-0ubuntu1~trusty1            amd64        office productivity suite -- shared library                          
ii  libreoffice-base-drivers              1:5.1.3~rc2-0ubuntu1~trusty1            amd64        Database connectivity drivers for LibreOffice                        
ii  libreoffice-calc                      1:5.1.3~rc2-0ubuntu1~trusty1            amd64        office productivity suite -- spreadsheet                             
ii  libreoffice-common                    1:5.1.3~rc2-0ubuntu1~trusty1            all          office productivity suite -- arch-independent files                  
ii  libreoffice-core                      1:5.1.3~rc2-0ubuntu1~trusty1            amd64        office productivity suite -- arch-dependent files                    
ii  libreoffice-draw                      1:5.1.3~rc2-0ubuntu1~trusty1            amd64        office productivity suite -- drawing                                 
ii  libreoffice-impress                   1:5.1.3~rc2-0ubuntu1~trusty1            amd64        office productivity suite -- presentation                            
ii  libreoffice-java-common               1:5.1.3~rc2-0ubuntu1~trusty1            all          office productivity suite -- arch-independent Java support files     
ii  libreoffice-kde                       1:5.1.3~rc2-0ubuntu1~trusty1            amd64        office productivity suite -- KDE integration                         
ii  libreoffice-math                      1:5.1.3~rc2-0ubuntu1~trusty1            amd64        office productivity suite -- equation editor                         
ii  libreoffice-pdfimport                 1:4.2.8-0ubuntu4                        amd64        PDF Import component for LibreOffice
ii  libreoffice-report-builder-bin        1:4.2.8-0ubuntu4                        amd64        LibreOffice component for building database reports -- libraries
ii  libreoffice-sdbc-firebird             1:4.2.8-0ubuntu4                        amd64        Firebird SDBC driver for LibreOffice
ii  libreoffice-sdbc-hsqldb               1:4.2.8-0ubuntu4                        amd64        HSQLDB SDBC driver for LibreOffice
ii  libreoffice-style-breeze              1:5.1.3~rc2-0ubuntu1~trusty1            all          office productivity suite -- Breeze symbol style
ii  libreoffice-style-galaxy              1:5.1.3~rc2-0ubuntu1~trusty1            all          office productivity suite -- Galaxy (Default) symbol style
ii  libreoffice-style-oxygen              1:5.1.3~rc2-0ubuntu1~trusty1            all          office productivity suite -- Oxygen symbol style
ii  libreoffice-style-tango               1:5.1.3~rc2-0ubuntu1~trusty1            all          office productivity suite -- Tango symbol style
ii  libreoffice-writer                    1:5.1.3~rc2-0ubuntu1~trusty1            amd64        office productivity suite -- word processor



User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
Comment 1 Cor Nouws 2016-10-20 19:31:37 UTC
Hi Puma,

Thanks for reporting.

(In reply to Puma El Busta from comment #0)
> Description:

> I am trying to play .pptx slideshows - if I create new slideshow it works
> properly.

I can't reproduce the issue with a pptx at hand in version 5.1.4.2 (5.1.6.2 will be released soon) and a daily build.

Can you add your test file please?
Ciao - Cor
Comment 2 Puma El Busta 2016-10-20 19:42:44 UTC
Created attachment 128104 [details]
pptx file for testing

This is one of the files producing the error
Comment 3 Cor Nouws 2016-10-20 20:04:05 UTC
thanks - interesting - I can confirm the issue with that file.

Needs checking for dupes and regression
Comment 4 jebsolutions 2016-10-21 22:46:31 UTC
The way libreoffice handles duplicate slide *names* has bugs.  

In attachment 128104 [details] all the slides are named something like "Linearis optimaizalas".  

You can confirm this by right-clicking on any slide in the slide sorter on the left and select "rename slide".

I think under the hood it is really starting the slideshow from the first slide with the same *slide name* as the currently selected slide name.  i.e. it's not saying "start on slide 4" it's saying start on slide "Linearis optimaizalas". Since all the slides have the same name, the first slide that matches that name is always slide #1.  

I notice that newer versions of libreoffice prevent you from renaming a slide to the same name as an existing slide.  It greys out the save button with no explanation to the user as to why you can't choose that name.

Interestingly if I duplicate a slide (e.g. the 6th slide) it will give it a name "Slide 7".  Fine...but if I try to rename one of the "Linearis optimaizalas" slides as "Slide 8" (even though there is no slide with this name) it prevents it as well.  But...if I duplicate the "Side 7" slide...guess what, it creates the new slide name as "Slide 8".  

I am getting deja vu of past crashes.  Often after duplicating a slide, doing basic edits, and then saving.  Maybe a clever dev can check if this mis-handling of duplicate slide names has problems elsewhere in the code.
Comment 5 Julien Nabet 2016-11-07 20:47:04 UTC
(In reply to jebsolutions from comment #4)
> The way libreoffice handles duplicate slide *names* has bugs.  
>...
Please don't "hijack" a bugtracker and open a brand new one.
Indeed, your description is unrelated to this one except the fact it concerns slideshow.
Comment 6 Aron Budea 2016-11-08 04:20:04 UTC
Julien, comment 4 adds some very good observations about this issue, it's not  hijacking at all.

Issue reproduced with as early as 4.1.0.4 / Windows 7 (in earlier versions there's no Start from current slide option).
Comment 7 Julien Nabet 2016-11-08 06:10:59 UTC
You're right Aron. Re reading comment 4, it could explain the pb indeed.
Sorry for my previous comment Jebsolutions.
Comment 8 Yousuf Philips (jay) (retired) 2016-11-09 13:08:28 UTC
So the problem boils down to the import code not making sure that slide titles it is using as the slide names is unique, as pptx dont support slide names. It should either import the slide without slide names, like it does for ppt files, or it should import them like so.

Lineáris optimalizálás
Lineáris optimalizálás (1)
Lineáris optimalizálás (2)
...
Comment 9 Buovjaga 2017-11-22 16:46:23 UTC
*** Bug 113968 has been marked as a duplicate of this bug. ***
Comment 10 QA Administrators 2019-04-03 02:57:04 UTC Comment hidden (obsolete)
Comment 11 Buovjaga 2019-09-29 11:34:08 UTC
Still repro

Version: 6.4.0.0.alpha0+ (x64)
Build ID: e1b51d4588b4b39592bb94dd5bb90de5e04d061e
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@62-TDF, Branch:master, Time: 2019-09-23_09:16:11
Locale: fi-FI (fi_FI); UI-Language: en-US
Calc: threaded
Comment 12 NISZ LibreOffice Team 2021-01-28 13:34:08 UTC
Created attachment 169238 [details]
Screenshot of the original document side by side in PP and Impress

Still a problem in:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 7eb289c49cc7245ef3001a39be0c15d06bbe875b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Every slide has the same title in the Navigator.
Comment 13 Commit Notification 2021-05-04 15:28:42 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cfa672013a1a75ff53993084ae5e69fcd985d010

tdf#103347 PPTX import: fix duplicated slide name

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 NISZ LibreOffice Team 2021-05-07 09:51:39 UTC
Verified in: 

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 9df3aa7ea72d61462e430643f2a80906dce4e15b
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win
Locale: ug-CN (hu_HU); UI: hu-HU
Calc: threaded
Comment 15 Timur 2021-06-03 08:46:48 UTC
This bug was resolved by renaming same name to Slide X and not to Existing Slide Name (1), as suggested in Comment 8.
Luckily, this remains LO problem only, since MSO reads proper titles in LO-saved PPTX.
Comment 16 Timur 2021-06-03 08:52:01 UTC
Note bug 118136 and Comment 5, so I think that fix is improvement, but bug should've stayed open until that solution is made. Or another bug.