Bug 116270 - FILEOPEN: Tables in Word document overlapped (follow-up of bug 94598)
Summary: FILEOPEN: Tables in Word document overlapped (follow-up of bug 94598)
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target: 7.0.0
Keywords: bibisected, bisected
Depends on:
Blocks: DOCX-Tables
  Show dependency treegraph
 
Reported: 2018-03-07 15:02 UTC by Xisco Faulí
Modified: 2020-11-01 11:33 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
How it looks in LibreOffice 6.0.2.1 (144.90 KB, image/png)
2018-03-07 15:02 UTC, Xisco Faulí
Details
How it looks in LibreOffice 5.4 (192.85 KB, image/png)
2018-03-07 15:05 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2018-03-07 15:02:44 UTC
Created attachment 140436 [details]
How it looks in LibreOffice 6.0.2.1

This bug is a follow-up of bug 94598

Steps to reproduce:
1. Open attachment 134965 [details] from bug 94598

Observed behaviour: Some tables are overlapping each other. See attached image

Versió: 6.0.2.1
ID de la construcció: 1:6.0.2~rc1-0ubuntu0.16.04.1~lo1
Fils de CPU: 4; SO: Linux 4.13; Renderitzador de la IU: per defecte; VCL: gtk3; 
Configuració local: ca-ES (ca_ES.UTF-8); Calc: group
Comment 1 Xisco Faulí 2018-03-07 15:05:33 UTC
Created attachment 140437 [details]
How it looks in LibreOffice 5.4
Comment 2 Xisco Faulí 2018-03-07 15:08:14 UTC
Comparing how it looks in 5.4 and 6.0, it got improved by:

author	Mike Kaganski <mike.kaganski@collabora.com>	2018-02-07 01:03:32 +0300
committer	Mike Kaganski <mike.kaganski@collabora.com>	2018-02-07 07:23:57 +0100
commit 76d6fcd05c630a928dd3bd028d560792d9c904ca (patch)
tree 06bf8a8b6b8e48a0511d0f99bd2930baa77aba84
parent 9751a273747a2a6ba80c8b2e6012d788eee7c461 (diff)
tdf#114217: Consider relative width when importing floating table
Unit test included

@Mike, do you have an idea where the table overlapping problem might be?
Comment 3 Dieter 2018-03-07 15:32:55 UTC
I confirm it with

Version: 6.1.0.0.alpha0+ (x64)
Build ID: d64ce643275e0b2b0dea9e532fc261391dc8793c
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2018-03-01_03:24:30
Locale: de-DE (de_DE); Calc: CL
Comment 4 QA Administrators 2019-03-08 03:40:58 UTC Comment hidden (obsolete)
Comment 5 Dieter 2019-03-08 06:56:28 UTC
Still repro in

Version: 6.3.0.0.alpha0+ (x64)
Build ID: 91cdf22b88a4f7bec243c8fb187627e766d3294c
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-03-08_00:38:10
Locale: en-US (de_DE); UI-Language: en-US
Calc: threaded
Comment 6 Justin L 2020-06-03 12:20:19 UTC
fixed in LO 7.0 by commit fd7749fddc5a767461dfced55369af48e5a6d561
Author: Miklos Vajna on Fri Feb 14 16:29:44 2020 +0100
    sw: fix handling of table vs fly overlaps in the AddVerticalFlyOffsets case
    
    When a table overlaps with a fly frame, Writer creates a fly portion
    inside the relevant cell frame (increasing its height), and Word shifts
    the table down. Both are valid approaches, but the rendering result is
    different in case the table has a border.
    
    So keep the default unchanged, but in case the AddVerticalFlyOffsets
    compat flag (set by the Word importers) is set, avoid the overlap the
    Word way.
    
    Note that the table frame uses the full width (available in the body)
    even for e.g. 50% width tables, so check for the overlap using the print
    area, which does not always overlap.
    
    Finally, don't always require a valid frame area definition from the fly
    frame:
    
    - the mentioned i#46807 bugdoc currently doesn't need that check
    
    - the fly frame area definition becomes valid only after already
      positioning the table, leading to an overlap
    
    Keep that check for the non-compat case, though.
Comment 7 Dieter 2020-11-01 11:33:38 UTC
Verified with

Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded