On pc Debian x86-64 with master sources updated today, I could reproduce this.

I noticed that this option was used with vars or const like:
- bGridOnTop
- VOPT_GRID_ONTOP

    318 IMPL_LINK( ScTpContentOptions, GridHdl, ListBox&, rLb, void )
    319 {
    320     sal_Int32   nSelPos = rLb.GetSelectedEntryPos();
    321     bool    bGrid = ( nSelPos <= 1 );
    322     bool    bGridOnTop = ( nSelPos == 1 );
    323 
    324     pColorFT->Enable(bGrid);
    325     pColorLB->Enable(bGrid);
    326     pLocalOptions->SetOption( VOPT_GRID, bGrid );
    327     pLocalOptions->SetOption( VOPT_GRID_ONTOP, bGridOnTop );
    328 }
=> 
Show : value 0, bGrid = true, bGridOnTop = false
Show on colored cells : value 1, bGrid = true, bGridOnTop = true
Hide : value 2, bGrid = false, bGridOnTop = false
See https://opengrok.libreoffice.org/xref/core/sc/source/ui/optdlg/tpview.cxx#318


Again the same mix (grid on color/grid on top):
    498             case SCLAYOUTOPT_GRID_ONCOLOR:
    499                 pValues[nProp] <<= GetOption( VOPT_GRID_ONTOP );
    500                 break;
https://opengrok.libreoffice.org/xref/core/sc/source/core/tool/viewopti.cxx#498

Finally the value is used in sc/source/ui/view/gridwin4.cxx: 
    557     bool bGridFirst = !rOpts.GetOption( VOPT_GRID_ONTOP );
...
    715     if ( bGridFirst && ( bGrid || bPage ) )
    716         aOutputData.DrawGrid(*pContentDev, bGrid, bPage);
    717 
    718     aOutputData.DrawBackground(*pContentDev);
    719 
    720     if ( !bGridFirst && ( bGrid || bPage ) )
    721         aOutputData.DrawGrid(*pContentDev, bGrid, bPage);
See https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/gridwin4.cxx#715

@Heiko, @Julien,
After the wonderful comment 1 made by Julien, should we convert this into an easyHack?

Xisco: after my comment 1, I'd say it's quite confusing to have 2 concepts mixed, perhaps we should ping Eike instead to have his opinion?

Don't think we need input from UX when it smells like a bug.

Eike: I tried to investigate a bit but it seems there's some confusion (see comment 1). Any idea?

(In reply to Heiko Tietze from comment #0)
> Furthermore, this feature is better provided as an extra option. For example
> like this:
> 
> *Visual Aids*
> (o) Show Gridlines
> ( ) Hide Gridlines
>     [ ] But show on colored cells

I think that "Show on colored cells" means "Show *also* on colored cells, when grid is otherwise visible", not "Show *only* on colored cells, when the grid is otherwise invisible". The help claims that too:

Grid lines

Specifies when grid lines will be displayed. Default is to display grid lines only on cells that do not have a background color. You can choose to also display grid lines on cells with background color, or to hide them. For printing, choose Format - Page - Sheet and mark the Grid check box.

(In reply to Maxim Monastirsky from comment #6)
> I think that "Show on colored cells" means "Show *also* on colored cells,
> when grid is otherwise visible", not "Show *only* on colored cells, when the
> grid is otherwise invisible".

We get more flexibility and a clear UI with a separate option, whether it's now specific for or also on colored cells.

Maxim is right, the option "Show on colored cells" means to show grid always, also on colored cells (as the help correctly states), and as such works perfectly fine so this isn't even a bug apart from a misleading wording in the listbox string. A separate option checkbox which effectively would also allow to hide grid lines except on colored cells (i.e. grid lines only on colored cells) IMHO doesn't make sense, thus the states are mutually exclusive and the current listbox is fine.

Thank you Eike and Maxim!

Heiko/Xisco: so perhaps we could change the wording for example from:
"Show on colored cells"
to:
"Show even on colored cells"
?

(In reply to Julien Nabet from comment #9)
> "Show even on colored cells"

It's just a bad idea to spoil the on/off feature with another option. The better solution for the current implementation is "[x] As well for colored backgrounds", disabled when Hide is selected. 

We can close the ticket as WFM, if only a minor change to the caption is accepted; no need to bother l10n.

(In reply to Heiko Tietze from comment #10)
> (In reply to Julien Nabet from comment #9)
> > "Show even on colored cells"
> 
> ...

Ok but in this case, shouldn't it be:
(o) Show Gridlines
    [ ] And show on colored cells
( ) Hide Gridlines

instead of
> (o) Show Gridlines
> ( ) Hide Gridlines
>     [ ] But show on colored cells
?

(In reply to Julien Nabet from comment #11)
> (o) Show Gridlines
>     [ ] And show on colored cells
> ( ) Hide Gridlines

Yes, that's how it is implemented. Someone native might find a better text for the checkbox.

(In reply to Heiko Tietze from comment #10)
> It's just a bad idea to spoil the on/off feature with another option.
There is no on/off feature, there is a listbox with three values, of which one is missing the word "also".

(In reply to Eike Rathke from comment #13)
> (In reply to Heiko Tietze from comment #10)
> > It's just a bad idea to spoil the on/off feature with another option.
> There is no on/off feature, there is a listbox with three values, of which
> one is missing the word "also".

+1 for me so it would give:
"Show also on colored cells"
Heiko/Xisco: ok for you?

(In reply to Julien Nabet from comment #14)
> (In reply to Eike Rathke from comment #13)
> > There is no on/off feature... 
> ...
> Heiko/Xisco: ok for you?

I disagree with Eike here, but feel free to ignore and go ahead.

The simple solution could be

[ ] Show grid lines
    [ ] Also on colored cells
    Color [ <grey> ]

Dear Heiko Tietze,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug