Bug 129701 - Skip empty cells option does not work in Calc Text Import dialog
Summary: Skip empty cells option does not work in Calc Text Import dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: implementationError
: 129699 129752 (view as bug list)
Depends on:
Blocks: Paste
  Show dependency treegraph
 
Reported: 2019-12-30 14:36 UTC by NISZ LibreOffice Team
Modified: 2020-10-13 14:15 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Calc (9.88 KB, application/vnd.oasis.opendocument.spreadsheet)
2019-12-30 14:36 UTC, NISZ LibreOffice Team
Details
The Text Import dialog before pasting (44.44 KB, image/png)
2019-12-30 14:37 UTC, NISZ LibreOffice Team
Details
The file after pasting with A3 not becoming empty (59.54 KB, image/png)
2019-12-30 14:38 UTC, NISZ LibreOffice Team
Details
step to reproduce with an empty cell at the end of a source row (15.55 KB, application/vnd.oasis.opendocument.spreadsheet)
2020-10-13 14:15 UTC, MSessa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2019-12-30 14:36:23 UTC
Description:
When using the Unformatted text paste option in Calc the Skip empty cells option does not seem to make a difference whether its enabled or not

Steps to Reproduce:
1.	Open attachment # from bug # (ide jön az előző bugból a melléklet és a bug száma)
2.	Copy the range B1:B4 and paste it while standing in A1 using the Paste button -> Unformatted text option
3.	The Skip empty cells option in the Text Import dialog is turned on by default. Its tooltip says the sources empty cells should not overwrite the target when enabled.
4.	Try pasting again with Skip empty cells turned off.


Actual Results:
Whether Skip empty cells is enabled or not, the empty cell in B3 does not overwrite the content in A3.

Expected Results:
When Skip empty cells is disabled the content in A3 should be cleared.


Reproducible: Always


User Profile Reset: No



Additional Info:
LibreOffice details:
Verzió: 6.4.0.0.beta1 (x86)
Build az.: 4d7e5b0c40ed843384704eca3ce21981d4e98920
CPU szálak: 4; OS: Windows 6.3 Build 9600; Felületmegjelenítés: alapértelmezett; VCL: win; 
Területi beállítások: hu-HU (hu_HU); Felület nyelve: hu-HU
Calc: CL
Comment 1 NISZ LibreOffice Team 2019-12-30 14:36:58 UTC
Created attachment 156851 [details]
Example file from Calc
Comment 2 NISZ LibreOffice Team 2019-12-30 14:37:47 UTC
Created attachment 156852 [details]
The Text Import dialog before pasting
Comment 3 NISZ LibreOffice Team 2019-12-30 14:38:16 UTC
Created attachment 156853 [details]
The file after pasting with A3 not becoming empty
Comment 4 NISZ LibreOffice Team 2019-12-30 14:38:59 UTC
Bibisected using bibisect-win32-6.1 to: 
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3bd4957191f12457c17404645bab0794639c95f8

author	Laurent BP <laurent.balland-poirier@laposte.net>	2017-12-17 17:14:55 +0100
committer	Eike Rathke <erack@redhat.com>	2017-12-21 23:16:23 +0100

tdf#113979 Add option to Skip empty cells
Comment 5 m.a.riosv 2019-12-31 07:55:23 UTC
*** Bug 129699 has been marked as a duplicate of this bug. ***
Comment 6 m.a.riosv 2019-12-31 07:56:04 UTC
Repro.
Version: 6.5.0.0.alpha0+ (x64)
Build ID: 42a1a1c6b91907f81e15066ffab219411f18c4db
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: GL; VCL: win; 
Locale: es-ES (es_ES); UI-Language: en-US Calc: CL
Comment 7 NISZ LibreOffice Team 2020-01-03 07:46:55 UTC
*** Bug 129752 has been marked as a duplicate of this bug. ***
Comment 8 Laurent BP 2020-01-06 20:11:40 UTC
I do reproduce.
I can also paste with and without skipping in the same time.
1. Copy data:
a;b;c
d;;
g;h;i
2. Paste Unformatted text without option "Skip empty cell" (with semi colon as separator)

Actual behavior:
Cell below "b" is correctly empty (it was erased)
Cell below "c" is skipped and its content is preserved

Expected behavior:
Cells below "b" and "c" should be erased.
Comment 9 Laurent BP 2020-01-06 20:28:06 UTC
The bug seems older, as for versions previous 6.1 there was no option, and behavior was the same as without checking "Skip empty cells".
I reproduce with Version: 6.0.2.1 (x64)
Build ID: f7f06a8f319e4b62f9bc5095aa112a65d2f3ac89
CPU threads: 2; OS: Windows 6.1; UI render: default; 
Locale: fr-FR (fr_FR); Calc: CL
till version 5.3
In Version: 5.2.7.2 (x64)
Build ID: 2b7f1e640c46ceb28adf43ee075a6e8b8439ed10
Threads CPU : 2; Version de l'OS :Windows 6.1; UI Render : par défaut; 
Locale : fr-FR (fr_FR); Calc: CL
the behavior is similar as if "Skip empty" option is on.
Comment 10 MSessa 2020-10-13 10:14:11 UTC
I do reproduce on:
Version: 6.4.6.2 (x64)
Build ID: 0ce51a4fd21bff07a5c061082cc82c5ed232f115
CPU threads: 8; OS: Windows 10.0 Build 17763; UI render: default; VCL: win; 
Locale: it-IT (it_IT); UI-Language: en-US
Calc: threaded

I had a similar issue in production, so I tried to isolate the problem.
In my experience, the paste unformatted text command works properly when the "skip empty cells" is selected.
On the other side, when the "skip empty cells" is NOT selected, the bug arises only when the source range contains an empty value at the END of a row. Such empty value at the end of the source row does not overwrite the corresponding destination cell in CALC.

. Initial CALC destination range (the one to overwrite)
a | B
c | d

. Source comma-separated range
1,
3,4

Actual result of paste special unformatted text w/o "skip empty cells"
1 | b
3 | 4

Expected result:
1 |
3 | 4

I think that the steps to reproduce initially provided by NISZ LibreOffice Team could fit in this new explanation because the empty cell B3 in the source column-range B1:B4 might be considered as an empty cell at the end of the row 3.
Comment 11 MSessa 2020-10-13 14:15:46 UTC
Created attachment 166348 [details]
step to reproduce with an empty cell at the end of a source row

step to reproduce with an empty cell at the end of a source row