Bug 130261 - reset button should work after Apply is used -- before Paragraph and Character Style dialog boxes are closed
Summary: reset button should work after Apply is used -- before Paragraph and Charact...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.3.4.2 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Styles-Dialog Button-Controls
  Show dependency treegraph
 
Reported: 2020-01-29 15:37 UTC by sdc.blanco
Modified: 2020-02-05 13:41 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sdc.blanco 2020-01-29 15:37:33 UTC
1. Styles Window (e.g., F11)
2. Open any paragraph or character style
3. Change a value in any tab, press Apply
4. Press Reset

Actual result:  
   the change is applied.
   reset has no effect

Expected/preferred result:
    change is applied
    reset undoes the changed value

Additional information:

1.  If changes are not applied, then Reset does return the values to when the dialog was opened.

In other words, the dialog box is able to keep information about the "previous state", but "forgets" after Apply.  Should forget after "Ok"

2.  Advantage with change:  with "apply" can see effect directly in document, not just in "preview" window, where "reset" should allow one to come back to "state when dialog box was opened" (which is also what the "help" pages say) -- so maybe this is a "bug" and not an enhancement (as currently filed)

Tested in 6.3.4.2 and 7.0.0.0.alpha
Comment 1 Heiko Tietze 2020-02-05 12:04:07 UTC
According to the help (https://help.libreoffice.org/7.0/en-US/text/shared/01/05020200.html)

Reset
Resets changes made to the current tab to those applicable when this dialog was opened.

Apply
Applies the modified or selected values without closing the dialog.


Point is that Reset works only until Apply has been pressed. This is definitely not expected by the user nor desirable.
I wonder if this ticket is really new- QA experts will find the duplicate. 

For now we could add a note to the help, although Reset/Apply/Standard is likely spread over many pages.
Comment 2 sdc.blanco 2020-02-05 13:41:15 UTC
Additional information.

1.  The request here is just for the "Paragraph Styles" dialog:

https://opengrok.libreoffice.org/xref/core/sw/uiconfig/swriter/ui/templatedialog2.ui 

2. I recognize that modifying the "reset" button can have effects beyond "Paragraph style".

Relevant place to start:  https://opengrok.libreoffice.org/xref/core/sfx2/source/dialog/tabdlg.cxx

3. One patch (for LOK) seems to believe that "Cancel" can be used instead of "Reset" -- but this is true only if "Apply" has not been used.

https://gerrit.libreoffice.org/83630