Bug 131168 - FILEOPEN PPTX: black text on dark background is not outside of pie chart so not readable
Summary: FILEOPEN PPTX: black text on dark background is not outside of pie chart so n...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
4.1 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:pptx, regression
Depends on:
Blocks: OOXML-Chart
  Show dependency treegraph
 
Reported: 2020-03-05 19:37 UTC by Gerald Pfeifer
Modified: 2020-07-17 16:48 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample PPTX document (1.15 MB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2020-03-05 19:37 UTC, Gerald Pfeifer
Details
This is how it looks in Office 365 / PowerPoint (26.23 KB, image/png)
2020-03-05 19:37 UTC, Gerald Pfeifer
Details
This is how it looks in LO (28.93 KB, image/png)
2020-03-05 19:40 UTC, Gerald Pfeifer
Details
How it looks like in LO when switching to bar chart/stacked mode (21.48 KB, image/png)
2020-03-05 19:44 UTC, Gerald Pfeifer
Details
This is how it looks in LO in regular bar chart mode (note the white on white lable missing on the fourth line) (16.59 KB, image/png)
2020-03-05 19:55 UTC, Gerald Pfeifer
Details
The example file in PP and Impress master (77.71 KB, image/png)
2020-06-03 13:21 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2020-03-05 19:37:04 UTC
Created attachment 158424 [details]
Sample PPTX document
Comment 1 Gerald Pfeifer 2020-03-05 19:37:58 UTC
Created attachment 158425 [details]
This is how it looks in Office 365 / PowerPoint
Comment 2 Gerald Pfeifer 2020-03-05 19:40:50 UTC
Created attachment 158426 [details]
This is how it looks in LO

This is how it looks in LibreOffice.  Not readable well or hardly at all:

 - black text and dark background (hardly readable)

 - black text on darker green background (not readable well)
Comment 3 Gerald Pfeifer 2020-03-05 19:44:56 UTC
Created attachment 158427 [details]
How it looks like in LO when switching to bar chart/stacked mode

When switching to bar chart/stacked mode the issue persists, so I assume
there is a general routine handling coloring that can be fixed.
Comment 4 Gerald Pfeifer 2020-03-05 19:55:29 UTC
Created attachment 158428 [details]
This is how it looks in LO in regular bar chart mode (note the white on white lable missing on the fourth line)

Switching to a regular bar chart, the fourth line has its label rendered
white on white -- which is a little invisible. ;-)
Comment 5 Oliver Grimm 2020-03-05 20:37:16 UTC
I confirm that
- the text color of pie segment 1 is black where it should be white and
- the label positions are somewhat different in LO than in Powerpoint.

In my opinion your bug report title is somewhat misleading since the "black text on dark background" results from the wrong positioning of the labels (ON the pie vs. NEXT TO the pie slice).

If you agree please adjust the title of this bug report. I will then confirm it.
Comment 6 Gerald Pfeifer 2020-03-05 23:40:46 UTC
(In reply to Oliver Grimm from comment #5)
> I confirm that
> - the text color of pie segment 1 is black where it should be white and
> - the label positions are somewhat different in LO than in Powerpoint.
> 
> In my opinion your bug report title is somewhat misleading since the "black
> text on dark background" results from the wrong positioning of the labels
> (ON the pie vs. NEXT TO the pie slice).

I am torn on this: from a positioning perspective, isn't LibreOffice
doing a better job re that segment than Office 365?  If the text color
was different (= readable) I would prefer LibreOffice's choice.

In the case of the bar char/stacked (cf. comment #3) positioning cannot
be changed, so the color needs to be fixed.
Comment 7 Timur 2020-03-06 13:14:11 UTC
Visible 2 problems here:
1. "3 vendors 12%" is black text on dark blue background, so hardly readable
2. "4 vendors 6%" doesn't fit nice in pie, so better be out

Here, font color is black in LO, but it's also black in MSO. I don't see that MSO has Automatic color for font, just for label fill. 

So this seems like a problem of label position, not of color. I'll confirm like that.
Position was different in LO 4.0, with some labels out. From 4.1 all is inside.
I wouldn't call this regression, but bibisect would be useful.
Easy to move, so minor issue.
Comment 8 Xisco Faulí 2020-03-06 13:29:54 UTC Comment hidden (obsolete)
Comment 9 Xisco Faulí 2020-03-06 14:32:17 UTC
ouch, I overwrote Timur's comment. Will create a follow-up bug for the colour ticket
The positioning issue started to happen after

author	Kohei Yoshida <kohei.yoshida@gmail.com>	2012-12-07 21:14:50 -0500
committer	Kohei Yoshida <kohei.yoshida@gmail.com>	2012-12-08 00:04:46 -0500
commit e6591c6e940cc694aa68c97e287e59572f690d74 (patch)
tree b9878b199c79907b1c233d0c19adaa16962317ac
parent a6a2feffc024a6af8e44a3a07c9a2f2599bf92bf (diff)
bnc#791952: Use "center" label placement for "Best fit" in pie charts.

Bisected with: bibisect-41max
Comment 10 Gerald Pfeifer 2020-05-04 14:34:51 UTC
(In reply to Xisco Faulí from comment #9)
> ouch, I overwrote Timur's comment. Will create a follow-up bug for the
> colour ticket

Hi Xisco,

would you mind sharing the bug number for that follow-up bug for the
colour issue?  I'd love to have a look and possibly sponsor a fix.
Comment 11 NISZ LibreOffice Team 2020-06-03 13:21:08 UTC
Created attachment 161574 [details]
The example file in PP and Impress master

Label placement looks better since bug #133376 was fixed yesterday. It's not exactly the same since these positions are calculated at runtime.
Comment 12 Timur 2020-07-17 16:39:56 UTC
As noted in Comment 11, PPTX attachment 158424 [details] with chart looks good now in LO so that would be WFM.
Positions are not not exactly the same as in MSO, but never mind, it's not worth a bug and this is also clear and readable.
This bug turned out to be about positions and another one opened for colors.
So let's close this one and keep for colors. 

QA note: I see in some bugs that reporters are advised to split even similar issues like label position and size but I'm not in favor of that, it's too many bugs for no value. 
While to split different issues is  required, for similar interdependent ones I prefer to keep a single bug until something happens, a fix or change.