Bug 132314 - Images anchored As Character become cropped with rotation
Summary: Images anchored As Character become cropped with rotation
Status: RESOLVED DUPLICATE of bug 115463
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.0.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Anchor-and-Text-Wrap Object-Rotation
  Show dependency treegraph
 
Reported: 2020-04-21 22:48 UTC by Ulrich Windl
Modified: 2022-03-02 12:12 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample ODT document showing the final result (160.58 KB, application/vnd.oasis.opendocument.text)
2020-04-21 22:49 UTC, Ulrich Windl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Windl 2020-04-21 22:48:27 UTC
Description:
When rotating a portrait image to landscape, it looks OK until you add a caption.
The caption seems to ignore image rotation, effectively cropping the landscape image to portrait box, making the image a square crop.

Steps to Reproduce:
1. Add an image that is portrait orientation
2. Rotate image 90° (left)
3. Add caption to image

Actual Results:
image is no longer portrait or landscape; its square!

Expected Results:
image should be landscape even when adding a caption.


Reproducible: Always


User Profile Reset: No



Additional Info:
Might be similar to bug 47596 or bug 115463 (both "stalled")
Comment 1 Ulrich Windl 2020-04-21 22:49:27 UTC
Created attachment 159803 [details]
Sample ODT document showing the final result
Comment 2 Dieter 2020-04-26 11:39:50 UTC
I confirm it with

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 962b415edb47187737a5f05c4ff3f6724a19c564
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

It's the same with an image in landscape orientation.

It's a bug, but I'm not sure about the expected behaviour. I couldn't find a way to rotate an image with a caption. So I don't know how this should looks like.

cc: Design-Team for further input
Comment 3 Heiko Tietze 2020-04-27 11:23:18 UTC
Clearly a bug, looks to me like a side-effect from switching from paragraph to character anchoring (the issue also happens without frames). See bug 87720. 

Run the test with 6.3.5 where images are anchored As Character. In master the mentioned patch makes images anchored To Character - and the rotation works for me.
Comment 4 Aron Budea 2020-04-27 14:44:09 UTC
This is a regression since 6.0, and there are a couple of various states that could be bibisected with repo bibisect-linux-64-6.0. I checked with a landscape-oriented image, and:
- after the first commit the image is rotated, but compressed to fit in the original, unrotated dimensions (ie. compressed on one side to fit, but not stretched on the other to fill the space),
- this persists for a while, then there are a couple of commits, after the last of those the rotated image is cut to fit in the original dimensions.
Captioning isn't a necessary repro step.

Removing needsUXEval keyword, as the behavior is the unplanned side-effect of a change.
Adding CC: to Armin Le Grand.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=a42b0985c7619efdc934bb1cf19e5e2c2b6faea2
author		Armin Le Grand <Armin.Le.Grand@cib.de>	2017-09-22 15:28:33 +0200
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2017-10-20 14:13:20 +0200

"RotGrfFlyFrame: Initial adaptions"

https://cgit.freedesktop.org/libreoffice/core/commit/?id=059469926e359153b9b291790ef2df84fa63fda9
author		Armin Le Grand <Armin.Le.Grand@cib.de>	2017-11-16 12:54:21 +0100
committer	Armin Le Grand <Armin.Le.Grand@cib.de>	2017-11-18 13:07:47 +0100

"RotateFlyFrame3: Corrected Contour when rotated"

Other commits with "RotGrfFlyFrame" and "RotateFlyFrame" in the message might be interesting.
Comment 5 Gabor Kelemen (allotropia) 2022-03-02 12:12:09 UTC
This has the same steps + first bibisect result as bug 115463

*** This bug has been marked as a duplicate of bug 115463 ***