Created attachment 159811 [details]
old dialog vs new dialog
See comparison image
This link is very important for QA, specially now, that the hash can't be selected anymore
Please describe the use case. The hash id is in the version info and access to the log file not a user need (which does not mean there is no solution).
(In reply to Heiko Tietze from comment #2)
> Please describe the use case. The hash id is in the version info and access
> to the log file not a user need (which does not mean there is no solution).
Please see bug 103654
Suggest a small, unobtrusive button next to the hash to open the link, ideally hidden for releases.
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":
Resolves tdf#132322 - Link to Gerrit hash reintroduced
It will be available in 7.0.0.
The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Created attachment 160168 [details]
mis-aligned strings in the About dialog on LODev 7.0 Windows builds
With reintroduction of the URL link to Gerrit log for the build, the text strings are not cleanly aligned. It has been left aligned in the past.
Created attachment 160174 [details]
About dialog on Linux/gtk3
Looks good with gtk3; seems Windows ignores the margins.
Anyway, HIG  is clear on where labels should be aligned. And that's left. Will change this.
(In reply to Heiko Tietze from comment #7)
> Created attachment 160174 [details]
> About dialog on Linux/gtk3
> Looks good with gtk3; seems Windows ignores the margins.
> Anyway, HIG  is clear on where labels should be aligned. And that's left.
> Will change this.
>  https://wiki.documentfoundation.org/Design/Guidelines/PropertyDialog
Also problematic with SAL_USE_VCLPLUGIN=gen
Created attachment 160312 [details]
GTK3: spacing around build text
Forget my previous comment, it's fine with gen.
In my case, with gtk3 I see some spacing around the build text
Solved with https://gerrit.libreoffice.org/c/core/+/93444
But now the build id is shown like "Build ID: 7f7912e56791e4ef8aee01e62..." with the trailing ellipsis, instead of the full "7f7912e56791e4ef8aee01e62d47a3b60b92c736", and copied to clipboard accordingly. That would be pasted to bug reports, which is not nice. Please don't truncate the sha! It fits there fine, no need for that truncation.
(In reply to Mike Kaganski from comment #11)
> But now the build id is shown like "Build ID: 7f7912e56791e4ef8aee01e62..."
Addressed in c206fd36389d0d96132c055dcb2afb2d6e02a9b5 - if you copy you get the full length. Thanks for the reminder, planned to do this before.
(In reply to Heiko Tietze from comment #12)
> (In reply to Mike Kaganski from comment #11)
> > But now the build id is shown like "Build ID: 7f7912e56791e4ef8aee01e62..."
> Addressed in c206fd36389d0d96132c055dcb2afb2d6e02a9b5 - if you copy you get
> the full length. Thanks for the reminder, planned to do this before.
Yep, verified in
Build ID: b6ad72a34c150df18905e47e588fd35c400dd6b9
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11;
Locale: en-US (en_US.UTF-8); UI: en-US
as you can see :D