Description: Page layout wrong/different after undo Steps to Reproduce: 1. Open the attached file in multipage view 2. Drag the image on page 4 to page 3 as seen in the screencast 3. Press Undo Actual Results: Layout changes after undo Expected Results: Should be the same. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ (x64) Build ID: 191288d6a7fb52b31038a21c4e71ee57ffa3bacd CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Created attachment 161663 [details] Example file
Created attachment 161665 [details] Screencast
Created attachment 161666 [details] Bibisect log Bisected to author Justin Luth <justin.luth@collabora.com> 2020-03-31 14:49:13 +0300 committer Miklos Vajna <vmiklos@collabora.com> 2020-04-03 10:06:18 +0200 commit f497d1dc27b4fee3db1e2228647a00971922eb5f (patch) tree 7b141274305372600e8e154ecc5926e79af97ed0 parent 0f29d36aa9e6ac7d0914a6e1749c16ecec216904 (diff) tdf#131707 sw layout try2: ConsiderTextWrap on positioning rework 7.0 commit 1052acae9a599c54e518c8fc17d6a994d8778757 jmux and I were working on related bugs at the same time. My patch happened to get committed before his. Since mine regressed, use jmux's version instead. This should fix tdf#119748 and tdf#123257
Adding CC: to Justin Luth -> Note: bug is still unconfirmed.. but there is quite a QA backlog.. so adding you in advance. Hope you don't mind.
Added bug 132415 so see also.. has maybe some similarity. For more even more page flow issues; bug 87740. Added a "few" examples recently; not sure if it's helpful though.
If it is just my call, I'd simply revert and walk away. @jmux: do you want to take it instead?
Well - this is interesting. If you do an redo and undo after the initial do and undo, it's correct again! Then you get a wrong redo-undo, then a correct redo-undo, going in this four state circle. The initial position is always correct, so it's eventually three states, but the initial position somehow retains some different state. While I have the understanding of my initial problem, I don't know what is going on here. But something is missing, so every 2nd undo after the redo actually work correct. I won't have time to fix it currently. I don't know what is worse, the current state or the previous one. Probably QA should decide?
(In reply to Jan-Marek Glogowski from comment #7) > I won't have time to fix it currently. I don't know what is worse, the > current state or the previous one. Probably QA should decide? Deciding this something like this is deciding between rock and hard place... it fixes obvious problems.. However I personally hate it if undo does something 'unexpected' However there is no rush.. So lets float it for a while.. and lets see what happens.. And evaluate after 7.0.2
(In reply to Jan-Marek Glogowski from comment #7) > I don't know what is worse, the current state or the previous one. A regression is always worse than a missing fix. Plus, the chances are pretty good that there will be more regressions, since the impacts/fixes from this are all over the place. revert proposedl here: https://gerrit.libreoffice.org/c/core/+/95651
(In reply to Justin L from comment #9) > revert proposedl here: https://gerrit.libreoffice.org/c/core/+/95651 Please leave it in for a while.. until more regressions show up as proof of being really broken. This one alone should be manageable.. There is nobody "who understands layout and its implications" in advance. Or 'implications of any change).. Everybody is being haunted by past changes :-) There already so many hours spend on this. And the Jmux wouldn't be out of the loop either; with bug 123257. Which also called a regression The whole project is based make a change and solve the issues afterwards as far as possible.. I don't want my name on a known bad commit -> Do understand that... however revert is always option later on; we need more 'proof'. This bug was more intended as 'heads up'. Not scaring you off.. And it's "me" asking this.. The one who keeps seeing/ reporting regressions..
Bug 132415 is wrong wrap (layout) in multipage view. Maybe this is all wrong and undo is just a consequence. *** This bug has been marked as a duplicate of bug 132415 ***
Related to bug 132415 comment 8 Don't revert. Didn't encounter anything broken; and I show have seen something by know; I think. So should be (nearly) risk free
Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
Still an issue in Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: cfc8a8f5d841b3f84d207196153be67da7f60652 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (hu_HU.UTF-8); UI: en-US Calc: threaded
removing "regression" because it was requested to be kept. Plus, it is not really my patch anyway.