Steps to reproduce: 1. Open attachment 160406 [details] from bug 132744 2. Select all 3. Copy 4. Paste 5. Undo Reproduced in Version: 7.1.0.0.alpha0+ Build ID: ff508f6d8a3e58d29e9e7622006a7103fb0a2849 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=fa39e7970496537258eaad1f5351db2d675225b6 author Miklos Vajna <vmiklos@collabora.co.uk> 2015-01-03 11:40:41 +0100 committer Miklos Vajna <vmiklos@collabora.co.uk> 2015-01-03 13:09:26 +0100 commit fa39e7970496537258eaad1f5351db2d675225b6 (patch) tree 1b90dadaed9d6941a5921e961c2a627d9eb02bfe parent b33cd811cb5456a146916ee374aaf1ce11b2031e (diff) fdo#72486 SwWrtShell::SelAll: if in table, then call extended select all ... Bisected with: bibisect-50max Adding Cc: to Miklos Vajna
Can't reproduce this on Windows Version: 7.1.0.0.alpha0+ (x64) Build ID: a201ab6f47c2d5a7ba4c5f998b0aa231cae82010 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
(In reply to Telesto from comment #2) > Can't reproduce this on Windows > Version: 7.1.0.0.alpha0+ (x64) > Build ID: a201ab6f47c2d5a7ba4c5f998b0aa231cae82010 > CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win > Locale: nl-NL (nl_NL); UI: en-US > Calc: CL Sure, your build needs to include https://git.libreoffice.org/core/+/cc4b5091e739116a7ec83513fa1cd856f0130330%5E%21
Created attachment 161928 [details] bt with debug symbols (gtk3) On pc Debian x86-64 with master sources updated today, I got an assertion at second step (copy). It may be related...
Ok, repro with Version: 7.1.0.0.alpha0+ (x86) Build ID: 26483950760f0aac7bc45e93db4127f66a98fdc6 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL So an old bug reappeared
Crashed when following exactly Xisco steps. https://crashreport.libreoffice.org/stats/crash_details/2b3f8403-dc63-4809-a131-91a05402a1ee https://crashreport.libreoffice.org/stats/crash_details/a910478c-cd5e-4161-960d-3f7cc26285ec Cannot reproduce in: Version: 7.0.0.0.beta1 (x64) Build ID: 94f789cbb33335b4a511c319542c7bdc31ff3b3c CPU threads: 4; OS: Windows 10.0 Build 17763; UI render: Skia/Raster; VCL: win Locale: fr-CH (fr_FR); UI: en-GB Calc: threaded
Ah, this points to the above commit because previously the whole doc was selected (and with this commit, only the table is selected), so SwDoc::InsCopyOfTable() is not called. If you press enter after opening the document (so there is an empty paragraph before the table) and then you do the same steps, this crashes even before the above commit. Xisco: could you please check if the empty-paragraph version was always broken or possible to bisect that as well? Thanks.
Created attachment 170528 [details] Document with an empty paragraph at start to uncover the hidden root cause
Steps to reproduce: 1. Open attachment attachment 170528 [details] 2. Press the "down" arrow to enter the table 3. Select all 4. Copy 5. Paste 6. Undo Crashes with linux-43all.git 'oldest' already, so it looks like this is not a regression after all. (AOO crashes as well.) Xisco: any objections to adjust keywords accordingly?
I change to Inherited from OO. No bibisect possible.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e782937228479054336b564a4c34697a12530469 Related: tdf#133933 sw: fix assertion failure in the SwIndexReg dtor It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/982f8408286bc0519c2d9d73fb4e59142e03f00a Related: tdf#133933 sw: show SwUndoTableCpyTable in doc model xml dump It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/140192fd5a2fc5e9d250d077d00bcebc014f7cbf tdf#133933 sw: fix crash on undo of redlined pasted table It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
It may make sense to file a follow-up non-crash bug for the remaining problem (that is also interhited from OOo, as far as I see), that the reproducer steps no longer crash, but result in unexpected images.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/b18bffb5b4948bbdaece90a68a4c9341ad9df084 Related: tdf#133933 sw: fix assertion failure in the SwIndexReg dtor It will be available in 7.1.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/ac1056f9d9a922660b84f20ea86e5aabbe0e8716 tdf#133933 sw: fix crash on undo of redlined pasted table It will be available in 7.1.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.