Bug 134883 - pie chart area gets wrong size, if "best fit" puts label outside the sector
Summary: pie chart area gets wrong size, if "best fit" puts label outside the sector
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Chart (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Balázs Varga
URL:
Whiteboard: target:7.1.0
Keywords:
Depends on:
Blocks: OOXML-Chart Pie-and-Donut
  Show dependency treegraph
 
Reported: 2020-07-16 19:49 UTC by Regina Henschel
Modified: 2024-10-15 21:29 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Pie chart with label outside and marker for position in Excel and screenshot from Excel (43.17 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2020-07-16 19:49 UTC, Regina Henschel
Details
Screenshot of the example document in current Calc master and Excel (161.49 KB, image/png)
2020-07-17 10:53 UTC, NISZ LibreOffice Team
Details
Recent fix (53.58 KB, image/png)
2020-08-27 10:15 UTC, László Németh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2020-07-16 19:49:11 UTC
Created attachment 163136 [details]
Pie chart with label outside and marker for position in Excel and screenshot from Excel

Open attached document. The file is essentially the file tdf133376.xlsx from the unit test chart2import.cxx. I have added a screenshot from Excel 365 and put a rectangle around the third label and circle around the pie chart area.

Notice, that the pie chart area has become smaller and therefore the place of the label is wrong.

@NISZ LibreOffice Team: Balazs Varga has improved a lot for chart import. But the unit test testTdf133376 fails for me with a current clean build. I get: Expected 1071 Actual 1139 delta 30. Might it be, that because of the too small pie chart area, the label is not at the expected position? I see a similar problem in unit test tdf134225.
Comment 1 NISZ LibreOffice Team 2020-07-17 10:53:35 UTC
Created attachment 163170 [details]
Screenshot of the example document in current Calc master and Excel

Version: 7.1.0.0.alpha0+ (x64)
Build ID: a3e52f63c92876b4a3ac6df61e05b1d3510ba9c9
CPU szálak: 4; OS: Windows 6.3 Build 9600; Felületmegjelenítés: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL
Comment 2 NISZ LibreOffice Team 2020-07-17 10:56:00 UTC
Confirming in current master. In earlier versions the whole example was differently bad, but the pie diameter was closer to the original in:

Verzió: 6.4.0.3 (x86)
Build az.: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8
CPU szálak: 4; OS: Windows 6.3 Build 9600; Felületmegjelenítés: alapértelmezett; VCL: win; 
Területi beállítások: en-US (hu_HU); Felület nyelve: hu-HU
Calc: CL
Comment 3 Gabor Kelemen (allotropia) 2020-07-19 20:51:25 UTC
Started to look like attachment #163170 [details] after:

https://git.libreoffice.org/core/+/73477348e30c6931a537cba5557c250183fbeb9b

tdf#133376 Chart view: improve BestFit position of data labels

But even before that the radius happened to be visibly smaller than originally.

It was however slightly larger than originally in:
Version: 6.1.0.0.beta1+
Build ID: 5b20226bb0e431afa4505373aaa0af2d28479528
CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk3; 
Locale: hu-HU (hu_HU.UTF-8); Calc: group threaded

This changed to the previous 6.4 state at:
https://git.libreoffice.org/core/+/42d27ed5c07f829dab1d5b663fc14cf1b61061b4

author	Tamás Zolnai <tamas.zolnai@collabora.com>	Tue May 28 17:32:44 2019 +0200
committer	Andras Timar <andras.timar@collabora.com>	Fri May 31 07:33:15 2019 +0200

tdf#122765: Legend interferes with pie chart after pptx import, second part
Comment 4 Commit Notification 2020-08-27 10:10:32 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/75a8b367f2a06e0d485fc2b9f4472e8bb29d71e3

tdf#136105 tdf#134883 pie chart: improve data label position

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 László Németh 2020-08-27 10:15:45 UTC
Created attachment 164739 [details]
Recent fix
Comment 6 NISZ LibreOffice Team 2020-09-14 09:55:24 UTC
Verified in:

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 34a09c9c61bff30e8c4d16132bb47b2b1b16e422
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded