Bug 138203 - [Draw] [Impress][UI]: Menu items with identical (or very similar) labels but different actions
Summary: [Draw] [Impress][UI]: Menu items with identical (or very similar) labels but ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
5.1 all versions
Hardware: All All
: medium normal
Assignee: Ayhan Yalçınsoy
URL:
Whiteboard: target:7.2.0 target:7.1.0.0.beta2
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
: 134739 (view as bug list)
Depends on:
Blocks: Main-Menu
  Show dependency treegraph
 
Reported: 2020-11-13 22:45 UTC by Ming Hua
Modified: 2020-11-25 10:04 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of Impress's and Draw's Format menu (32.66 KB, image/png)
2020-11-18 15:54 UTC, Ming Hua
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Hua 2020-11-13 22:45:20 UTC
While working on bug 138172 I noticed that both Draw's and Impress's Format menu have a pair (but different pair) of submenu items with the same text.

For Impress, we have:
Format > Align corresponding to uno:TextAlign in GenericCommands
Format > Align corresponding to uno:ObjectAlign in GenericCommands
For Draw, we have:
Format > Text corresponding to uno:FormatTextMenu in GenericCommands
Format > Text... corresponding to uno:TextAttributes in DrawImpressCommands

This is less than ideal.  Can we change their labels to diffrentiate them better?  Are these labels used in other places than the main menus?  I understand that different modules already share the same label in their main menus, e.g. the Format > Align for uno:TextAlign mentioned above appear in all of Writer, Calc, Impress, and Draw (but Draw doesn't have Format > Align for uno:ObjectAlign, and therefore doesn't have the same problem as Impress does -- it puts that command in Shape > Align instead), but don't know if they are used in context menus, or sidebars, etc.

This happens in both 6.4.7 and master (daily build of Nov. 12th).
Comment 1 Heiko Tietze 2020-11-16 10:06:51 UTC
.uno:TextAlign and .uno:ObjectAlign are used all over the menus. We could rename it to "Align Text" and "Align Objects". This would also affect Writer (Format > Align), for example.
Comment 2 Heiko Tietze 2020-11-16 10:28:33 UTC
See also https://gerrit.libreoffice.org/c/core/+/16020/
Comment 3 Cor Nouws 2020-11-18 15:25:10 UTC
(In reply to Ming Hua from comment #0)
> For Impress, we have:
screenshot pls maybe :) ?
thnkx!
Comment 4 Ming Hua 2020-11-18 15:54:14 UTC
Created attachment 167388 [details]
Screenshot of Impress's and Draw's Format menu

(In reply to Cor Nouws from comment #3)
> screenshot pls maybe :) ?
Sure, attached.
Comment 5 Cor Nouws 2020-11-18 16:14:48 UTC
(In reply to Ming Hua from comment #4)
> Sure, attached.
Thanks Ming Hua. Now I understand it. (Hence I change the summary ;) )

I support the idea to improve that. Only when Icons are set in menu's, you see some difference.
Comment 6 Heiko Tietze 2020-11-19 13:29:49 UTC
Yes, let's do. Clearly an easyhack.
Comment 7 Mihkel Tõnnov 2020-11-19 13:46:40 UTC
The two Align submenus were also discussed at bug 134739. As this report has a wider scope ("Align" & "Text"/"Text..."), I'll mark the other bug as a duplicate.
Comment 8 Mihkel Tõnnov 2020-11-19 13:46:58 UTC
*** Bug 134739 has been marked as a duplicate of this bug. ***
Comment 9 Commit Notification 2020-11-23 11:51:07 UTC
Ayhan Yalçınsoy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2198e91676f186d86754fd1b511530b73cbe4a83

tdf#138203: fixed identical menu at Draw and Impress

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Buovjaga 2020-11-23 11:53:53 UTC
Ayhan: can you check, how this affects the existing Help files? If you don't have Help locally, you can search with https://opengrok.libreoffice.org/ and use Gerrit web editing to create patches https://gerrit.libreoffice.org/Documentation/user-inline-edit.html
Comment 11 Ayhan Yalçınsoy 2020-11-24 06:08:06 UTC
(In reply to Buovjaga from comment #10)
> Ayhan: can you check, how this affects the existing Help files? 
Of course.
Comment 12 Commit Notification 2020-11-24 09:23:36 UTC
Ayhan Yalçınsoy committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/f561b255abd8a5b9a19c60246ef8c9d3c20dea20

tdf#138203: fixed identical menu at Draw and Impress

It will be available in 7.1.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2020-11-25 08:12:40 UTC
Ayhan Yalçınsoy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/cc9d63e60d848b0560778b4de098581923bbc6a2

tdf#138203: fixed identical menu on help pages
Comment 14 Commit Notification 2020-11-25 10:04:56 UTC
Ayhan Yalçınsoy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/7b4dc63ec204f64a80f181ba1ff005a78791f60c

tdf#138203: removed '...' characters from the menu etnires on help page