Version: 7.2.0.0.alpha0+ (x64) Build ID: 315c7570c4a72f4c834086082825533b1e50d1bf CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Attempting to <Ctrl>+V paste text into a dialog object is crashing. Observed pasting into an Insert -> Comment object. Also, crash pasting into an edit from the 'Expert configuration' dialog, e.g. setting the 'ooName' stanza.
Created attachment 168343 [details] WinDbg stack trace paste into an Insert -> Comment
Created attachment 168344 [details] WinDbg stack trace paste into Expert Configuration edit of ooName
I would suspect.. https://gerrit.libreoffice.org/c/core/+/107675 https://gerrit.libreoffice.org/c/core/+/107168
Didn't try yet, but see the comments in https://gerrit.libreoffice.org/c/core/+/107675. Major problem is the fact, that these patches are also in 7.1. I don't have time to implement the correct solution to handle clipboard in the main thread. I still don't like the original idea of https://bugs.documentfoundation.org/show_bug.cgi?id=139074, but we need something for 7.1 and if that flies, so be it. Maybe the better solution can be backported later...
Created attachment 168426 [details] WinDbg ST crash on paste into Expert Configuration edit of ooName Continued crash on Windows with paste from clipboard for 2020-12-22 TB77 build. Version: 7.2.0.0.alpha0+ (x64) Build ID: 4041c68ea59181f1c4774c356809066d2051db41 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded
Bug 139146 might be related.. stack has some similarity's (and cut/paste)
*** Bug 139156 has been marked as a duplicate of this bug. ***
*** Bug 139146 has been marked as a duplicate of this bug. ***
re STR of bug 139156, like Writer and Impress, paste onto Draw canvas works. But if content of the new draw textbox is emptied a paste from clipboard into that object crashes.
*** Bug 139186 has been marked as a duplicate of this bug. ***
https://gerrit.libreoffice.org/c/core/+/107894 pushed issue into 7.1.0.1 rc1
QA engineer and bumping priority so it makes it to the mailing-list.. as this will cause a number of reports, I assume
Paste inside a comment box in Writer will also cause a crash
*** Bug 139244 has been marked as a duplicate of this bug. ***
*** Bug 139284 has been marked as a duplicate of this bug. ***
*** Bug 139287 has been marked as a duplicate of this bug. ***
*** Bug 139282 has been marked as a duplicate of this bug. ***
Created attachment 168539 [details] a bit better ST of 7.1.0.1 for crash in Writer with paste into a Text Box object
Created attachment 168562 [details] a bit better (x64) ST of 7.1.0.1 for crash pasting to ooName stanza of ExpertConfig
*** Bug 139327 has been marked as a duplicate of this bug. ***
*** Bug 139349 has been marked as a duplicate of this bug. ***
Considering: - the number of dups (so not a corner a case) - it's a regression - it's a crash => let's put this one to max priority. ok it doesn't concern all envs but Windows is the mainstream OS for desktop (I don't want to start a troll, I personally use Debian)
I do confirm this issue was introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=f5ab8bcbfd20ecce4a358f62ee3f81b8b968a5de author Jan-Marek Glogowski <glogow@fbihome.de> 2020-12-14 10:47:04 +0100 committer Jan-Marek Glogowski <glogow@fbihome.de> 2020-12-16 18:02:15 +0100 commit f5ab8bcbfd20ecce4a358f62ee3f81b8b968a5de (patch) tree 78eeb346b2bd8a875becb3dcde7e766400e49fce parent e4c21a3c1fa8acd0078029d7a42f304ff2b40773 (diff) WIN don't notify clipboard change with SolarMutex Bisected with: win64-7.2
*** Bug 139406 has been marked as a duplicate of this bug. ***
Hopefully the crashes should be fixed after https://cgit.freedesktop.org/libreoffice/core/commit/?id=c921f9bd64187823af2356d7a8ceb77444c17219
*** Bug 139445 has been marked as a duplicate of this bug. ***
*** Bug 139456 has been marked as a duplicate of this bug. ***
*** Bug 139366 has been marked as a duplicate of this bug. ***
(In reply to Xisco Faulí from comment #26) > Hopefully the crashes should be fixed after > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=c921f9bd64187823af2356d7a8ceb77444c17219 I do confirm the issue is fixed in Version: 7.2.0.0.alpha0+ (x64) Build ID: 0f7008e91f45cf8e3cee6f372ce012b38a795e26 CPU threads: 16; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-US Calc: threaded @Mike Kaganski, thanks for fixing this issue.
*** Bug 139477 has been marked as a duplicate of this bug. ***
A new daily build containing the fix is available at https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/current/ Please, doublecheck the crashes are gone with this build. If you find a crash, please, report it in a new ticket. Thanks
(In reply to Xisco Faulí from comment #33) > Please, doublecheck the crashes are gone with this build. Verified reliable paste that no longer crash with today's TB77 build Version: 7.2.0.0.alpha0+ (x64) Build ID: 57a59ad02d2e5e89724c0d2e60cf6e7d99fba005 CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL This is resolved, but be aware the work to improve Windows clipboard handling remains, paste issues could reappear. =-ref-= https://gerrit.libreoffice.org/c/core/+/107669 Backport to 7.1 https://gerrit.libreoffice.org/c/core/+/108860
OK. Thank you for the fix.
*** Bug 139275 has been marked as a duplicate of this bug. ***
*** Bug 139563 has been marked as a duplicate of this bug. ***
*** Bug 139581 has been marked as a duplicate of this bug. ***
*** Bug 139582 has been marked as a duplicate of this bug. ***
Stephan Bergmann committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/f9c3a734221228cdf5a52ed6ebf9c0a3c1d44607 tdf#139074: Revert "WIN replace clipboard update thread with Idle" et al It will be available in 7.1.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Just a process question because I'm ignorant, does fixing something in 7.1.0.2 mean that it will also show up approximately at the same time in a daily build for 7.2.0.0 alpha?
(In reply to mwtjunkmail from comment #42) > Just a process question because I'm ignorant, does fixing something in > 7.1.0.2 mean that it will also show up approximately at the same time in a > daily build for 7.2.0.0 alpha? No, it is already in the daily build. While the 7.1.0.2 incremental release will be finalized as scheduled, which could have been weeks/months away. However, the rc2 build is scheduled for this week [1], so in this case it is soon. =-ref-= [1] https://wiki.documentfoundation.org/ReleasePlan/7.1#7.1.0_release
(In reply to Commit Notification from comment #41) > Stephan Bergmann committed a patch related to this issue. > It has been pushed to "libreoffice-7-1": > > https://git.libreoffice.org/core/commit/ > f9c3a734221228cdf5a52ed6ebf9c0a3c1d44607 > > tdf#139074: Revert "WIN replace clipboard update thread with Idle" et al > > It will be available in 7.1.0.2. > > The patch should be included in the daily builds available at > https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More > information about daily builds can be found at: > https://wiki.documentfoundation.org/Testing_Daily_Builds > > Affected users are encouraged to test the fix and report feedback. Works for me in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 1a167625314bf36b735176ed488e6ba9b5e9b675 CPU threads: 8; OS: Windows 10.0 Build 21292; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL
*** Bug 139821 has been marked as a duplicate of this bug. ***
(In reply to mwtjunkmail from comment #44) > (In reply to Commit Notification from comment #41) > > Stephan Bergmann committed a patch related to this issue. > > It has been pushed to "libreoffice-7-1": > > > > https://git.libreoffice.org/core/commit/ > > f9c3a734221228cdf5a52ed6ebf9c0a3c1d44607 > > > > tdf#139074: Revert "WIN replace clipboard update thread with Idle" et al > > > > It will be available in 7.1.0.2. > > > > The patch should be included in the daily builds available at > > https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More > > information about daily builds can be found at: > > https://wiki.documentfoundation.org/Testing_Daily_Builds > > > > Affected users are encouraged to test the fix and report feedback. > > Works for me in > Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community > Build ID: 1a167625314bf36b735176ed488e6ba9b5e9b675 > CPU threads: 8; OS: Windows 10.0 Build 21292; UI render: Skia/Raster; VCL: > win > Locale: en-US (en_US); UI: en-US > Calc: CL I have updated from 7.1.0.2 to 7.1.0.2 and can report that this bug is now FIXED in this version! Thanks so much
I have updated from 7.1.0.2 to 7.1.0.2 and can report that this bug is now FIXED in this version! Thanks so much
*** Bug 139586 has been marked as a duplicate of this bug. ***