Bug 139429 - To be presentable the Style previews on the 'Tabbed' NB need padding and some additional width, with tooltip for overwide style names
Summary: To be presentable the Style previews on the 'Tabbed' NB need padding and some...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.1 rc
Hardware: All All
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: Notebookbar-Tabbed
  Show dependency treegraph
 
Reported: 2021-01-05 16:18 UTC by Arnab
Modified: 2021-12-21 07:46 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Tabbed NB Home tab Style selections 7.1.0.1 (31.71 KB, image/png)
2021-01-05 17:41 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arnab 2021-01-05 16:18:33 UTC
Description:
In the new Libreoffice 7.1 prerelease, the styles preview in Libreoffice writer (tabbed view) is not looking like the previous one. If this is a new style then please bring back the previous one or make it look a little bit nice with padding.
      
       Also there is no padding in most of the boxes. Keeping text in the middle of the box without the text touching the boundary will make it look really good.

I have a windows 64bit machine and 1080p 15.6 inch monitor (141.21 dpi)

Steps to Reproduce:
1.Open Libreoffice writer
2.Change the UI to tabbed view
3.Look at the styles preview

Actual Results:
The "default paragraph" is not fully shown 
The other 'heading' styles are not fully visible
and it looks bad (causes headache if not disabled)

Expected Results:
These things should have been either shown using small icons like before or maybe make the size of these "text boxes" should have been smaller.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I am not insulting or critisizing you but we just know that the tabbed UI experience could be better. You are already doing pretty good job. "Thumbs up" for you.
Comment 1 Arnab 2021-01-05 16:34:32 UTC
Version: 7.1.0.1 (x64)
Build ID: b585d7d90ab863bf29b2d110c174c0c2a98f3ee4
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-IN (en_IN); UI: en-US
Calc: threaded



Version: 7.1.0.1 (x64)
Build ID: b585d7d90ab863bf29b2d110c174c0c2a98f3ee4
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-IN (en_IN); UI: en-US
Calc: threaded




Version: 7.1.0.1 (x64)
Build ID: b585d7d90ab863bf29b2d110c174c0c2a98f3ee4
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-IN (en_IN); UI: en-US
Calc: threaded



Version: 7.1.0.1 (x64)
Build ID: b585d7d90ab863bf29b2d110c174c0c2a98f3ee4
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-IN (en_IN); UI: en-US
Calc: threaded
Comment 2 V Stuart Foote 2021-01-05 17:41:51 UTC
Created attachment 168708 [details]
Tabbed NB Home tab Style selections 7.1.0.1

Confirmed.
Version: 7.1.0.1 (x64)
Build ID: b585d7d90ab863bf29b2d110c174c0c2a98f3ee4
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded


I don't have an issue with this "full scale" style preview (from standard template) rendering on the Home tab of  Tabbed NB.

The x width could be made just a bit wider to eliminate the truncation of 'Default paragraph' and 'Heading 1'; but no need for y height change.

As opposed to icon selections, this provides more helpful information
Comment 3 Heiko Tietze 2021-01-13 14:23:48 UTC
I believe "Bring back the..." is not working. WYSIWYG is a big advantage and maybe the developers can solve the minor issues you have.

* label not fully shown: How about a tooltip?
* looks bad: add some pixel margins?

Anything else?
Comment 4 andreas_k 2021-01-13 14:29:42 UTC
(In reply to Heiko Tietze from comment #3)
> 
> Anything else?

right click for edit whould be nice.
Comment 5 Heiko Tietze 2021-01-13 15:04:00 UTC
(In reply to andreas_k from comment #4)
> right click for edit would be nice.

Let's not make this a wish list aka META ticket. Point is that we either resolve as WF (we do not want to bring back the plain dropdown) or change summary and request to one issue. But preferably we close the ticket and file new.
Comment 6 andreas_k 2021-01-13 15:06:43 UTC
I can change width of the preview so that Heading 1 with default template is visible. 

Together with a tooltip (and right click behaviour) the previews are better than the drop down menu (which is available at the sidebar)
Comment 7 V Stuart Foote 2021-01-13 15:15:28 UTC Comment hidden (me-too)
Comment 8 Heiko Tietze 2021-01-18 12:09:05 UTC Comment hidden (off-topic)
Comment 9 Roman Kuznetsov 2021-02-07 20:01:41 UTC
https://gerrit.libreoffice.org/c/core/+/110408
Comment 10 Commit Notification 2021-02-11 17:51:43 UTC
Szymon Kłos committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fd9b52502de6044a2249ff81407ac579a35ad3a1

tdf#139429 Convert Style previews widget to IconView

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.