The focused cell has a black rectangle that nicely shows the active cell with the default color theme taking the value from Tools > Options > LibreOffice > Application Colors: Font Color (under General). But for dark themes, eg LibreOffice Dark from bug 141986, it still is black- while the Automatic color is transposed into white. See https://bug-attachments.documentfoundation.org/attachment.cgi?id=171685 or switch Document Background to black. IMO, the best color for the cell in focus is the same as we use on the row/col headings taken from the OS/DE. needsUXEval for this idea.
*** Bug 142327 has been marked as a duplicate of this bug. ***
Created attachment 172082 [details] dark frame
Yes, yes! Back in the day, Mirek Mazel created a mockup where the OS highlight color was used for the selected cell frame (see https://wiki.documentfoundation.org/images/3/34/Calc-headers.png).
*** Bug 142959 has been marked as a duplicate of this bug. ***
Using the highlight color now for the col/row header, the actual selection, and - new in this patch - also the focused cell rectangle. Decided against an option since later the system highlight color might become part of the configuration itself and all places with a selection take the respective color.
Use the functional patch at https://gerrit.libreoffice.org/c/core/+/121491 as prototype.
Created attachment 175273 [details] A screen of the result of my uploaded patch I have attached a screenshot of how it now works after uploading the patch.
Gerrit link https://gerrit.libreoffice.org/c/core/+/122602
Natalia Gavrilova committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b1c318e9f18f6a4e56d42fc7b7c5c2942b28941d tdf#142121 Cell focus rectangle does not use font color It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Heiko Tietze from comment #6) > Use the functional patch at https://gerrit.libreoffice.org/c/core/+/121491 > as prototype. The issue in this report is solved. However, to make the selection more outstanding in zoomed view I added a few lines of code to adjust the line size according the zoom level. Looks good in my opinion but might have consequences ion performance (unlikely, though) and is unrelated to this issue. So if someone is interested in this enhancement, the prototype shows how to do.
I love how this enhancement looks. Thank you, Natalia!
Glad to hear!
After this patch I see a blue line around selected cell with BLACK square in its bottom right corner (I use a standard theme in LO) Natalia, could you please fix it?
Hi, can you please attach an image and describe the condition you are getting this issue at?
Created attachment 175376 [details] Screenshot with the problem
(In reply to Roman Kuznetsov from comment #16) > Created attachment 175376 [details] > Screenshot with the problem It's just LibreOffice in Windows 7
Do I understand correctly that expected behavior is to get this rectangle to be also highlight color instead of black (I suppose it’s font color)?
(In reply to Natalia from comment #18) > Do I understand correctly that expected behavior is to get this rectangle to > be also highlight color instead of black (I suppose it’s font color)? Yes. Do you need a code pointer?
Hi, if you have that, that would probably be the easiest.
Sorry for the delay. The grip is drawn in ScGridWindow::UpdateAutoFillOverlay() with currently Color aHandleColor = svtools::FONTCOLOR.
New patch https://gerrit.libreoffice.org/c/core/+/123300
Created attachment 175607 [details] Screen with the fix for the black square The black square in the down right corner is also highlight color now
Natalia Gavrilova committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c307c34a295fbbaf0af91a17440b045133981cc8 tdf#142121 Cell focus rectangle does not use font color It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified - thanks, as this is a really nice small UI improvement that makes UI feel more consistent and at home on the various OSs. Is it intended behavior to draw the bold focus rectangle only around the first top left cell when multiple cells are selected (see verified 2021-10-11 screenshot)? This feels wrong and Apple Numbers indeed puts the bolder line around *all* selected cells (see attachment Apple Numbers). Thoughts? Should be file a separate follow up bug or do we think current behavior is expected and fine?
Created attachment 175655 [details] verified 2021-10-11
Created attachment 175656 [details] Apple Numbers
(In reply to steve from comment #25) > Is it intended behavior to draw the bold focus rectangle only around the > first top left cell when multiple cells are selected... Yes, Apple Numbers don't let you spot the currently active cell (bold frame).
About "currently active cell" there is the bug#144593.
(In reply to al.le from comment #29) > About "currently active cell" there is the bug#144593. Moving the focus when selecting columns does not have anything to do with this report, removing from See Also. I agree with Heiko that it is Apple Numbers that should change its behaviour.
Thanks for the input, so current behavior would be expected. File a followup bug about contrast being too low for cell selection highlight color: https://bugs.documentfoundation.org/show_bug.cgi?id=145080
Thanks for this UI improvement. I added an entry in the release notes to highlight this new behavior.
*** Bug 145744 has been marked as a duplicate of this bug. ***
Reviewing 7.3 release notes. Verified in: Version: 7.3.0.1 / LibreOffice Community Build ID: 840fe2f57ae5ad80d62bfa6e25550cb10ddabd1d CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded
I've read the description of this feature on https://wiki.documentfoundation.org/ReleaseNotes/7.3 and I find the feature not good. The cursor can barely be seen IMO. The contrast is too low.
@al.le@gmx.de: Think everybody agrees about contrast being too low and visibility bad. This feature does not feel finished. There are two follow up bugs about that: - https://bugs.documentfoundation.org/show_bug.cgi?id=145080 - https://bugs.documentfoundation.org/show_bug.cgi?id=143733
OK, I just hope the feature in its current form won't make it into the official release 7.3.
*** Bug 98176 has been marked as a duplicate of this bug. ***
Created attachment 178561 [details] Calc 7.2 current cell
Created attachment 178562 [details] Calc 7.3 current cell
(In reply to fml2 from comment #37) > OK, I just hope the feature in its current form won't make it into the > official release 7.3. It seems like the change made it as is. It may work well with a dark theme, but IMO this behavioural change has drawbacks, namely that now it's *really hard* to see what cell is selectd with some highlight colors. In my case - even though I don't have accessibility problems - the hichighted cell is almost invisible in a big enough window. See attachments - one for 7.2 and one for 7.3 *Please* at least put this behind a setting. As it is, I have to revert to use 7.2 because ther I can see which cell is selected.
I don't follow the bug, but based on users' comments, commit should be reverted from 7.3. There were similar situations before and rule for visible changes should be: do not commit until all is done.
(In reply to Timur from comment #42) > I don't follow the bug, but based on users' comments, commit should be > reverted from 7.3. > There were similar situations before and rule for visible changes should be: > do not commit until all is done. What needs to be done is to look into using ifdef on macOS < 10.14, so this feature is not active. For macOS >= 10.14, the feature can use "accent color", which is discussed in bug 145080.
Natalia, * whoever develops on macOS: could you please consider bug 142121 comment 22, and implement retrieving the *available* accent color from system where it's available? 1. Implement a new GetSettings().GetStyleSettings().GetAccentColor(), that would for now default to GetSettings().GetStyleSettings().GetHighlightColor() on all systems except macOS; 2. On macOS, implement it using the weakly linked guarded call to controlAccentColor; 3. Use it where Natalia made the changes (so all the code pointers make it an easy hack). No target version bump is required for that.
It looks like the active cell border is nearly invisible. The line color is the same as the cell borders in the light theme. See attachment. In the dark theme it is clearly visible as a white border on a black background. Is there any current bug that I can track about this?
Created attachment 180437 [details] invisible active cell
(In reply to Robert from comment #45) > Is there any current bug that I can track about this? Maybe Bug 145080 ?
*** Bug 144108 has been marked as a duplicate of this bug. ***
*** Bug 87289 has been marked as a duplicate of this bug. ***
Created attachment 188293 [details] example ODS with various cell backround colours I'm calling this issue inherited as, even though OOo 3.3 had a different active cell border colour, it would still be invisible if the cell background was using the same #5c5c5c colour. (Note it was still possible to see which was the active cell thanks to the inverted-colour grid that we don't have anymore.) Just in case, the attachment can be useful to test different black and grey cell backgrounds, and includes the active cell frame colours from OOo 3.3 and pre-7.3.