Bug 142235 - FILESAVE PPTX Textbox vertical top align becomes middle in PP
Summary: FILESAVE PPTX Textbox vertical top align becomes middle in PP
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: high major
Assignee: Attila Bakos (NISZ)
URL:
Whiteboard: target:7.3.0 target:7.2.0.0.beta2
Keywords: bibisected, bisected, filter:pptx, regression
Depends on:
Blocks: PPTX-Textbox
  Show dependency treegraph
 
Reported: 2021-05-12 12:20 UTC by NISZ LibreOffice Team
Modified: 2021-08-10 07:19 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Impress (15.48 KB, application/vnd.oasis.opendocument.presentation)
2021-05-12 12:20 UTC, NISZ LibreOffice Team
Details
The original file saved by Impress (31.50 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2021-05-12 12:21 UTC, NISZ LibreOffice Team
Details
Screenshot of the original and exported document side by side in PowerPoint and Impress (95.35 KB, image/png)
2021-05-12 12:22 UTC, NISZ LibreOffice Team
Details
How it looks in 7.2 master today (212.20 KB, image/jpeg)
2021-06-01 11:51 UTC, Attila Bakos (NISZ)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2021-05-12 12:20:36 UTC
Created attachment 171916 [details]
Example file from Impress

Attached example file demonstrates possible text alignment positions in ODP format.
When saved to PPTX and reloaded these seem to be retained (except for horizontally right which does not seem to be supported anyways), but in PowerPoint the same file opens with vertically top aligned textboxes being vertically center aligned.

Steps to reproduce:
    1. Open attached file in Impress
    2. Save it as PPTX
    3. Open that file in PP

Actual results:
Second to fourth slides have their text vertically centered.

Expected results:
Second to fourth slides should have their text vertically top aligned.

LibreOffice details:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 5d7251c7121cee8885fa9f2387c4a0625dd4ecee
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

But not yet in 
Version: 7.1.0.3 (x64) / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded


Additional Information:

Bibisected using bibisect-win64-7.2 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=b6b02e0b4c9d739836e1f61a886ea45b01e6696e 
author	Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>	2021-04-20 13:02:44 +0200
committer	László Németh <nemeth@numbertext.org>	2021-04-29 10:48:27 +0200

tdf#111903 tdf#137152 PPTX export: fix placeholders

Adding CC to: Attila Bakos
Comment 1 NISZ LibreOffice Team 2021-05-12 12:21:22 UTC
Created attachment 171917 [details]
The original file saved by Impress
Comment 2 NISZ LibreOffice Team 2021-05-12 12:22:05 UTC
Created attachment 171918 [details]
Screenshot of the original and exported document side by side in PowerPoint and Impress
Comment 3 Xisco Faulí 2021-06-01 10:19:13 UTC
attachment 104418 [details] from bug 41253 is also affected by this issue
Comment 4 Xisco Faulí 2021-06-01 11:07:51 UTC
I see this issue affects many files, like attachment 128851 [details] from bug 104015, where the background color and the border are gone after roundtrip. Increasing importance since b6b02e0b4c9d739836e1f61a886ea45b01e6696e affects many documents
Comment 5 Attila Bakos (NISZ) 2021-06-01 11:40:03 UTC
Hi Xisco!

Yesterday, my patch was merged, which have to fix these issues. You can find it here: https://gerrit.libreoffice.org/c/core/+/116113 
Hopefully it will do its the job.

Before there were missing the line/fill/effect/style export function calls for placeholders (because the Impress exported custom shapes). What i know still has problem is the font style export. In spite of in PP it is fine but in Impress it has problems. (However Impress recognizes the empty placeholder what PP doesn't.)
So, further fix soon.
Comment 6 Attila Bakos (NISZ) 2021-06-01 11:51:50 UTC
Created attachment 172530 [details]
How it looks in 7.2 master today

As there can be seen it is on the way to be solved. Text have to be fixed, but fill and line is ok.
See: https://bugs.documentfoundation.org/show_bug.cgi?id=142537
Comment 7 Attila Bakos (NISZ) 2021-06-01 11:53:00 UTC
(In reply to Attila Bakos (NISZ) from comment #6)
> Created attachment 172530 [details]
> How it looks in 7.2 master today
> 
> As there can be seen it is on the way to be solved. Text have to be fixed,
> but fill and line is ok.
> See: https://bugs.documentfoundation.org/show_bug.cgi?id=142537

Oh i forgot to write the build, sorrry:
Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: bae0aad9457f905c2bbaa6bbd98d0d2b7a6259f5
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 8 Xisco Faulí 2021-06-01 11:56:32 UTC
oh nice, should this issue be closed as RESOLVED FIXED, then ?
Comment 9 Attila Bakos (NISZ) 2021-06-01 12:03:00 UTC
(In reply to Xisco Faulí from comment #8)
> oh nice, should this issue be closed as RESOLVED FIXED, then ?

After I fix the alignment ( if i remember well that was mentioned in this ticked), of course.
Comment 10 Xisco Faulí 2021-06-01 12:06:56 UTC
(In reply to Attila Bakos (NISZ) from comment #9)
> (In reply to Xisco Faulí from comment #8)
> > oh nice, should this issue be closed as RESOLVED FIXED, then ?
> 
> After I fix the alignment ( if i remember well that was mentioned in this
> ticked), of course.

oh I see, at least the problems I mentioned in comment 3 and comment 4 are fixed in

Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: 361b95b39c0ad3028f82b9893bb3c84dcbd1932f
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

I guess we can reduce the priority back to normal.
Comment 11 Xisco Faulí 2021-06-04 15:43:12 UTC
Actually the problem with comment 3 is still reproducible in

Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: 268f27f6623334b81762b068f842c944a7541f25
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

and the office-interoperability-tools still found many files affected by https://cgit.freedesktop.org/libreoffice/core/commit/?id=b6b02e0b4c9d739836e1f61a886ea45b01e6696e so I think it's fair to bump the priority a bit
Comment 12 Commit Notification 2021-07-02 12:23:43 UTC
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dbdcceb9d77c602ea1161ab0f4e3899071333a92

tdf#142235 PPTX export: fix styles with placeholders

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2021-07-08 12:12:50 UTC
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/3518b4cebdddc0446cf923c38acee52bf5d6a9b1

tdf#142235 PPTX export: fix styles with placeholders

It will be available in 7.2.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 NISZ LibreOffice Team 2021-08-10 07:19:30 UTC
Verified in:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: eeeef98796df322d89912070c8e431c5f6d1283f
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded