Bug 142420 - Filter By Color: Hangs after apply a color filter and then deselect the filter
Summary: Filter By Color: Hangs after apply a color filter and then deselect the filter
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All Linux (All)
: high major
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.3.0 target:7.2.3
Keywords: haveBacktrace, implementationError
: 144320 144872 145246 145329 (view as bug list)
Depends on:
Blocks: AutoFilter-Color
  Show dependency treegraph
 
Reported: 2021-05-22 08:24 UTC by Kevin Suo
Modified: 2021-11-18 16:16 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file per instructions (8.23 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-05-28 13:07 UTC, NISZ LibreOffice Team
Details
gdbtrace.log without debug symbol (14.95 KB, text/x-log)
2021-06-16 09:45 UTC, Kevin Suo
Details
gdb backtrace (41.56 KB, text/plain)
2021-07-21 10:10 UTC, Xisco Faulí
Details
another gdbtrace.log (31.04 KB, text/x-log)
2021-07-21 11:26 UTC, Kevin Suo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Suo 2021-05-22 08:24:14 UTC
Steps to Reproduce:

1. Generate the following data in a new Calc document:
a    b
1    2
3    4

2. Highlight "3" to yellow.

3. Set autofilter, dropdown in "a", go to "Backgroud Color", and select the yellow color. 
Now the filter flow window is closed and one record is shown.

4. Dropdown in "a", in Background Color deselect the yellow color.
-> Crash.

Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: 4a9eef7849a75ba91806886ea9c96d114c8d56f9
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN
Calc: threaded

Fedora 33 X64.
Comment 1 Kevin Suo 2021-05-22 08:34:46 UTC
At the time of crash the terminal outputs:
malloc(): unaligned fastbin chunk detected
Comment 2 Kevin Suo 2021-05-23 00:27:55 UTC Comment hidden (obsolete)
Comment 3 Kevin Suo 2021-05-27 08:22:48 UTC Comment hidden (obsolete)
Comment 4 NISZ LibreOffice Team 2021-05-28 13:07:58 UTC
Created attachment 172407 [details]
Example file per instructions

I can't reproduce a crash in a fresh nightly:

Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 187136265d26c014e842550c2f1fc5997736e4fa
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 5 Kevin Suo 2021-05-28 14:02:02 UTC Comment hidden (obsolete)
Comment 6 Caolán McNamara 2021-05-29 18:59:16 UTC
This is the new color dropdown list right ?, i.e. the same menu as in bug #142393 ? Under wayland I can't even launch the menu. I have it on my todo to rework that menu/dropdown to work for me.
Comment 7 Xisco Faulí 2021-06-01 08:39:52 UTC

*** This bug has been marked as a duplicate of bug 142393 ***
Comment 8 Kevin Suo 2021-06-16 09:40:24 UTC
This is not a duplicate of bug 142393. The crash still exists with the fix to bug 142393.

Tested on lasted 7.2 branch with commit 3d311c6d63eafbe2f76d6f1768dc3f675970a55 Mon Jun 14 12:09:01 2021 +0200.

I also updated the title to mention that the crash only occurs in a non-debug build, but not in a dbgutil build.
Comment 9 Kevin Suo 2021-06-16 09:45:15 UTC Comment hidden (obsolete)
Comment 10 Xisco Faulí 2021-07-21 09:46:36 UTC
Yep, reproduced in

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: c6695a4aabeaae99174b7658f2b813788ecff7f0
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 11 Xisco Faulí 2021-07-21 10:07:45 UTC
in my case, it hangs, and it also happens with a debug build
Comment 12 Xisco Faulí 2021-07-21 10:10:53 UTC
Created attachment 173726 [details]
gdb backtrace
Comment 13 Xisco Faulí 2021-07-21 10:39:28 UTC
BTW, this is a regression, unfortunately the bisect repository points to a3a203b7c697a38d4f79877d6b5c1423fa52f2d8 which doesn't seem to be related
Comment 14 Xisco Faulí 2021-07-21 10:44:25 UTC Comment hidden (obsolete)
Comment 15 Kevin Suo 2021-07-21 11:26:56 UTC
Created attachment 173733 [details]
another gdbtrace.log

Here is another gdbtrace.log generated in a debug symbol only build.
Comment 16 Timur 2021-07-26 13:46:50 UTC Comment hidden (obsolete)
Comment 17 Xisco Faulí 2021-08-10 16:02:03 UTC
(In reply to Timur from comment #16)
> (In reply to Xisco Faulí from comment #14)
> > Not reproducible in
> > Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
> > Build ID: ceb32f59d96a17c3007ed883fb44bc880673c8e0
> > CPU threads: 16; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
> 
> Meaning this is Linux only bug. 
> 
> Xisco, you marked regression, why? I don't see how this ever worked,
> previously there was a crash on first autofilter select the yellow color. 
> Looks like implementationError.

See comment 13. In some builds in the bisect repository, it doesn't crash/hang
Comment 18 Buovjaga 2021-10-21 07:36:29 UTC
*** Bug 144320 has been marked as a duplicate of this bug. ***
Comment 19 Buovjaga 2021-10-21 07:36:37 UTC
*** Bug 144872 has been marked as a duplicate of this bug. ***
Comment 20 Buovjaga 2021-10-21 07:40:47 UTC
*** Bug 145246 has been marked as a duplicate of this bug. ***
Comment 21 Kevin Suo 2021-10-21 08:08:46 UTC
Behaviour has changed on current master - now if I click on the filter-by-color auto filter item I have the following warning in terminal, and the color popup flow dialog does not show up:
(soffice:240036): Gdk-WARNING **: 16:06:37.421: Tried to map a popup with a non-top most parent
Comment 22 Julien Nabet 2021-10-26 18:24:25 UTC
*** Bug 145329 has been marked as a duplicate of this bug. ***
Comment 23 Caolán McNamara 2021-11-17 15:20:19 UTC
I see that my wayland problems are because the menu is executed as a sibling of the autofilter dropdown and not as a child
Comment 24 Commit Notification 2021-11-17 19:48:49 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2b3cc82b88d0c6508e9c0c6ccc53e0f9bfb4069e

tdf#142420 color menu should be a child of the autofilter, not a sibling

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 25 Caolán McNamara 2021-11-17 19:50:57 UTC
works for me in trunk now, backport to 7-2 in gerrit
Comment 26 Kevin Suo 2021-11-18 02:45:15 UTC
Verified fixed on master.
Comment 27 Commit Notification 2021-11-18 09:00:35 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/f0e816412c386de976228b2232c23c31fd7f2d2c

tdf#142420 color menu should be a child of the autofilter, not a sibling

It will be available in 7.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 28 Commit Notification 2021-11-18 11:11:17 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-2-3":

https://git.libreoffice.org/core/commit/6bd1cb73480d2b20926f964b8db8c31a522c5ec3

tdf#142420 color menu should be a child of the autofilter, not a sibling

It will be available in 7.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.