+++ This bug was initially created as a clone of Bug #144184 +++ Description: Calc disables header/footer when saves a spreadsheet Steps to Reproduce: 1. Open Calc 2. Type into A1 cell any data, like 1111 3. Make sure Header and Footer checkboxes are enabled in Format-Page dialog on its tabs 4. Save file as ODS and close it 5. Open the file 6. Look at header and Footer tabs in Format-Page dialog => the both options are disabled Actual Results: Calc disables header/footer when saves a spreadsheet Expected Results: Calc saves header/footer state when saves a spreadsheet Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.4 (x64) / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: threaded but not in 7.1.0.3 => regression
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=b9993369b4011cd8f367e439f5248096827f1efc author Daniel Arato (NISZ) <arato.daniel@nisz.hu> 2021-06-08 11:53:42 +0200 committer László Németh <nemeth@numbertext.org> 2021-06-29 22:50:43 +0200 commit b9993369b4011cd8f367e439f5248096827f1efc (patch) tree 8eb5b94d9d7676f8b94f47206665842e70d3f154 parent f7567758d2a1024580b18bef4156e59e63ac9f6d (diff) tdf#121715 XLSX: support custom first page header/footer Bisected with: 7.2 Adding Cc: to Daniel Arato
*** Bug 144935 has been marked as a duplicate of this bug. ***
*** Bug 144368 has been marked as a duplicate of this bug. ***
*** Bug 144281 has been marked as a duplicate of this bug. ***
*** Bug 144430 has been marked as a duplicate of this bug. ***
*** Bug 144613 has been marked as a duplicate of this bug. ***
I don't know much about the code itself but I found out that bFirstHeader is always False < https://opengrok.libreoffice.org/xref/core/sc/source/filter/xml/XMLTableMasterPageExport.cxx?r=6f04952e#176 >. Doesn't matter if the option 'Same content on first page' is enabled or not
Based on the reported repros over in #144184, does anyone have a hunch on what the reproducibility of this bug actually depends on?
(In reply to Dániel Arató (NISZ) from comment #8) I have created a screencast there in attachment 175538 [details] - doesn't it help? Or maybe you may record your steps, so that we could try and compare them, to find the differences?
*** Bug 145007 has been marked as a duplicate of this bug. ***
In addition to steps from scratch, also sample can be used. Open ODS attachment 174988 [details] from bug 144368, confirm F/H turned on (regardless if content changed) and save, on reopen they are turned off.
Created attachment 175671 [details] Test case spreadsheet
Can reproduce on Arch Linux, GNOME Wayland. See attachment "Test case spreadsheet". Version: 7.2.1.2 / LibreOffice Community Build ID: 20(Build:2) CPU threads: 12; OS: Linux 5.14; UI render: default; VCL: gtk3 Locale: de-DE (en_US.utf8); UI: en-US 7.2.1-2 Calc: threaded
Created attachment 175672 [details] Test case spreadsheet, screenshots how to reproduce
I just updated LibreOffice to 7.2.2.2 via the LibreOffice PPA. According to the release notes, this bug should be fixed in 7.2.2.2 rc2. But this is not the case, because the header/footer disabling is still present, unfortunately. In other words: no change compared to version 7.2.1.4. Info about the LibreOffice I use: Version: 7.2.2.2 / LibreOffice Community Build ID: 20(Build:2) CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: nl-NL (nl_NL.UTF-8); UI: nl-NL Ubuntu package version: 1:7.2.2~rc2-0ubuntu0.18.04.1~lo1 Calc: threaded
(In reply to Marqeaux from comment #15) > I just updated LibreOffice to 7.2.2.2 via the LibreOffice PPA. According to > the release notes, this bug should be fixed in 7.2.2.2 rc2. Release notes can't tell you that *this* bug is fixed. They might mention fixes for bug 144184, which initially started with this problem, but in the course, was changed to track a different thing, which is why *this* one was created, and a developer has *assigned* this bug to them (until you, for unclear reason, unassigned it, changing the status from ASSIGNED to NEW).
Yes, you're right. My mistake. And I should make my comment under bug 144184, because the header/footer issue is still there in LibreOffice 7.2.2.2. Sorry for the inconvenience. ;-)
I just tested it on LibreOffice 7.3 alpha1 on debian sid/experimental and the header and footer error still persists
*** Bug 145514 has been marked as a duplicate of this bug. ***
*** Bug 145549 has been marked as a duplicate of this bug. ***
Just a polite ping to Dániel Arató, please confirm whether you are still working on this one?
I do not reproduce on current master, but I do reproduce on 7.2. Is it fixed somewhere on master?
(In reply to Kevin Suo from comment #22) > I do not reproduce on current master, but I do reproduce on 7.2. Is it fixed > somewhere on master? Still reproducible for me in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: ca74611acfef50280a2c1f785448d9a09cca5a0d CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
as of v7.2.2.2 (OS= Linux ubuntu 20.04.3) this bug persists. Additional note - What I have found: Selecting Format -> Page Style -> Header select Header On then Insert -> Headers and Footers the header created from a previous version persists and on selecting OK the header will print correctly (test by toggling Print Preview). The condition persists throughout any other sheet selection until that instance is closed (or saved and then closed) when the routine to select a header or footer has to be repeated. Once again, the header created from a previous version persists.
This bug still exists in version 7.2.2.2 (x64) running under WIN11.
Note: When the ODS file is opened with Excel, the header/footer information is accurate and they appear in "Print Preview". When the same file is opened with Calc, the headers/footers flag is shown as being 'off'. It would appear that the header/footer flags are being properly stored, but that Calc 'reads' them as being 'off' when opening the file.
(In reply to John Allender from comment #27) > Note: When the ODS file is opened with OpenOffice Calc, the header/footer information > is accurate and they appear in "Print Preview". When the same file is > opened with Calc, the headers/footers flag is shown as being 'off'. > > It would appear that the header/footer flags are being properly stored, but > that Calc 'reads' them as being 'off' when opening the file.
Please ignore/delete comments 27 and 29. They are duplicates that I cannot figure out how to delete. ☺
Finally: If the test file is stored in the *.xlsx format, it opens properly with both headers/footers displayed in Libre Calc, MS Excel and OpenOffice Calc. Please advise when problem with Libre Calc and *.ods formatted files is resolved.
*** Bug 145626 has been marked as a duplicate of this bug. ***
*** Bug 145686 has been marked as a duplicate of this bug. ***
Some more info on this: If you take the producer ods and manually remove the two "style:header-first" and the two "style:footer-first" elements from style.xml (and rezip) then the resulting ods loads and works as expected (until you save it again). Alternatively, change the two "style:header-first" from false to true and the setting will even survive a store-load cycle. (The same for the footer if you want that, I guess.) This perfectly matches the commit description of https://cgit.freedesktop.org/libreoffice/core/commit/?id=b9993369b4011cd8f367e439f5248096827f1efc (which is the culprit of bug 144184): There, the author implements export of the new feature to ods before implementing the import, which in itself is a strange order of things. Apparantly, the import never got implemented (and the loader mistakes "header-first" for "header" or such), or at least not correctly. Also, where is the UI setting for that display first setting, and where would one set a style for the first page?
*** Bug 145727 has been marked as a duplicate of this bug. ***
*** Bug 145809 has been marked as a duplicate of this bug. ***
I think that regression commit should be reverted in 7.2.
*** Bug 145893 has been marked as a duplicate of this bug. ***
I opened a CALC spreadsheet which I had save in November 2020 in ODS format using an earlier version of CALC and it opened with headers/footers enabled. This indicates to me that that issue is with the save routines.
Attila Bakos (NISZ) committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5db9b33dadda67c7f97d8c23df17211fae380919 tdf#144940 sc: fix disabled header/footer regression It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Attila Bakos (NISZ) committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/241733d1d91233b2f3bb996fc55302fb55b6c036 tdf#144940 sc: fix disabled header/footer regression It will be available in 7.3.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Attila Bakos (NISZ) committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/5ece740b3672b4204231c995a31ae97c108e7c80 tdf#144940 sc: fix disabled header/footer regression It will be available in 7.2.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I tested with 7.2.4dev and it works
> I tested with 7.2.4dev and it works I am sorry but I cannot confirm that it works with 7.2.4dev (https://git.libreoffice.org/core/+log/2eefc29b53b01dc07eb62aeb42cd56f178370d1d). I launched that dev version, opened a critical .ods file, switched on header and footer again and saved the file again. Then I relaunched LO 7.2.4dev, reloaded the newly saved file and tried the Print Preview and both header and footer lines are gone again.
(In reply to Ulf Dunkel from comment #45) > > I tested with 7.2.4dev and it works > > I am sorry but I cannot confirm that it works with 7.2.4dev > (https://git.libreoffice.org/core/+log/ > 2eefc29b53b01dc07eb62aeb42cd56f178370d1d). I launched that dev version, > opened a critical .ods file, switched on header and footer again and saved > the file again. Then I relaunched LO 7.2.4dev, reloaded the newly saved file > and tried the Print Preview and both header and footer lines are gone again. Hello Ulf, that build doesn't contain the fix. You have to download a more recent daily build from https://dev-builds.libreoffice.org/daily/libreoffice-7-2/
(In reply to Xisco Faulí from comment #46) > (In reply to Ulf Dunkel from comment #45) > > > I tested with 7.2.4dev and it works > > > > I am sorry but I cannot confirm that it works with 7.2.4dev > > (https://git.libreoffice.org/core/+log/ > > 2eefc29b53b01dc07eb62aeb42cd56f178370d1d). I launched that dev version, > > opened a critical .ods file, switched on header and footer again and saved > > the file again. Then I relaunched LO 7.2.4dev, reloaded the newly saved file > > and tried the Print Preview and both header and footer lines are gone again. > > Hello Ulf, > that build doesn't contain the fix. > You have to download a more recent daily build from > https://dev-builds.libreoffice.org/daily/libreoffice-7-2/ Hello Xisco Faulí, thank you for pointing me to my mistake - you're right. I'm glad this issue has been fixed now.
Verified in: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4ac9032163cf55c160145373e7c41741c9c339ca CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: CL
*** Bug 146050 has been marked as a duplicate of this bug. ***
7.2.4 was a hotfix release, updating target in status-whiteboard
Today I downloaded LibreOffice 7.2.4.1 from the official LibreOffice website (nl.libreoffice.org), and installed it on my laptop from work. I opened a new Calc document and enabled both header and footer. After saving the document, I closed LibreOffice entirely. After restarting LibreOffice and reopening that same document, it still resulted in a disabled header and footer. Am I missing something? I'm confused now... Info about the used LibreOffice: Version: 7.2.4.1 (x64) / LibreOffice Community Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: threaded
(In reply to Marqeaux from comment #51) > Am I missing something? I'm confused now... Please note the comment above, there was an urgent security update with version number 7.2.4, and what would've been 7.2.4 has been pushed back to 7.2.5. The commit notification (comment 43) cannot be changed, however the Whiteboard field is updated to reflect this change.
*** Bug 146338 has been marked as a duplicate of this bug. ***
*** Bug 146457 has been marked as a duplicate of this bug. ***
*** Bug 146467 has been marked as a duplicate of this bug. ***
Tested today with Calc 7.2.4.1 - the error persists: To reproduce the error 1. set a header and footer text e.g. filename and pager 2. activate the header and/or footer content in the page style options. 3. save, close and reopen the calc spreadsheed file 4. header and footer is inactive, I expect it to be active and consider this as a bug
(In reply to marco from comment #57) > Tested today with Calc 7.2.4.1 - the error persists: > To reproduce the error > 1. set a header and footer text e.g. filename and pager > 2. activate the header and/or footer content in the page style options. > 3. save, close and reopen the calc spreadsheed file > 4. header and footer is inactive, I expect it to be active and consider this > as a bug you have to test with LibreOffice 7.2.5.2, due to be released later this week
It seems like the issue is resolved when I reopen a file in 7.2.5.2. But I can still reproduce the problem when I reopen the file which was saved under 7.2.5.2 (office version 1.3) in an older version like 6.4.7.2 (office version 1.2).
(In reply to Wittich from comment #59) > It seems like the issue is resolved when I reopen a file in 7.2.5.2. > > But I can still reproduce the problem when I reopen the file which was saved > under 7.2.5.2 (office version 1.3) in an older version like 6.4.7.2 (office > version 1.2). Please, create a new report for it
(In reply to Wittich from comment #59) > It seems like the issue is resolved when I reopen a file in 7.2.5.2. > > But I can still reproduce the problem when I reopen the file which was saved > under 7.2.5.2 (office version 1.3) in an older version like 6.4.7.2 (office > version 1.2). I can reproduce the problem also with the 7.3 beta. There is no backwards capability at the moment to 6.4. -- Version: 7.3.0.3 / LibreOffice Community Build ID: f4d11761603c82fae6474d6e0e1cb32d39b86e4b CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
(In reply to Xisco Faulí from comment #60) > Please, create a new report for it Done Bug 147141 https://bugs.documentfoundation.org/show_bug.cgi?id=147141
*** Bug 147328 has been marked as a duplicate of this bug. ***