Bug 154270 - Colours reset to defaults with Single Toolbar UI
Summary: Colours reset to defaults with Single Toolbar UI
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.5.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Maxim Monastirsky
URL:
Whiteboard: target:24.2.0 target:7.6.2
Keywords: bibisected, bisected, regression
: 82438 90852 113433 122003 139209 139803 140097 142962 146119 150785 154102 156803 (view as bug list)
Depends on:
Blocks: Calc-Toolbars
  Show dependency treegraph
 
Reported: 2023-03-19 09:46 UTC by maison
Modified: 2023-09-06 07:38 UTC (History)
17 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description maison 2023-03-19 09:46:22 UTC
Description:
If I remember correctly, this bug didn’t exist in previous versions.

Steps to Reproduce:
1. Type aa in A1, then come back to A1.
2. From the toolbar, set the font colour to (let’s say) automatic and the background to none.
3. Start typing something in A2 or wherever else.

Actual Results:
As soon as you start typing, the toolbar colours resets to propose the default red font and yellow background. Therefore, if you want to apply the same settings as in A1, you have to reselect your colours from the drop‐down list rather than just press the colour button to reuse the previous choice.

Let’s add that if you fiddle with other functions in the meantime, like play with the mouse, the menus, the arrow keys, these buttons won’t reset. They only reset if you start typing somewhere.
For example, if you don’t type but want to apply your colour choice to another cell, you can reuse your toolbar button setting. But don’t start typing because your button colour choice is lost.

Expected Results:
Don’t unnecessarily reset the choice of colours the user made. Be consistent and don’t change the user choices in some cases but not others.


Reproducible: Always


User Profile Reset: No

Additional Info:
There might be other settings that are reset, but I mainly use those two ones.
Comment 1 maison 2023-04-03 20:17:26 UTC Comment hidden (obsolete)
Comment 2 ady 2023-04-03 21:19:33 UTC Comment hidden (obsolete)
Comment 3 Lesline 2023-04-04 03:36:02 UTC Comment hidden (obsolete)
Comment 4 ady 2023-04-04 19:05:22 UTC Comment hidden (obsolete)
Comment 5 maison 2023-04-04 19:15:53 UTC
I’ve just updated to this today, but the bug is still there.
Version: 7.5.2.2 (X86_64) / LibreOffice Community
Build ID: 53bb9681a964705cf672590721dbc85eb4d0c3a2
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: threaded
Comment 6 ady 2023-04-04 21:25:07 UTC Comment hidden (obsolete)
Comment 7 maison 2023-04-04 21:28:59 UTC Comment hidden (obsolete)
Comment 8 ady 2023-04-04 21:56:16 UTC Comment hidden (obsolete)
Comment 9 maison 2023-04-04 22:20:44 UTC
So, it’s not the profile. It’s the one toolbar interface that resets the colours and maybe who knows what other settings.
Comment 10 ady 2023-04-05 18:32:19 UTC Comment hidden (obsolete)
Comment 11 maison 2023-04-05 18:38:54 UTC Comment hidden (obsolete)
Comment 12 ady 2023-04-05 21:06:59 UTC Comment hidden (obsolete)
Comment 13 maison 2023-04-05 21:10:53 UTC
It’s not the standard two‐line interface, but the single toolbar interface.
I started a new profile, but the bug doesn’t happen.
I set the single toolbar interface and then the bug is triggered.
Comment 14 ady 2023-04-05 21:42:41 UTC
(In reply to maison from comment #13)
> I set the single toolbar interface and then the bug is triggered.

Repro in 7.6 alpha, not in 7.4.6. > regression.
Comment 15 raal 2023-04-05 22:29:12 UTC
This seems to have begun at the below commit in bibisect repository/OS linux-64-7.5.
Adding Cc: to Maxim Monastirsky ; Could you possibly take a look at this one?
Thanks
 502feab2611d6ffc071d2e0fa40865fb9ccd5504 is the first bad commit
commit 502feab2611d6ffc071d2e0fa40865fb9ccd5504
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Fri Jun 24 02:36:28 2022 +0200

    source 9bc1ffa2153d2474b023e0860d3c9c68ee18727b

135591: tdf#125040 Make single mode toolbar context aware | https://gerrit.libreoffice.org/c/core/+/135591
Comment 16 Commit Notification 2023-07-04 18:27:06 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8ffb8e164d9d350a1b9887d0a75e0a82892008ee

tdf#154270 Sync toolbar button recent colors

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 17 Maxim Monastirsky 2023-07-04 19:48:59 UTC
*** Bug 150785 has been marked as a duplicate of this bug. ***
Comment 18 Maxim Monastirsky 2023-07-04 19:50:57 UTC
*** Bug 122003 has been marked as a duplicate of this bug. ***
Comment 19 Maxim Monastirsky 2023-07-04 19:53:29 UTC
*** Bug 139803 has been marked as a duplicate of this bug. ***
Comment 20 Maxim Monastirsky 2023-07-04 19:59:08 UTC
*** Bug 113433 has been marked as a duplicate of this bug. ***
Comment 21 Maxim Monastirsky 2023-07-04 20:04:28 UTC
*** Bug 82438 has been marked as a duplicate of this bug. ***
Comment 22 Maxim Monastirsky 2023-07-04 20:27:10 UTC
*** Bug 154102 has been marked as a duplicate of this bug. ***
Comment 23 Maxim Monastirsky 2023-07-04 20:29:40 UTC
*** Bug 139209 has been marked as a duplicate of this bug. ***
Comment 24 Maxim Monastirsky 2023-07-04 20:51:18 UTC
*** Bug 90852 has been marked as a duplicate of this bug. ***
Comment 25 Maxim Monastirsky 2023-07-04 20:56:32 UTC
*** Bug 142962 has been marked as a duplicate of this bug. ***
Comment 26 Maxim Monastirsky 2023-07-05 07:15:23 UTC
*** Bug 140097 has been marked as a duplicate of this bug. ***
Comment 27 Maxim Monastirsky 2023-07-05 07:17:34 UTC
*** Bug 146119 has been marked as a duplicate of this bug. ***
Comment 28 ady 2023-07-10 23:43:34 UTC
Works as expected as of:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 81726f5af5fda25f0d92ffc8458d7f24eb16f408
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (es_AR); UI: en-US
Calc: CL threaded

Probably some back-port / cherry-pick would be desirable?
Comment 29 maison 2023-08-23 21:51:54 UTC
Not yet in 7.6.0
Comment 30 maison 2023-08-23 22:11:46 UTC
Should we add here or something else that the Single Toolbar UI forgets to update when you go in Print Preview?
Comment 31 Stéphane Guillou (stragu) 2023-09-02 00:41:49 UTC
*** Bug 156803 has been marked as a duplicate of this bug. ***
Comment 32 Stéphane Guillou (stragu) 2023-09-02 01:06:21 UTC
Verified fixed in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d88779fc86385dde1215fd28b78a69eacc6b4f97
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Maxim, I understand that this commit is wider-ranging than just a fix for the regression introduced in 7.5, but do you think it is OK to get it cherrypicked for 7.6?
Comment 33 Xisco Faulí 2023-09-04 13:57:51 UTC
(In reply to Stéphane Guillou (stragu) from comment #32)
> Verified fixed in:
> 
> Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
> Build ID: d88779fc86385dde1215fd28b78a69eacc6b4f97
> CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
> Locale: en-AU (en_AU.UTF-8); UI: en-US
> Calc: threaded
> 
> Maxim, I understand that this commit is wider-ranging than just a fix for
> the regression introduced in 7.5, but do you think it is OK to get it
> cherrypicked for 7.6?

Done -> https://gerrit.libreoffice.org/c/core/+/156519
Comment 34 Stéphane Guillou (stragu) 2023-09-04 16:35:53 UTC
Thanks for the cherrypick Xisco, and thanks for the big fix, Maxim! :)

(In reply to maison from comment #30)
> Should we add here or something else that the Single Toolbar UI forgets to
> update when you go in Print Preview?

I don't see that in 7.5.5.2. If you can still reproduce, please report in a new ticket. Thanks!
Comment 35 maison 2023-09-04 16:39:31 UTC
If you use the default interface, you get a special toolbar in the Print preview.
If you use the one line interface (maybe something else), it stays the same in the Print preview, but it has nothing to do there because it’s unadapted.
Comment 36 Commit Notification 2023-09-06 07:38:16 UTC
Maxim Monastirsky committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/1345619e0b3c2825c2ae50ada2c209d4ad8461ad

tdf#154270 Sync toolbar button recent colors

It will be available in 7.6.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.