Bug 157740 - FILESAVE PPTX: Explosion in the number of master slides
Summary: FILESAVE PPTX: Explosion in the number of master slides
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: All All
: medium normal
Assignee: Balázs Varga (allotropia)
URL:
Whiteboard: target:24.8.0 target:24.2.0.0.beta2 t...
Keywords:
: 134090 (view as bug list)
Depends on:
Blocks: PPTX-MasterSlide
  Show dependency treegraph
 
Reported: 2023-10-13 11:13 UTC by Gerald Pfeifer
Modified: 2024-09-21 05:12 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample document (PPTX) (672.29 KB, application/vnd.ms-powerpoint)
2023-10-13 11:13 UTC, Gerald Pfeifer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer 2023-10-13 11:13:32 UTC
Created attachment 190190 [details]
Sample document (PPTX)

1. Open attached document which has one slide.
2. "View" - "Master Slide"
3. Remove all but one master slide (which look the same)
4. Save under a new name and open the file just saved
5. Expected behavior: 1 slide, 1 master slide
   Actual behavior: 1 slide, many master slides (looking alike)

Seen with

  Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
  Build ID: e9374f74385d7dfe77d1902d3d82af20143bc775
  CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

Regression from

  Version: 7.6.3.0.0+ (X86_64) / LibreOffice Community
  Build ID: 9c8a1994bea590db7436638580231daf31844fd6
  CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

I am pretty sure this is caused by the changed from bug #155512 .
Comment 1 Timur 2023-10-21 18:32:38 UTC
Yes, but .. That is WIP so this one should wait for the completion to check.
Comment 2 Aron Budea 2023-10-23 06:20:16 UTC
This isn't a new bug, the fix to bug 155512 only made it more apparent. When roundtripping the sample PPTX in an old LO, eg. 4.0.0.3, and opening it in PowerPoint, Slide Master view there shows all those extra master slides.
Comment 3 Aron Budea 2023-10-27 11:09:36 UTC
For the record, there are still patches for bug 155512 on gerrit that might interfere with the fix to this (can be seen by searching for "tdf#155512").
Comment 4 Balázs Varga (allotropia) 2023-10-27 15:04:06 UTC
(In reply to Aron Budea from comment #3)
> For the record, there are still patches for bug 155512 on gerrit that might
> interfere with the fix to this (can be seen by searching for "tdf#155512").

Okay. Thanks for the note. Will wait with this until all the related patches are not merged. :)
Comment 5 Timur 2023-11-02 09:54:29 UTC
Hi Balázs. Patches are there. Import now works, with some limits: parent slide is missing, so attachment 187524 [details] with 47 master slides in MSO will show 44 in LO, and order is somehow not the same.
Comment 6 Timur 2023-11-05 17:20:27 UTC
*** Bug 134090 has been marked as a duplicate of this bug. ***
Comment 7 Commit Notification 2023-12-18 14:11:07 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bff76421e234df7246a7f49c71a11432f86e09d1

tdf#157740 FILESAVE PPTX: fix explosion of the number of master slides

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2023-12-19 10:49:01 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/00ea1f0252fa2b59adc5336ffd0d5f5b73cf1203

tdf#157740 FILESAVE PPTX: fix explosion of the number of master slides

It will be available in 24.2.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2023-12-19 21:47:07 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/a4640043ed772b5dcc1ee9d36cfd8b0e4759f894

tdf#157740 FILESAVE PPTX: fix explosion of the number of master slides

It will be available in 7.6.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Gerald Pfeifer 2023-12-25 07:28:50 UTC
Happy to confirm this appears fixed with

  Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
  Build ID: f989ee32b35ee4f0750ae313d35d225d252d64d4
  CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US

as the original reporter.