Bug 160598 - Remove footnotes and endnotes using the navigator
Summary: Remove footnotes and endnotes using the navigator
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Jim Raykowski
URL:
Whiteboard: target:24.8.0
Keywords:
Depends on:
Blocks: Navigator Footnote-Endnote
  Show dependency treegraph
 
Reported: 2024-04-09 10:54 UTC by Amin Irgaliev
Modified: 2024-04-25 07:59 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Demo of enhancement to remove footnotes/endnotes using the Navigator (991.26 KB, video/x-matroska)
2024-04-22 04:38 UTC, Jim Raykowski
Details
column for delete icon (49.57 KB, image/png)
2024-04-24 05:10 UTC, Jim Raykowski
Details
Demo of only the selected entry has delete button (153.25 KB, video/x-matroska)
2024-04-25 03:40 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Amin Irgaliev 2024-04-09 10:54:46 UTC
Description:
Users periodically need to delete all footnotes in a document. Now this can be done through the navigator by double-clicking on the link and pressing the "delete" button. It was previously proposed to add the ability to search for footnotes and endnotes in Find and Replace: https://bugs.documentfoundation.org/show_bug.cgi?id=62158.

The feature offered in 62158 is more flexible for experienced users, but not all beginners will be able to immediately understand this functionality. Based on this, it might be worth adding a “Remove All” button to the navigator context menu for the “Footnotes” and “Endnotes” tabs.

Actual Results:
1. Open a document with footnotes in LibreOffice, for example, Writer.
2. Open the navigator.
3. Double-click on the footnotes to go to it.
4. Delete each footnote separately by navigating through the document.

Expected Results:
1. Open a document with footnotes in LibreOffice, for example, Writer.
2. Open the navigator.
3. Click on the footnotes.
4. In the context menu, click on the "Delete all" button, for example.
5. Make sure that all footnotes are removed from the documents.


Reproducible: Always


User Profile Reset: No

Additional Info:
Comment 1 Heiko Tietze 2024-04-09 11:17:21 UTC
I disagree with global functions on contextual interactions. In the file browser you never expect to delete a folder by right clicking a file. 

But how about a multi-selection?
Comment 2 Amin Irgaliev 2024-04-09 11:50:06 UTC
(In reply to Heiko Tietze from comment #1)
> I disagree with global functions on contextual interactions. In the file
> browser you never expect to delete a folder by right clicking a file. 
> 
> But how about a multi-selection?

Perhaps we conveyed the idea slightly incorrectly after translation. The main idea was that right-clicking on the header of the footnotes list would allow you to delete all footnotes at once. Using the file browser as an example, this is the “delete folder” item in the context menu of a folder, which allows you to delete all files at once along with the folder at once.
Comment 3 Heiko Tietze 2024-04-09 12:17:25 UTC
(In reply to Amin Irgaliev from comment #2)
> The main idea was that right-clicking on the header of the footnotes list...
That makes a lot of sense then :-).
Comment 4 Jim Raykowski 2024-04-22 04:38:14 UTC
Created attachment 193795 [details]
Demo of enhancement to remove footnotes/endnotes using the Navigator

Hi all,

Here is a demo of the proposed enhancement patch found at:
https://gerrit.libreoffice.org/c/core/+/166414
Comment 5 Heiko Tietze 2024-04-22 07:11:50 UTC
(In reply to Jim Raykowski from comment #4)
> Created attachment 193795 [details]
> Demo of enhancement to remove footnotes/endnotes using the Navigator
Awesome!

What do you think about making the primary function/s (here Delete, Delete All) more prominent with tool buttons in the tree? A bit like what was suggested in https://design.blog.documentfoundation.org/2016/07/31/how-the-navigator-may-support-object-handling-in-libreoffice-draw/
Comment 6 Jim Raykowski 2024-04-24 05:10:06 UTC
Created attachment 193830 [details]
column for delete icon

(In reply to Heiko Tietze from comment #5)
> What do you think about making the primary function/s (here Delete, Delete
> All) more prominent with tool buttons in the tree? A bit like what was
> suggested in
> https://design.blog.documentfoundation.org/2016/07/31/how-the-navigator-may-
> support-object-handling-in-libreoffice-draw/
Do you mean like what is shown in the attached png?
Comment 7 Heiko Tietze 2024-04-24 07:44:49 UTC
(In reply to Jim Raykowski from comment #6)
> Do you mean like what is shown in the attached png?
Kind of, but this button wall looks awkward. And since you may click it accidentally we would need to add a confirmation. Thinking of hiding the buttons unless one hovers over the item... perhaps in a follow-up patch?
Comment 8 Commit Notification 2024-04-25 03:39:39 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b2b84dfa1d4f5da32f3335c59d618d385173a170

tdf#160598 SwNavigator enhancement to delete footnotes/endnotes

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Jim Raykowski 2024-04-25 03:40:42 UTC
Created attachment 193850 [details]
Demo of only the selected entry has delete button

(In reply to Heiko Tietze from comment #7)
> Kind of, but this button wall looks awkward. And since you may click it
> accidentally we would need to add a confirmation. Thinking of hiding the
> buttons unless one hovers over the item... perhaps in a follow-up patch?
I agree with you about the button wall. I mainly wanted to see if I was tracking with your idea. Attached is a demo of a WIP follow-up patch.
Comment 10 Mike Kaganski 2024-04-25 05:30:13 UTC
Please note that a cross is not a good metaphor for removal - a waste bin is usually used for that. But that's more a design question.

Thank you Jim, for your continuing effort to make Navigator shine!
Comment 11 Heiko Tietze 2024-04-25 07:09:33 UTC
(In reply to Jim Raykowski from comment #9)
> Attached is a demo of a WIP follow-up patch.
Would be nice if the button shows up on hover, maybe dimmed. And to have these clues for other major interactions too.
Comment 12 Heiko Tietze 2024-04-25 07:14:00 UTC
(In reply to Jim Raykowski from comment #9)
> WIP follow-up patch.
Let's close this ticket and continue on bug 160817.
Comment 13 Amin Irgaliev 2024-04-25 07:59:28 UTC
One footnote is deleted if you click on it and then "Delete" on the keyboard. But if you click on "Footnotes" or "Endnotes" and click "Delete", then all footnotes or all endnotes will not be deleted. Is something unfinished or I made a mistake somewhere?
Does it work for you to delete all footnotes or endnotes via "Delete" on the keyboard?