Bug 164074 - inline headings: add up/down outline moving support in Navigator
Summary: inline headings: add up/down outline moving support in Navigator
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2024-11-27 18:40 UTC by László Németh
Modified: 2024-11-30 17:37 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
tdf164074.fodt test document (20.15 KB, application/vnd.oasis.opendocument.text-flat-xml)
2024-11-27 18:52 UTC, László Németh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description László Németh 2024-11-27 18:40:26 UTC
Description:
Move inline headings with their paragraphs/tree/content in Navigator, as normal outline, clicking on the Up/Down arrows.

One of the most attractive function of Writer is the easy reordering of chapters and sections using the Navigator. But this is limited only for normal (root) headings, but not headings in text frames, tables etc. Because recent implementation of inline headings use text frames (with Inline Heading frame style, anchored as characters to their paragraphs), it's not possible to move them, despite that the anchor point of the inline heading is a normal (root) paragraph.

Steps to Reproduce:
1. Open the attached document.
2. Put the cursor in the outline text "1.1.1.1. Lorem".
3. Click on Move Heading Down icon in the Navigator.

Actual Results:
Nothing happens.

Expected Results:
Replace sections 1.1.1.1. Lorem and 1.1.1.2. Aliquam, with their subsections.


Reproducible: Always


User Profile Reset: No

Additional Info:
See also Bug 48459 and Bug 131728.
Comment 1 László Németh 2024-11-27 18:52:24 UTC
Created attachment 197833 [details]
tdf164074.fodt test document
Comment 2 Commit Notification 2024-11-28 11:40:40 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/32398232e925d18d2ac5a6d467b61e1a84a0df7c

tdf#164074 sw inline heading: add up/down outline moving

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 László Németh 2024-11-28 11:41:02 UTC
Full commit description:

tdf#164074 sw inline heading: add up/down outline moving

Move inline headings with their outline tree in
Navigator, clicking on the Move Heading Up/Down icons.

Instead of changing CompareSwOutlineNodes, which breaks
the code at other places, add a new SwOutlineNodesInline
and CompareSwOutlineNodesInline to sort inline headings
(put in Inline Heading frames) with normal headings only
for MoveOutlinePara and other part of Navigator's
outline moving.

Reordering chapters and sections using the Navigator was
limited for normal (root) headings, but not for headings
in text frames and tables.

Recent implementation of inline headings use text frames
with Inline Heading frame style, anchored as characters
to their paragraphs. Now these inline headings are movable
with the Navigator, with their outline tree, i.e. the paragraph
where the inline heading anchored as character, the following
paragraphs without inline heading, or the following subsections.

Note: selecting the inline headings is possible by the Navigator
content tree or or by clicking inside the text of the inline
heading in the document.

Note: according to the fix for tdf#143569, multiple headings
in the same text frame or table are ordered alphabetically in
the Navigator. This doesn't effect the inline headings, where
there is only a single heading in an Inline Heading text frame.

Follow-up to commit 7a35f3dc7419d833b8f47069c4df63e900ccb880
"tdf#48459 sw inline heading: apply it on the selected words",
commit d87cf67f8f3346a1e380383917a3a4552fd9248e
"tdf#131728 sw inline heading: fix missing/broken DOCX export"
and commit a1dcbd1d1ce6071d48bb5df26d7839aeb21b75a8
"tdf48459 sw inline heading: add Inline Heading frame style".
Comment 4 László Németh 2024-11-28 12:01:02 UTC
Putting the text cursor inside the inline heading, and clicking on the Move Up/Down icons in the outline view of the Navigator, the entire section with subsections and text content moves up/down before/after the *section* with the same level inline heading, for example:

Selecting "Inline Heading" and before the click on Move Down:

=====
*Inline Heading.* other text content of the paragraph.

Second paragraph of section "Inline Heading".

*Other Inline Heading.* other text content of the paragraph.

Second paragraph of section "Other Inline Heading".
======

After the click on Move Down:

=====
*Other Inline Heading.* other text content of the paragraph.

Second paragraph of section "Other Inline Heading".

*Inline Heading.* other text content of the paragraph.

Second paragraph of section "Inline Heading".
======
Comment 5 Commit Notification 2024-11-30 17:37:48 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/20ee4ecfeb1c504f0bc8a3057ff30e2e61f4b300

tdf#164074 sw inline heading: clean-up outline moving

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.