Bug Hunting Session
Bug 54908 - printing when a selection is active should take in account it and activate the "print selection" radio button
Summary: printing when a selection is active should take in account it and activate th...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Printing and PDF export (show other bugs)
Version:
(earliest affected)
3.6.0.2 rc
Hardware: x86 (IA32) Linux (All)
: medium normal
Assignee: Daniel Silva
URL:
Whiteboard: target:6.4.0 target:6.3.1
Keywords: preBibisect, regression
: 47140 61629 100036 (view as bug list)
Depends on:
Blocks: Print-Dialog Calc-UX PDF-Export-File-Dialog
  Show dependency treegraph
 
Reported: 2012-09-14 08:11 UTC by Paolo Benvenuto
Modified: 2019-08-12 12:43 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paolo Benvenuto 2012-09-14 08:11:45 UTC
Reproduce it in writer or calc:

- select some text/cells
- file -> print
- you are presented the print dialog, but the print "interval: selection" radio button isn't checked
Comment 1 Joel Madero 2013-03-18 19:57:51 UTC
*** Bug 61629 has been marked as a duplicate of this bug. ***
Comment 2 crxssi 2013-03-18 20:58:42 UTC
It is a problem that the "selection" radio button is not selected when a range is selected before "file-> print".

But it is even worse with direct printing.  If you select a range before using the "direct print" button on the toolbar, it will immediately print the entire sheet.  In OpenOffice it will open a dialog and ask the user "Do you want to print the selection or the entire document?".  

You can see my notes in bug 61629 (marked as a duplicate).

So it is actually partially a duplicate and partially a second bug :)
Comment 3 crxssi 2013-07-26 16:21:17 UTC
Neither problem is fixed in LO 4.1

If you have a range selected and use direct print, there is still no dialog asking “Do you want to print the selection or the entire document?” it just immediately prints the entire sheet.

And if you have a range selected and use file->print the "selected cells" option is still not checked, so it, too, prints the entire sheet.

Both are regressions.  This should be marked as "confirmed"
Comment 4 Joel Madero 2013-07-26 18:09:51 UTC
@crxssi - NEW is confirmed :) So indeed it's confirmed

In terms of a regression - when did it work as expected? Back in AOO days or at some point with LibreOffice? I'll do a bibisect if it worked in LibreOffice 3.5 or later
Comment 5 crxssi 2013-07-26 19:01:48 UTC
(In reply to comment #4)
> @crxssi - NEW is confirmed :) So indeed it's confirmed

Damn, I keep forgetting that :)  Sorry about that, on some other bugzillas "NEW" is not confirmed.

> In terms of a regression - when did it work as expected? Back in AOO days or
> at some point with LibreOffice? I'll do a bibisect if it worked in
> LibreOffice 3.5 or later

The last system I KNOW it working properly was OpenOffice 3.2.1.  It is broken in OpenOffice 3.4.1 (never tested 3.3) and LibreOffice 4.0 & 4.1.  I never tested in anything earlier in LibreOffice.
Comment 6 Joel Madero 2013-07-26 19:47:57 UTC
I always hate to call these our regressions as really it seems like a regression in AOO and we just ended up with the broken code .... hm - well no bibisect will be useful if it came from AOO code base unfortunately
Comment 7 crxssi 2013-07-26 20:27:10 UTC
Not really familiar with "bibisect" (even after doing a Google search) :)

I mean, this is still a valid bug report, even if it originally came from AOO, right?  Should I or others be reporting it differently?

I see what you mean with the word "regression", I am probably using/overusing that word and in a way not typical by developers.  To me (and most) it is really the same as a just a bug, usually a break or poorer behavior in something that used to be stable/functional, where a bug could be in a new feature.

Thanks!

From: bugzilla-daemon@freedesktop.org
To: crxssi@hotmail.com
Subject: [Bug 54908] printing when a selection is active should take in account it and activate the "print selection" radio button
Date: Fri, 26 Jul 2013 19:47:57 +0000


    
      
    
    
      
        

            Comment # 6
              on bug 54908
              from  Joel Madero

        I always hate to call these our regressions as really it seems like a
regression in AOO and we just ended up with the broken code .... hm - well no
bibisect will be useful if it came from AOO code base unfortunately
        
      

      
      You are receiving this mail because:
      
      
          You are on the CC list for the bug.
Comment 8 Joel Madero 2013-07-26 20:39:52 UTC
oh no it was perfectly well reported - I was just talking about internal policy about if this is our regression or not - something we'll talk about during next QA call I suspect :) the bug report is fine
Comment 9 tmacalp 2014-04-01 21:12:04 UTC
I'm not sure if you can really lump bug 61629 in with this bug, as this bug doesn't address "Print Directly" at all unless it ALSO defines the change in behavior specifically for "Print Directly."  

I see the following options for "Print Directly":

1. When multiple cells are selected, immediately print the selection without asking any questions.  If only one cell is selected, immediately print the entire document.  "Print Directly" shouldn't bother you with dialogs.  It should just dump the selection or sheet to the printer.

2. When multiple cells are selected, ignore them and immediately print the entire sheet.  This is the current crippled behavior.  "Print Directly" is unable to print a selection as it could before LibreOffice.

3. When multiple cells are selected, "Print Directly" opens the standard Print dialog with "Print selected cells" selected.  This is a reasonable compromise, as it still presents the same number of clicks as OpenOffice did.  Print Directly would still immediately print the entire sheet when only one cell is selected. 

4. Re-implement the simple dialog removed from "Print Directly" to give users the simple choice to print sheet, selected cells, or cancel.

I would guess that LO inadvertently removed functionality from "Print Directly" when they attempted to tidy-up the interface.  I loaded version 3.3.0 in a virtual machine and it appears that this change was made some time after OpenOffice 3.2.1 and before LibreOffice 3.3.0.  

My main complaint with having the "Print Directly" related bugs part of this bug is that this one is really just an enhancement request for a different behavior in the standard Print dialog.

I'm also not sure that this proposed behavior change for the standard print dialog is ideal.  This seems like quite a substantial UI change.  You're saying that if any user leaves 2 or more cells selected, the standard Print dialog should default to "print selected cells"?  I'm not saying this change is unreasonable, but how many users will accidentally leave cells selected and still expect to print the entire spreadsheet?  At least they will have a preview window and the option to change it.


To hopefully make things more clear, here are the various situations:

1. OpenOffice previous behavior (functional)
* Print Directly, with one cell selected:
Prints entire sheet without asking any questions.

* Print Directly, with multiple cells selected:
Pops up a dialog to print selection, print sheet, or cancel.

* File->Print when you have multiple cells selected:
Opens print dialog with "print selected sheets" as the default.


2. LibreOffice current behavior (broken Print Directly)
* Print Directly, with one cell selected:
Prints entire sheet without asking any questions.

* Print Directly, when you have multiple cells selected:
Prints entire sheet without asking any questions about selection.

* File->Print when you have multiple cells selected:
Opens print dialog with "print selected sheets" as the default.


3. Proposed behavior in this bug report
* Print Directly, with one cell selected:
Prints entire sheet without asking any questions.

* Print Directly, when you have multiple cells selected:
Not addressed so far in this report, and will continue to print entire sheet without asking any questions about selection.

* File->Print when you have multiple cells selected:
The change suggested in this report.  Opens print dialog with "print selected cells" as the default.
Comment 10 crxssi 2014-04-01 23:30:36 UTC
(In reply to comment #9)
> I'm not sure if you can really lump bug 61629 in with this bug, as this bug
> doesn't address "Print Directly" at all unless it ALSO defines the change in
> behavior specifically for "Print Directly."  

True... of course I said that earlier, too :)

Really, I think bug 61629 should be reopened, and marked as a regression, since a perfectly useful feature that addressed the issue suddenly disappeared in the first versions of LO (although it was a long time ago) as it came from AOO (Apache Open Office).

> [...]
> I'm also not sure that this proposed behavior change for the standard print
> dialog is ideal.  This seems like quite a substantial UI change.  You're
> saying that if any user leaves 2 or more cells selected, the standard Print
> dialog should default to "print selected cells"?  I'm not saying this change
> is unreasonable, but how many users will accidentally leave cells selected
> and still expect to print the entire spreadsheet?  At least they will have a
> preview window and the option to change it.

I agree that Paolo's proposal may be a different kind of behavior BUT it also makes perfect sense... and I will tell you why.  In AOO WRITER (tested in 3.4), if you select nothing and then file-> print, it selects the whole document to print.  In AOO WRITER, if you select a range and then file-> print, it automatically checks the "Selection" option and only prints that.  In my mind, Calc should behave the same way as AOO Writer.  Plus, it makes logical sense. 

But here is the kicker.... in LO Writer, they removed that functionality that OAA had!  In LO Writer, if you block something and then go to the print dialog, it DOES NOT choose the "Selection" option.  Why?  Was that intentional?  I hate to muddy the water with yet another issue, but there you have it.

> My main complaint with having the "Print Directly" related bugs part of this 
> bug is that this one is really just an enhancement request for a different
> behavior in the standard Print dialog.

That all depends on what you are comparing it to.  If you compare the standard print dialog behavior to past AOO behavior, it is a regression.  If you compare the standard print dialog to past LO behavior, it is an enhancement request.  But the current print directly issue in LO is 100% a regression in LO.
Comment 11 Robinson Tryon (qubit) 2015-01-19 06:42:08 UTC
(In reply to crxssi from comment #5)
> The last system I KNOW it working properly was OpenOffice 3.2.1.  It is
> broken in OpenOffice 3.4.1 (never tested 3.3) and LibreOffice 4.0 & 4.1.  I
> never tested in anything earlier in LibreOffice.

Predates bibisect range, so
Whiteboard -> notBibisectable
Comment 12 Robinson Tryon (qubit) 2015-12-10 01:26:31 UTC Comment hidden (obsolete)
Comment 13 m.a.riosv 2016-05-24 23:44:34 UTC
*** Bug 47140 has been marked as a duplicate of this bug. ***
Comment 14 m.a.riosv 2016-05-24 23:45:26 UTC
*** Bug 100036 has been marked as a duplicate of this bug. ***
Comment 15 Jim Avera 2016-05-26 17:19:40 UTC Comment hidden (obsolete)
Comment 16 Xisco Faulí 2016-09-14 22:14:40 UTC
Replacing keyword 'notBibisectable' by 'preBibisect' as this bug is outside the bibisect range
Comment 17 Xisco Faulí 2017-09-29 08:51:58 UTC Comment hidden (obsolete)
Comment 18 Paolo Benvenuto 2017-09-29 11:56:46 UTC
confirmed in 5.4.1.2 ubuntu
Comment 19 lbartolome 2018-11-16 20:52:14 UTC
Working properly on Versión: 6.2.0.0.alpha1 (x64)
Comment 20 Daniel Silva 2019-03-08 02:59:24 UTC
Patch up to review that resolves this bug for Writer:
https://gerrit.libreoffice.org/#/c/64804/
Comment 21 Xisco Faulí 2019-06-10 14:55:15 UTC
(In reply to Daniel Silva from comment #20)
> Patch up to review that resolves this bug for Writer:
> https://gerrit.libreoffice.org/#/c/64804/

Patch restored in gerrit
Comment 22 Commit Notification 2019-07-31 16:12:27 UTC
Daniel Silva committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/+/f50363c7008c239d302944144beb256de6a55f38%5E%21

tdf#54908 Make selection active if there's a selection (Writer)

It will be available in 6.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 Commit Notification 2019-08-03 12:23:05 UTC
Daniel Silva committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/+/87d5c863109f7991e3f2f3a1eb970c00d5a27bd5%5E%21

tdf#54908 Make selection active if there's a selection (Writer)

It will be available in 6.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 24 Xisco Faulí 2019-08-12 09:03:30 UTC
It has been fixed in Writer, I guess we have to do the same in the other components, isn't it ?