Created attachment 80275 [details] Sample presentation showing the bug Open the attached example presentation, try0.opd, with LO 4.1.0.0 beta1. Verify that the slide has a non-serif text (Arial). Save as try2.odp. Restart LO and open try2.opd. The slide now has serif texts (Times New Roman) instead of Arial.
Hello Johan, I reproduce With master LO 4.2.0.0.alpha0+ Build ID: 60790b3f0ccc1779bcff2ddcc278a9027aedabe Windows 7 Home Premium Save and reopen try0.odp with LO 4.0.2.2 give the correct font. Have a nice day, Jacques Guilloeron
Hi Johan, thanks for reporting :) Did you open try2.odp also in e.g. 3.6.x or 4.0.x, to see if it's correct there (learning if the problem is at SAVE or OPEN or combined maybe..) best, Cor
Created attachment 80425 [details] Sample presentation as saved with 4.1
Yes. Opening and saving with 4.0 yields correct fonts. Opening and saving with 4.1 yields a document with changed fonts. When this document is opened in (a fresh copy of) 4.0 or 4.1, the changes are still there. See https://bugs.freedesktop.org/attachment.cgi?id=80425 .
The problem is still present in 4.1 RC1 and an absolute show stopper. Note that the fonts that get substituted are fonts that reside in the users ~/.fonts directory (i.e., they're not system wide). This might give a clue.
For the sake of completeness: the problem is not present in 3.5.7 and 4.0.3.3.
fonts are still OK after saving with LibO 4.0.4.2 so the regression has took place during LibO 4.1.x development
Lubos - I wonder if you have any thoughts here ? ( who worked on font-embedding for impress ? ) though perhaps this is unrelated :-)
Working and testing with the RC2, would give a much better expereince if this can be fixed by then ;) By the way: the problem is with saving the file and of course affects Draw too.
In my expereince, this does not affect direct formatting, but the fonts that are set in the Styles.
The difference (saving each side as .fodp) is: <style:style style:name="Standaard-subtitle" style:family="presentation"> <style:graphic-properties draw:stroke="none" draw:fill="none" draw:textarea-vertical-align="middle"> ... <style:paragraph-properties fo:margin-left="0cm" fo:margin-right="0cm" fo:text-align="center" fo:text-indent="0cm"/> <style:text-properties style:use-window-font-color="true" ... in this set of attributes ... </style:style> And diffing the text-properties we get (from old & working -> new and broken) <style:text-properties style:use-window-font-color="true" style:text-outline="false" style:text-line-through-style="none" -fo:font-family="Arial" style:font-family-generic="roman" -style:font-pitch="variable" fo:font-size="32pt" fo:font-style="normal" +style:font-name="Arial" fo:font-size="32pt" fo:font-style="normal" fo:text-shadow="none" style:text-underline-style="none" fo:font-weight="normal" style:letter-kerning="true" -style:font-family-asian="'AR PL UMing CN'" -style:font-family-generic-asian="system" -style:font-pitch-asian="variable" style:font-size-asian="32pt" +style:font-name-asian="AR PL UMing CN" style:font-size-asian="32pt" style:font-style-asian="normal" style:font-weight-asian="normal" -style:font-family-complex="'Lohit Devanagari'" -style:font-family-generic-complex="system" -style:font-pitch-complex="variable" style:font-size-complex="32pt" -style:font-style-complex="normal" style:font-weight-complex="normal" -style:text-emphasize="none" style:font-relief="none" -style:text-overline-style="none" +style:font-name-complex="Lohit Devanagari" +style:font-size-complex="32pt" style:font-style-complex="normal" +style:font-weight-complex="normal" style:text-emphasize="none" +style:font-relief="none" style:text-overline-style="none" style:text-overline-color="font-color"/> Adding an fo:font-family="Ariel" back into the mix and we get what is expected; interesting.
Lubos, Muthu, could you please have a look? I am not sure how many users might be affected. But it smells like a ticking bomb. It would be great to have this fixed in 4.1.0.3.
(In reply to comment #12) > I am not sure how many users might be affected. But it smells like a ticking > bomb. It would be great to have this fixed in 4.1.0.3. Indeed. Every odg or odp that is edited, containing font settings in a style, is affected. I'll add a note somewhere in the release notes for the RC2.
I've gotten as far as xmloff/source/style/styleexp.cxx:324, where xPropStates has mnIndex -1 in master instead of 183 (whatever 183 is) in 4.0. And there are actually many more items that have -1 instead of some positive value, so possibly there's more broken that just fonts. Trying to figure out where that change comes from I get lost in property map madness, and as I'm not very familiar with xmloff, I'll leave that to somebody else.
It could be the same problem as in bug 57231. I'm currently knee-deep in property maps too :-(
range: http://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=c7ef87aa8db6d892491891dcda6bfbaa1ad1d0d2..fea303a3d7422d26b7d4ea26126b0769e66dda40 Probably introduced due commit: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b40bcde076f9fabf24810d2520e878d604d99637 and/or http://cgit.freedesktop.org/libreoffice/core/commit/?id=8ad5c064190084cb46ce8847bfa306ce3cb01987 Kind regards, Joren
Created attachment 82258 [details] bisect log
@joren: super, thanks! (In reply to comment #16) > Probably introduced due commit: > > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=b40bcde076f9fabf24810d2520e878d604d99637 > > and/or > > http://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=8ad5c064190084cb46ce8847bfa306ce3cb01987 @radek: can you pls have a look? thanks,
style:font-name is not exported
It's b40bcde076f9fabf24810d2520e878d604d99637 . And Radek is no longer at SUSE, I'll have a look.
https://gerrit.libreoffice.org/#/c/4816/
LuboÅ¡ LuÅak committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=a1190c9d2e85c4ccb9db106fe9eb4a48219ac126 fix reading fonts from .odp using style::font-name (fdo#65338) The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
backporting to the 4.1.x branch should be considered ASAP this is a MAB and a nasty regression from the 4.0.x branch. would be nice to integrate the fix in 4.1.0 RC3
LuboÅ¡ LuÅak committed a patch related to this issue. It has been pushed to "libreoffice-4-1": http://cgit.freedesktop.org/libreoffice/core/commit/?id=cc3293b94ab58b196bc2786eb4012d64351e8fa4&h=libreoffice-4-1 fix reading fonts from .odp using style::font-name (fdo#65338) It will be available in LibreOffice 4.1.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
LuboÅ¡ LuÅak committed a patch related to this issue. It has been pushed to "libreoffice-4-1-0": http://cgit.freedesktop.org/libreoffice/core/commit/?id=b84347d905a5fb4c04077ace924744c82c76cce3&h=libreoffice-4-1-0 fix reading fonts from .odp using style::font-name (fdo#65338) It will be available already in LibreOffice 4.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
re-resolving fixed; back-ported to 4.1.0 etc - thanks Lubos
(In reply to comment #26) > re-resolving fixed; back-ported to 4.1.0 etc - thanks Lubos +1 Great :)
Confirmed. Thanks.
*** Bug 67216 has been marked as a duplicate of this bug. ***
*** Bug 67754 has been marked as a duplicate of this bug. ***
Version: 4.4.2.2 Build ID: 40m0(Build:2) Locale: en_US Netrunner (Ubuntu 14.04) Working on an ebook and am saving document as doc file (not sure if that has anything to do with it but...) I've created a style called <Poetry (Single Space)>. This style is inherited from the Default. The default line spacing is 1.5. The Poetry spacing is 1. I notice that whenever I close and reopen the document, the Poetry style reverts to 1.5. I initially was going to open a new bug, but I'm wondering if this is related? Let me know. I've reopened the bug.
The Component is Writer, by the way. I just noticed this bug pertained to Impress.
I believe you have a different bug that this one which was closed two years ago. Whenever in doubt file a new one because opening an old one can lead to the bug being assigned to someone who has died or otherwise become inactive, or simply doesn't have the time to work that that specific area.
Migrating Whiteboard tags to Keywords: (bibisected) [NinjaEdit]