Created attachment 81742 [details] DOCX containing 'Restricted' paragraphs and an 'Editable' paragraph Problem description: When you load a DOCX that has a protection of type 'Restrict Editing' - LO loads it with no protection (I have opened a bug for the 'import' side in https://www.libreoffice.org/bugzilla/show_bug.cgi?id=66397). When you save the file back to a DOCX - the 'Restrict Editing' is lost, and when opening the file in Word - the user can edit anything he wants in the document. Password to disable restrictions is '12345'. Steps to reproduce: 1. Open the attached DOCX in LO 2. Save as a NEW.DOCX 3. Open the NEW.DOCX in Word 4. You can now edit anything in the document Current behavior: 'Restrict Editing' is lost. The user can edit anything in the NEW.DOCX in Word. Expected behavior: 'Restrict Editing' should be preserved. The user should be allowed to edit only the editable sections in the document. Operating System: All Version: 4.2.0.0.alpha0+ Master
The nodes that are not imported are: - <w:permStart> in the 'document.xml' file. - <w:permEnd> in the 'document.xml' file. - <w:documentProtection> in the 'settings.xml' file.
> The nodes that are not imported are: Of course, I meant 'the nodes that are not exported are'
See my comment with bug 66397 ?
I can confirm this behavior using Mac OSX 10.8.4 with LibreOffice Version: 4.2.0.0.alpha0+ Build ID: 9ab800829b8a0e44824dc11276b54b1870bc5b2b in combination of Word for Mac 2011. 'Data loss' - > major high in this case :) Kind regards, Joren
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: *Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.1 or later) https://www.libreoffice.org/download/ *If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior *If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT *Update the version field *Reply via email (please reply directly on the bug tracker) *Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-04-01
Reproduced with attachment 81742 [details]. Win 8.1 32-bit MSO 2013 LibO Version: 5.0.0.0.alpha1+ Build ID: f0edb677f09ad338e22ac3b5d91497b4479e0b3c TinderBox: Win-x86@39, Branch:master, Time: 2015-04-27_00:34:58 Locale: fi_FI
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.1.5 or 5.2.1 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20160920
confirmed protection is not exported (and not imported) still exists on Ubuntu 16.04 with LO5.3beta1. used bibisect43all oldest and was not able to import/export the protection, so marking as notbibisectable/inherited.
Implemented: - import/export document protection settings - added unit test for checking of import/export document protection settings. Now we have 3 unit tests: -- DECLARE_OOXMLEXPORT_TEST(testSectionProtection, "sectionprot.odt") -- DECLARE_OOXMLEXPORT_TEST(testTDF99434, "protectedform.docx") -- DECLARE_OOXMLEXPORT_TEST(tdf66398_permissions, "tdf66398_permissions.docx")
Serge Krot committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=2694162969cf86ef366d3ce812fccd0630acc800 tdf#66398 Import/export docx document protection properties It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Serge Krot committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=40f627c28deb9c7eacd77c4a2c4e2eb919d5cf88 tdf#66398 Remove double initialization of the form protection It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Serge Krot committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=4054051cd5aee8cbc6cd2b3384b4ab3d6b6a6ace tdf#66398 Do not output document protection in docx twice It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Serge Krot committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f4cbd31465d3737855e694b7341fb3bc063d63c4 related tdf#66398 remove useless breaks It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Implemented: - Permission ranges are parsed using temporary structure inside DomainMapper_Impl in the same way as parsing of bookmarks was done. - When complete permission range is parsed we add a new bookmark with special name. Syntax is: -- "permission-for-user:<permission-id>:<permission-user-name>" -- "permission-for-group:<permission-id>:<permission-group-name>" - During output into DOCX we intercept such names and perform output of the w:pernStart and w:PermEnd nodes instead of w:bookmarkStart and w:bookmarkEnd. - All other output formats will have additional bookmarks range indicating former permission ranges inside DOCX input file.
Serge Krot committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f5c266695a4a88da7db971a21915e2bbf758d48e tdf#66398 Parse and output permissions for DOCX using bookmarks It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Implemented: * Enhanced unit test: check permissions at content level, see DECLARE_OOXMLEXPORT_TEST(tdf66398_permissions, "tdf66398_permissions.docx").
Serge Krot committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=8b7910e0ba63aebb6fd6befa937259420f7266f3 tdf#66398 Enhance unit test: check permissions at content level It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Serge Krot committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=1818bffa3e97a47f5bdde0bca9ea6679b93543d2 tdf#66398 Fix copy-paste: call start() bookmark instead of end() It will be available in 6.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.