Created attachment 84919 [details]
If you flip an image horizontally (not sure about vertically) this "flip" is lost when saving and loading in pptx file format.
Steps to reproduce:
1. Create a presentation with a slide having an image
2. Flip the image horizontally
3. Save and re-load the presentation in pptx format
Images flip state is lost.
Operating System: Fedora
Version: 184.108.40.206 rc
I can confirm that behavior (horizontal flip) on LO 3.6.7 (Ubuntu 12.04).
-> so I set version to 3.6.7 as an earlier version that reproducible
If image flipped vertically it will be placed in the bottom right off the screen after reopening file.
Problem persists under GNU/Linux running v220.127.116.11 Build ID: 14ed55896fdfcb93ff437b85c4f3e1923d2b1409. Horizontally flipped images appear to be reverted, while vertically flipped images are mispositioned off the slide to the lower right (for an image taking up most of a slide).
** Please read this message in its entirety before responding **
To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.
There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.
If you have time, please do the following:
Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.1 or later): https://www.libreoffice.org/download/
If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System
Please DO NOT
Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case)
If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)
2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword
Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa
Thank you for your help!
-- The LibreOffice QA Team This NEW Message was generated on: 2015-07-18
This issue is still present in
Build ID: 81898c9f5c0d43f3473ba111d7b351050be20261
Locale: es-ES (es_ES)
on Windows 7 (64-bit)
Created attachment 122799 [details]
a suite of word2013 tests and accompanying word2013 PDFs
Importing flipped images needs to be fixed first as others have noted that the image doesn't import in the proper position if it has been flipped. Better to have the image appear in the right position.
Created attachment 122944 [details]
patch to export flip to pptx
The rotate and flip functions don't seem to agree well with each other - rotate spins the image all over the place. I can't figure out how to fix that so I'm attaching my patch to fix this particular bug and walking away.
I think the key file to look at is svx/source/svdraw/svdotext.cxx TRSetBaseGeometry(). This decomposes() the shape added by oox/source/drawingml/shape.cxx createAndInsert() except that it doesn't decompose it into exactly the same flip/rotation.
*** Bug 104209 has been marked as a duplicate of this bug. ***
There's a patch of yours attached here, should you upload it to gerrit for review instead?
(In reply to Justin L from comment #6)
> Importing flipped images needs to be fixed first as others have noted that
> the image doesn't import in the proper position if it has been flipped.
According to the 5.3 daily bibisect, this was fixed on Oct 28, likely from Mike's fix for bug 103473 (backported to 5.2.4).
author Mike Kaganski <firstname.lastname@example.org> 2016-10-29 12:31:29
tdf#103473: Ensure positive rectangle size
Also remove conversion of both negative scales into rotation,
because it is handled by flip; use strict comparison instead of
approximate float less because it's correct here, and also because
basegfx::fTools::less ultimately uses rtl_math_approxEqual, which
description states: attention approxEqual( value!=0.0, 0.0 ) _never_ yields true.
So, this bug needs to be re-evaluated, and my patch potentially is still a valid response.
(In reply to Xisco Faulí from comment #9)
> There's a patch of yours attached here, should you upload it to gerrit
That patch no longer seems to work (if it ever did - kinda hard to tell when the import didn't work). Someone who understands images can use that as a starting point and devise a proper fix.
This bug is not fixed. Tested in LO 6.0alpha1
Paul Trojahn committed a patch related to this issue.
It has been pushed to "master":
tdf#68759 PPTX: Export IsMirrored
It will be available in 6.1.0.
The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
Affected users are encouraged to test the fix and report feedback.
Nice work! I verified that all of the items in the test suite round-tripped OK.