Bug 70039 - FILEOPEN: PPTX Import does not show 3D elements in 3D
Summary: FILEOPEN: PPTX Import does not show 3D elements in 3D
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Regina Henschel
URL:
Whiteboard: BSA target:24.8.0
Keywords: filter:pptx
: 123345 (view as bug list)
Depends on: 159515
Blocks: PPTX-3D
  Show dependency treegraph
 
Reported: 2013-10-02 14:43 UTC by Christian
Modified: 2024-03-23 10:43 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
Test Slide (114.69 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2013-10-02 14:43 UTC, Christian
Details
Screenshot from MS-PPT 2010 (50.13 KB, image/png)
2013-10-02 14:43 UTC, Christian
Details
False rending of LO 5.0.2.2 on Linux x86_64 (22.41 KB, image/png)
2015-10-18 12:58 UTC, Christian
Details
Spreadsheet with values used in the patch (32.55 KB, application/vnd.oasis.opendocument.calc)
2024-02-03 15:43 UTC, Regina Henschel
Details
Spreadsheet with values used in the patch (65.11 KB, application/vnd.oasis.opendocument.calc)
2024-02-10 17:19 UTC, Regina Henschel
Details
Lighting preset values from MSO specification (140.71 KB, application/vnd.oasis.opendocument.calc)
2024-03-06 22:01 UTC, Regina Henschel
Details
Lighting preset values from MSO specification (135.99 KB, application/vnd.oasis.opendocument.calc)
2024-03-08 00:14 UTC, Regina Henschel
Details
info about material preset values used (24.87 KB, application/vnd.oasis.opendocument.calc)
2024-03-17 18:22 UTC, Regina Henschel
Details
Screen snapshot on macOS with https://gerrit.libreoffice.org/c/core/+/164853 (955.21 KB, image/png)
2024-03-19 00:13 UTC, Patrick Luby (volunteer)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christian 2013-10-02 14:43:04 UTC
Created attachment 86971 [details]
Test Slide

The Slide in the testcase does not show up as in Power-Point 2010

To reproduce simply open the testcase with LibreOffice

A screenshot of MS-PP is provided as reference.

              
Operating System: Ubuntu
Version: 4.1.1.2 release
Comment 1 Christian 2013-10-02 14:43:54 UTC
Created attachment 86972 [details]
Screenshot from MS-PPT 2010
Comment 2 Jorendc 2013-10-03 20:45:27 UTC
I can confirm this behavior, tested using Mac OSX 10.8.5 with Libreoffice  Version: 4.1.2.3 Build ID: 40b2d7fde7e8d2d7bc5a449dc65df4d08a7dd38

Kind regards,
Joren
Comment 3 Xisco Faulí 2014-07-24 14:49:19 UTC
This issue is still reproducible with 

Version: 4.3.1.0.0+
Build ID: 0d5d8c22f7be41d408d8ee4012ef1a6f4368423e
TinderBox: Win-x86@51-TDF, Branch:libreoffice-4-3, Time: 2014-07-23_05:34:04
Comment 4 QA Administrators 2015-09-04 02:48:01 UTC Comment hidden (noise)
Comment 5 Xisco Faulí 2015-09-04 08:24:47 UTC
This issue is still present in

Version: 5.0.1.2
Build ID: 81898c9f5c0d43f3473ba111d7b351050be20261
Locale: es-ES (es_ES)

on Windows 7 (64-bit)
Comment 6 Christian 2015-10-18 12:57:29 UTC
Bug still present in LibreOffice 5.0.2.2 on Linux x86_64 (CentOS7)
Build ID: 37b43f919e4de5eeaca9b9755ed688758a8251f
Comment 7 Christian 2015-10-18 12:58:40 UTC
Created attachment 119713 [details]
False rending of LO 5.0.2.2 on Linux x86_64
Comment 8 QA Administrators 2016-11-08 11:13:35 UTC Comment hidden (noise)
Comment 9 QA Administrators 2016-11-08 11:17:40 UTC
Still present in

Version: 5.3.0.0.alpha1+
Build ID: 8dc495c93239739629683bb29e4110f5c57c94f0
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; VCL: gtk3; 
Locale: ca-ES (ca_ES.UTF-8); Calc: group
Comment 10 vihsa 2017-06-01 07:00:00 UTC
reproducible with lo viewer version: 5.5.0.0.alpha0+ / build id : ec79f34 / android 5.1
Comment 11 QA Administrators 2018-06-02 03:09:00 UTC Comment hidden (noise)
Comment 12 Christian 2018-06-02 11:27:32 UTC
Still an issue with LO 
Version: 6.0.4.2
Build ID: 9b0d9b32d5dcda91d2f1a96dc04c645c450872bf
CPU threads: 4; OS: Linux 4.16; UI render: default; VCL: kde4; 
Locale: de-DE (de_DE.UTF-8); Calc: group
Comment 13 Buovjaga 2019-09-29 18:09:28 UTC
Still in 6.4 and already in 3.3.0

Version: 6.4.0.0.alpha0+ (x64)
Build ID: d744838991594eebe27acc4c7d9fb4579d654853
CPU threads: 4; OS: Windows 10.0; UI render: default; VCL: win; 
TinderBox: Win-x86_64@42, Branch:master, Time: 2019-09-29_05:12:00
Locale: fi-FI (fi_FI); UI-Language: en-US
Calc: threaded
Comment 14 Gerald Pfeifer 2021-08-04 17:58:54 UTC
Still in 7.3 alpha:

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: e58348e73b5f3f6eb8fd68eb50c1bc4b58f32104
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-08-03_23:23:08
Comment 15 Regina Henschel 2021-11-25 19:46:36 UTC
*** Bug 123345 has been marked as a duplicate of this bug. ***
Comment 16 QA Administrators 2023-11-26 03:13:59 UTC Comment hidden (noise, obsolete)
Comment 17 Gerald Pfeifer 2023-11-26 08:27:24 UTC
Still there with

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9602f8a9318dd4d3409856e2ae06abe96e72b51b
CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Comment 18 Regina Henschel 2024-01-23 19:13:27 UTC
The 3D Effects of MS Office are in many aspects not compatible with the extrusion properties in ODF:
Bevel - no Bevel
more than three lights - max two lights
preset for camera - NA
preset for lighting - NA
preset for material - NA
contour color - NA
3D on groups - NA
three 3D modes for text - no definition in ODF, one mode in LO
stroke kept in 3D - no definition in ODF, not displayed in LO (bug 159334)

Nevertheless we should try to show a custom-shape in extruded mode as good as possible. That is better than totally ignoring extrusion and 3D rotation. I'll try to do something it that direction.
Comment 19 Regina Henschel 2024-02-03 15:39:11 UTC
Rendering of extruded shape with bitmap fill is currently broken for images with transparent parts, see bug 159515. So a solution to import a 3D image as custom shape rectangle with bitmap fill will not work.
Comment 20 Regina Henschel 2024-02-03 15:43:03 UTC
Created attachment 192371 [details]
Spreadsheet with values used in the patch

The start of my work is in https://gerrit.libreoffice.org/c/core/+/162594
It uses a fixed set of values for the preset camera types of OOXML. The attachment contains the values itself and remarks on how the values were created.
Comment 21 Regina Henschel 2024-02-10 17:19:49 UTC
Created attachment 192494 [details]
Spreadsheet with values used in the patch

The spreadsheet contains the values themselves, a sheet as preparation for an initializer list, and a sheet with remarks.
Comment 22 Commit Notification 2024-02-19 12:58:18 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6e5529d7382558a38e547074e2f674e85e11e66e

tdf#70039 convert 3D effects to extrusion

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 23 Regina Henschel 2024-02-19 13:51:09 UTC
This is the first step. It imports an extruded shape now in extrusion mode. Still missing are suitable import of lighting and material. Thus status is not "fixed".
Comment 24 Gerald Pfeifer 2024-02-20 14:17:29 UTC
I gave the test slide attached here a try with tonight's daily build
and it looks awesome (i.e., it looks awesomely similar to PowerPoint,
the slide itself being simply ugly ;-).

  Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
  Build ID: ef9e1116d1100af50d7b74dcee5155c81b7b50fb
  CPU threads: 12; OS: Linux 6.7; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US


On regression only possibly caused by your work: When I open the test 
document and close it right away, I am still asked whether I want to
save changes. Same when opening from the command-line and then quiting
via <Ctrl>-<Q>. (If I hit <Ctrl>-<Q> while it's still starting and 
loading it does not ask.)
Comment 25 Gerald Pfeifer 2024-02-20 14:19:59 UTC
And, trara!, it looks like you also addressed bug #145531,
"FILEOPEN PPTX: 3D button/cuboid with perspective shows as rectangle".
Comment 26 Regina Henschel 2024-03-06 22:01:27 UTC
Created attachment 193004 [details]
Lighting preset values from MSO specification

The attached file contains the preset values for lighting as found in the specification of MS Office. And the file contains the intermediate steps used to generate a sheet for CSV export. Such CSV-file helps to fill the initializer list in the code.
Some further infos are on the 'ReadMe' sheet in that file.
Comment 27 Regina Henschel 2024-03-08 00:14:32 UTC
Created attachment 193023 [details]
Lighting preset values from MSO specification
Comment 28 Commit Notification 2024-03-13 20:44:03 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/98b06ed3583fcc1f720ceb919cdd57ede7952a71

tdf#70039 import lighting of extruded shapes

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 29 Regina Henschel 2024-03-13 20:49:49 UTC
Not finished. Material and enabling of 3D-images are still missing. Nevertheless you should test it, so that regressions are noticed early.

Lighting in MSO and LibreOffice are basically incompatible. Thus the solution has a lot of workarounds and compromises.
Comment 30 Regina Henschel 2024-03-17 18:22:34 UTC
Created attachment 193165 [details]
info about material preset values used
Comment 31 Patrick Luby (volunteer) 2024-03-19 00:13:08 UTC
Created attachment 193184 [details]
Screen snapshot on macOS with https://gerrit.libreoffice.org/c/core/+/164853
Comment 32 Commit Notification 2024-03-20 17:06:40 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2eabd56ff5f65733c6fa1bcef14d4a39c21dddc7

tdf#70039 import material of extruded shapes

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 33 Gerald Pfeifer 2024-03-21 07:55:35 UTC
With the latest change(s) the document from bug #145531 regressed quite
a bit versus the state a week ago.
Comment 34 Commit Notification 2024-03-23 09:20:41 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/15e43d9679773efcf869ff8272c7932b59fe1c68

tdf#70039 partly enable 3D-image from pptx

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 35 Regina Henschel 2024-03-23 10:43:30 UTC
Nearly finished. Missing is an adaption in the export. The 3D scenes are recreated from InteropGrabBag, but the changes to the rotation angles are not reverted. That was added for 3D-images with bug 133037 (BTW does not work for flipped images), but is now needed for all the other 3D-objects too.